Fix bound s for line route and connection link Refs #32

4 files changed, 11 insertions, 27 deletions

diff --git a/app/maps/connection_link_map.rb b/app/maps/connection_link_map.rb
index 8071c5f0f..dd642c47d 100644
--- a/app/maps/connection_link_map.rb
+++ b/app/maps/connection_link_map.rb
@@ -21,7 +21,7 @@ class ConnectionLinkMap < ApplicationMap
       page << map.add_control( hover_control_display_name(:stop_areas_layer) )
       #page << map.add_layer(kml_layer(connection_link, :styleMap => StyleMap::ConnectionLinkStyleMap.new( :style => connection_link_style).style_map))
       #page << map.add_layer(kml_layer(polymorphic_path([referential, connection_link, :stop_areas], :format => :kml), :styleMap => StyleMap::StopAreasStyleMap.new.style_map))
-      page << map.zoom_to_extent(bounds) if bounds
+      page << map.zoom_to_extent(bounds.to_google.to_openlayers) if bounds
     end
   end
 
@@ -30,11 +30,7 @@ class ConnectionLinkMap < ApplicationMap
   end
 
   def bounds
-    @bounds ||= 
-      begin
-        wgs84_bounds = Chouette::StopArea.bounds
-        OpenLayers::Bounds.new(wgs84_bounds.lower_corner.x, wgs84_bounds.lower_corner.y, wgs84_bounds.upper_corner.x, wgs84_bounds.upper_corner.y).transform(OpenLayers::Projection.new("EPSG:4326"), OpenLayers::Projection.new("EPSG:900913"))
-      end
+    @bounds ||= GeoRuby::SimpleFeatures::Point.bounds(connection_link.stop_areas.collect(&:geometry).compact)
   end
 
 end
diff --git a/app/maps/line_map.rb b/app/maps/line_map.rb
index e451f452d..60e6cb4fc 100644
--- a/app/maps/line_map.rb
+++ b/app/maps/line_map.rb
@@ -22,17 +22,12 @@ class LineMap < ApplicationMap
       page << map.add_layer(:stop_areas_layer)
       page << map.add_control( hover_control_display_name(:stop_areas_layer) )
 
-      page << map.zoom_to_extent(bounds) if bounds
+      page << map.zoom_to_extent(bounds.to_google.to_openlayers) if bounds
     end
   end
 
   def bounds
-    @bounds ||= 
-      begin
-        wgs84_bounds = GeoRuby::SimpleFeatures::Point.bounds(line.stop_areas.map(&:geometry))
-        OpenLayers::Bounds.new(wgs84_bounds.lower_corner.x, wgs84_bounds.lower_corner.y, wgs84_bounds.upper_corner.x, wgs84_bounds.upper_corner.y).transform(OpenLayers::Projection.new("EPSG:4326"), OpenLayers::Projection.new("EPSG:900913")) if wgs84_bounds
-      end
-
+    @bounds ||= GeoRuby::SimpleFeatures::Point.bounds(line.stop_areas.collect(&:geometry).compact)
   end
 
   def ready?
diff --git a/app/maps/route_map.rb b/app/maps/route_map.rb
index c28c22e62..daa3de23f 100644
--- a/app/maps/route_map.rb
+++ b/app/maps/route_map.rb
@@ -17,23 +17,16 @@ class RouteMap < ApplicationMap
 
       #page << map.add_layer(kml_layer(line, :styleMap => StyleMap::LineStyleMap.new( :style => line_style).style_map))
       page << map.add_layer(kml_layer([route.referential, route.line, route], :styleMap => StyleMap::RouteStyleMap.new.style_map))
-      page << map.zoom_to_extent(bounds) if bounds
+      page << map.zoom_to_extent(bounds.to_google.to_openlayers) if bounds
     end
   end
 
   def ready?
-    route_bounds.present?
-  end
-
-  def route_bounds
-    @route_bound ||= (route.geometry.empty? ? Chouette::StopArea.bounds : route.geometry.envelope)
+    bounds.present?
   end
 
   def bounds
-    @bounds ||= OpenLayers::Bounds.new(
-        route_bounds.lower_corner.x, route_bounds.lower_corner.y, 
-        route_bounds.upper_corner.x, route_bounds.upper_corner.y).
-      transform(OpenLayers::Projection.new("EPSG:4326"), OpenLayers::Projection.new("EPSG:900913"))
+    @bounds ||= GeoRuby::SimpleFeatures::Point.bounds(route.stop_areas.collect(&:geometry).compact)
   end
 
 end
diff --git a/app/views/connection_links/_form.erb b/app/views/connection_links/_form.erb
index a937f7197..dc4075015 100644
--- a/app/views/connection_links/_form.erb
+++ b/app/views/connection_links/_form.erb
@@ -5,10 +5,10 @@
     <%= form.input :connection_link_type, :as => :select, :collection => Chouette::ConnectionLink.connection_link_types, :include_blank => false, :member_label => Proc.new { |type| t("connection_link_types.label.#{type}") }  %>
     <%= form.input :comment %>  
     <%= form.input :link_distance %> 
-    <%= form.input :defaultduration, :as => :time ,:include_seconds => true , :label => @connection_link.human_attribute_name("default_duration")%>
-    <%= form.input :frequenttravellerduration, :as => :time ,:include_seconds => true , :label => @connection_link.human_attribute_name("frequent_traveller_duration")%>
-    <%= form.input :occasionaltravellerduration, :as => :time ,:include_seconds => true , :label => @connection_link.human_attribute_name("occasional_traveller_duration")%>
-    <%= form.input :mobilityrestrictedtravellerduration, :as => :time ,:include_seconds => true , :label => @connection_link.human_attribute_name("mobility_restricted_traveller_duration")%>
+    <%= form.input :defaultduration, :as => :time_select ,:include_seconds => true , :label => @connection_link.human_attribute_name("default_duration")%>
+    <%= form.input :frequenttravellerduration, :as => :time_select ,:include_seconds => true , :label => @connection_link.human_attribute_name("frequent_traveller_duration")%>
+    <%= form.input :occasionaltravellerduration, :as => :time_select ,:include_seconds => true , :label => @connection_link.human_attribute_name("occasional_traveller_duration")%>
+    <%= form.input :mobilityrestrictedtravellerduration, :as => :time_select ,:include_seconds => true , :label => @connection_link.human_attribute_name("mobility_restricted_traveller_duration")%>
     <%= form.input :mobility_restricted_suitability,:as => :boolean %>
     <%= form.input :stairs_availability,:as => :boolean %>
     <%= form.input :lift_availability,:as => :boolean %>