diff options
| author | Teddy Wing | 2017-05-23 17:15:22 +0200 |
|---|---|---|
| committer | Robert | 2017-05-29 08:49:52 +0200 |
| commit | 6df80378d2a8977c317fd93656599d3b70cf120b (patch) | |
| tree | d11c50ebbee70b1b3858f2395741aa8463f7ac3b | |
| parent | 100a89a8c11b8e14869da18c32134ac89b2fb0ef (diff) | |
| download | chouette-core-6df80378d2a8977c317fd93656599d3b70cf120b.tar.bz2 | |
IncreasingTimeOrderValidator: Improve whitespace
Make this more readable by realigning the code vertically.
Refs #870
| -rw-r--r-- | app/models/chouette/vehicle_journey_at_stops_are_in_increasing_time_order_validator.rb | 18 |
1 files changed, 14 insertions, 4 deletions
diff --git a/app/models/chouette/vehicle_journey_at_stops_are_in_increasing_time_order_validator.rb b/app/models/chouette/vehicle_journey_at_stops_are_in_increasing_time_order_validator.rb index 9a13ae103..3ec24ddd9 100644 --- a/app/models/chouette/vehicle_journey_at_stops_are_in_increasing_time_order_validator.rb +++ b/app/models/chouette/vehicle_journey_at_stops_are_in_increasing_time_order_validator.rb @@ -8,11 +8,21 @@ module Chouette def increasing_times(vehicle_journey) # TODO: Rename `previous` previous = nil + # TODO: Move `select` to a new named method - vehicle_journey.vehicle_journey_at_stops.select{|vjas| vjas.departure_time && vjas.arrival_time}.each do |vjas| - vehicle_journey.errors.add( :vehicle_journey_at_stops, 'time gap overflow') unless vjas.increasing_times_validate( previous) - previous = vjas - end + vehicle_journey + .vehicle_journey_at_stops + .select { |vjas| vjas.departure_time && vjas.arrival_time } + .each do |vjas| + unless vjas.increasing_times_validate(previous) + vehicle_journey.errors.add( + :vehicle_journey_at_stops, + 'time gap overflow' + ) + end + + previous = vjas + end end end end |
