VehicleJourneyAtStop: Remove `error_message` from day offset validator

Robert wasn't a fan of the lambda in code review, so I'm getting rid of
it and just duplicating the I18n call.

Refs #3597

1 files changed, 16 insertions, 10 deletions

diff --git a/app/models/chouette/vehicle_journey_at_stop.rb b/app/models/chouette/vehicle_journey_at_stop.rb
index 3e83eb41a..3c350b2ae 100644
--- a/app/models/chouette/vehicle_journey_at_stop.rb
+++ b/app/models/chouette/vehicle_journey_at_stop.rb
@@ -35,20 +35,26 @@ module Chouette
     end
 
     def day_offset_must_be_within_range
-      error_message = lambda do
-        I18n.t(
-          'vehicle_journey_at_stops.errors.day_offset_must_not_exceed_max',
-          local_id: vehicle_journey.objectid.local_id,
-          max: DAY_OFFSET_MAX + 1
-        )
-      end
-
       if day_offset_outside_range?(arrival_day_offset)
-        errors.add(:arrival_day_offset, error_message)
+        errors.add(
+          :arrival_day_offset,
+          I18n.t(
+            'vehicle_journey_at_stops.errors.day_offset_must_not_exceed_max',
+            local_id: vehicle_journey.objectid.local_id,
+            max: DAY_OFFSET_MAX + 1
+          )
+        )
       end
 
       if day_offset_outside_range?(departure_day_offset)
-        errors.add(:departure_day_offset, error_message)
+        errors.add(
+          :departure_day_offset,
+          I18n.t(
+            'vehicle_journey_at_stops.errors.day_offset_must_not_exceed_max',
+            local_id: vehicle_journey.objectid.local_id,
+            max: DAY_OFFSET_MAX + 1
+          )
+        )
       end
     end