TableBuilder;Link: Remove default `:get` for HTTP method

Don't set links as `method: :get` by default. This shows up as:

    link_to _, _, method: :get

If we set the method to `nil` instead, we don't get a
`data-method="get"` attribute in our HTML output. Instead, we get no
`data-method` attribute, which is a lot better and cleaner.

I had originally used `:get` as a default because I wanted to generalise
links and certain ones we create need `:delete` or `:put` methods. I
figured, since we're always going to be passing `method:` to `link_to`,
we should have a sane default for that option. However, using `nil` is
even better as a default because then we don't get an extra attribute in
our HTML at all.

Refs #3479

2 files changed, 2 insertions, 2 deletions

diff --git a/app/helpers/table_builder_helper/custom_links.rb b/app/helpers/table_builder_helper/custom_links.rb
index a4a8bba4f..f03acac1e 100644
--- a/app/helpers/table_builder_helper/custom_links.rb
+++ b/app/helpers/table_builder_helper/custom_links.rb
@@ -35,7 +35,7 @@ module TableBuilderHelper
     end
 
     def method_for_action(action)
-      ACTIONS_TO_HTTP_METHODS[action] || :get
+      ACTIONS_TO_HTTP_METHODS[action]
     end
 
     def actions_after_policy_check
diff --git a/lib/link.rb b/lib/link.rb
index 911f189c9..c875b85ac 100644
--- a/lib/link.rb
+++ b/lib/link.rb
@@ -1,7 +1,7 @@
 class Link
   attr_reader :name, :href, :method, :data
 
-  def initialize(name: nil, href:, method: :get, data: nil)
+  def initialize(name: nil, href:, method: nil, data: nil)
     @name = name
     @href = href
     @method = method