AutocompleteLinesController: Don't error if no `q` param is passed

Previously the action would respond with a 500 error if no `q` parameter
was given in the request. Instead, respond with a 200 and fix the error
that occurs as a result of assuming that `params[:q]` exists in
`AutocompleteLinesController#collection`.

Refs #5889

2 files changed, 10 insertions, 0 deletions

diff --git a/app/controllers/autocomplete_lines_controller.rb b/app/controllers/autocomplete_lines_controller.rb
index 8398a92c1..c931dfa42 100644
--- a/app/controllers/autocomplete_lines_controller.rb
+++ b/app/controllers/autocomplete_lines_controller.rb
@@ -6,6 +6,8 @@ class AutocompleteLinesController < ChouetteController
   protected
 
   def collection
+    return [] if !params[:q]
+
     @lines = referential.line_referential.lines
 
     @lines = @lines
diff --git a/spec/controllers/autocomplete_lines_controller_spec.rb b/spec/controllers/autocomplete_lines_controller_spec.rb
index d52cecd04..60dff5381 100644
--- a/spec/controllers/autocomplete_lines_controller_spec.rb
+++ b/spec/controllers/autocomplete_lines_controller_spec.rb
@@ -63,5 +63,13 @@ RSpec.describe AutocompleteLinesController, type: :controller do
 
       expect(assigns(:lines).to_a).to eq([line])
     end
+
+    it "doesn't error when no `q` is sent" do
+      get :index,
+        referential_id: referential.id
+
+      expect(assigns(:lines).to_a).to be_empty
+      expect(response).to be_success
+    end
   end
 end