aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlban Peignier2018-01-07 22:58:55 +0100
committerAlban Peignier2018-01-07 22:59:20 +0100
commitfa63d6e3d51ccc0b3a38616747fcd91b5fdfbba5 (patch)
tree50f69c0ea454e2ba3d8576bfd5fc0c4d98127bff
parentb4ef1cecee91ce769ff1e4cd48ae9a8f6e06af27 (diff)
downloadchouette-core-fa63d6e3d51ccc0b3a38616747fcd91b5fdfbba5.tar.bz2
Change Chouette::AreaType.find to return nil if specified code is nil. Refs #5488
-rw-r--r--app/models/chouette/area_type.rb2
-rw-r--r--spec/models/chouette/area_type_spec.rb4
2 files changed, 6 insertions, 0 deletions
diff --git a/app/models/chouette/area_type.rb b/app/models/chouette/area_type.rb
index 43d96b391..4703ea646 100644
--- a/app/models/chouette/area_type.rb
+++ b/app/models/chouette/area_type.rb
@@ -13,6 +13,8 @@ class Chouette::AreaType
@@instances = {}
def self.find(code)
+ return unless code
+
code = code.to_sym
@@instances[code] ||= new(code) if ALL.include? code
end
diff --git a/spec/models/chouette/area_type_spec.rb b/spec/models/chouette/area_type_spec.rb
index 82c3f96bc..67d218df8 100644
--- a/spec/models/chouette/area_type_spec.rb
+++ b/spec/models/chouette/area_type_spec.rb
@@ -9,6 +9,10 @@ RSpec.describe Chouette::AreaType do
end
describe ".find" do
+ it "returns nil if the given code is nil" do
+ expect(Chouette::AreaType.find(nil)).to be_nil
+ end
+
it "returns nil if the given code is unknown" do
expect(Chouette::AreaType.find('dummy')).to be_nil
end