chouette-core/spec, branch 5647-scope-custom-fields-validations Chouette manage transport static data Refs #5647; Scope CustomField validations on workgroup 2018-01-22T10:05:09+00:00 Zog 2018-01-22T10:05:09+00:00 865e58859cb83da4e36d8502fc778d383c756c26 






Add missing spec on VehicleJourneyAtStop
2018-01-19T15:12:28+00:00

Zog

2018-01-19T15:12:21+00:00

18d756c03fce40648187ab18f29896d4f2c17b23












Merge pull request #247 from af83/5592-workbenches-show--filter-by-workgroup-on-initial-load
2018-01-19T14:26:31+00:00

Luc Donnet

2018-01-19T14:26:31+00:00

f8755d7c9693be54e2c0d800e7a6c26939a15c91

5592 workbenches show  filter by workgroup on initial load




5592 workbenches show  filter by workgroup on initial load






Merge pull request #248 from af83/5623-fix-schedule-when-jp-is-prefilled
2018-01-19T14:24:39+00:00

Luc Donnet

2018-01-19T14:24:39+00:00

bd6fb5c4c545fa004374df8122151b3adc752f40

5623 fix schedule when jp is prefilled




5623 fix schedule when jp is prefilled






Fix compliance check sets breadcrumb, locales and datas display
2018-01-19T08:34:20+00:00

Luc Donnet

2018-01-19T08:33:49+00:00

fc4894a6c3595050af34206beecdfefe87af3c11












Refs #5614 @0.5h; Fix schedule computation when departure minutes are not set
2018-01-17T10:44:15+00:00

Zog

2018-01-17T10:44:15+00:00

351af77182537dbb53e7bbd99d37dde50cd11ffe












offer_workbenches/show.html.erb_spec: Give workbenches same workgroup
2018-01-17T10:32:26+00:00

Teddy Wing

2018-01-17T10:32:26+00:00

9f3f7c5f71fee181f7f10a4a73d08fb1a0c1795b

I was getting the following test failures after having modified
`Workbench#all_referentials` in
93b60066cc49d699171d6a50798c5939a4644eea:

    Failures:

      1) workbenches/show should include #<Referential id: 5, name: "Test 4", slug: "test_4", created_at: "2018-01-17 10:18:47", updated_at: "...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>
         Failure/Error: expect(workbench.all_referentials).to include different_organisation_referential

           expected #<ActiveRecord::AssociationRelation [#<Referential id: 3, name: "Test 2", slug: "test_2", created_at:...om_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]> to include #<Referential id: 5, name: "Test 4", slug: "test_4", created_at: "2018-01-17 10:18:47", updated_at: "...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>
           Diff:
           @@ -1,2 +1,25 @@
           -[#<Referential id: 5, name: "Test 4", slug: "test_4", created_at: "2018-01-17 10:18:47", updated_at: "2018-01-17 10:18:49", prefix: "organisation_5", projection_type: nil, time_zone: "Europe/Paris", bounds: nil, organisation_id: 6, geographical_bounds: nil, user_id: nil, user_name: nil, data_format: "netex", line_referential_id: 14, stop_area_referential_id: 10, workbench_id: 3, archived_at: nil, created_from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]
           +[#<Referential:0x007fd30e897428
           +  id: 3,
           +  name: "Test 2",
           +  slug: "test_2",
           +  created_at: Wed, 17 Jan 2018 11:18:42 CET +01:00,
           +  updated_at: Wed, 17 Jan 2018 11:18:44 CET +01:00,
           +  prefix: "organisation_3",
           +  projection_type: nil,
           +  time_zone: "Europe/Paris",
           +  bounds: nil,
           +  organisation_id: 4,
           +  geographical_bounds: nil,
           +  user_id: nil,
           +  user_name: nil,
           +  data_format: "netex",
           +  line_referential_id: 4,
           +  stop_area_referential_id: 4,
           +  workbench_id: 2,
           +  archived_at: nil,
           +  created_from_id: nil,
           +  ready: true,
           +  referential_suite_id: nil,
           +  objectid_format: "stif_netex",
           +  merged_at: nil>]

         # ./spec/views/offer_workbenches/show.html.erb_spec.rb:37:in `block (2 levels) in <top (required)>'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `block in load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:240:in `load_dependency'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call'
         # -e:1:in `<main>'

      2) workbenches/show without permission should disable all the checkboxes
         Failure/Error: expect(workbench.all_referentials).to include different_organisation_referential

           expected #<ActiveRecord::AssociationRelation [#<Referential id: 7, name: "Test 6", slug: "test_6", created_at:...om_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]> to include #<Referential id: 9, name: "Test 8", slug: "test_8", created_at: "2018-01-17 10:18:55", updated_at: "...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>
           Diff:
           @@ -1,2 +1,25 @@
           -[#<Referential id: 9, name: "Test 8", slug: "test_8", created_at: "2018-01-17 10:18:55", updated_at: "2018-01-17 10:18:57", prefix: "organisation_11", projection_type: nil, time_zone: "Europe/Paris", bounds: nil, organisation_id: 12, geographical_bounds: nil, user_id: nil, user_name: nil, data_format: "netex", line_referential_id: 26, stop_area_referential_id: 18, workbench_id: 5, archived_at: nil, created_from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]
           +[#<Referential:0x007fd30eadc210
           +  id: 7,
           +  name: "Test 6",
           +  slug: "test_6",
           +  created_at: Wed, 17 Jan 2018 11:18:52 CET +01:00,
           +  updated_at: Wed, 17 Jan 2018 11:18:53 CET +01:00,
           +  prefix: "organisation_9",
           +  projection_type: nil,
           +  time_zone: "Europe/Paris",
           +  bounds: nil,
           +  organisation_id: 10,
           +  geographical_bounds: nil,
           +  user_id: nil,
           +  user_name: nil,
           +  data_format: "netex",
           +  line_referential_id: 16,
           +  stop_area_referential_id: 12,
           +  workbench_id: 4,
           +  archived_at: nil,
           +  created_from_id: nil,
           +  ready: true,
           +  referential_suite_id: nil,
           +  objectid_format: "stif_netex",
           +  merged_at: nil>]

         # ./spec/views/offer_workbenches/show.html.erb_spec.rb:37:in `block (2 levels) in <top (required)>'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `block in load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:240:in `load_dependency'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call'
         # -e:1:in `<main>'

      3) workbenches/show with permission referentials.destroy  should enable the checkbox for the referential which belongs to the same organisation and disable the other one
         Failure/Error: expect(workbench.all_referentials).to include different_organisation_referential

           expected #<ActiveRecord::AssociationRelation [#<Referential id: 11, name: "Test 10", slug: "test_10", created_...om_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]> to include #<Referential id: 13, name: "Test 12", slug: "test_12", created_at: "2018-01-17 10:19:03", updated_at...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>
           Diff:
           @@ -1,2 +1,25 @@
           -[#<Referential id: 13, name: "Test 12", slug: "test_12", created_at: "2018-01-17 10:19:03", updated_at: "2018-01-17 10:19:05", prefix: "organisation_17", projection_type: nil, time_zone: "Europe/Paris", bounds: nil, organisation_id: 18, geographical_bounds: nil, user_id: nil, user_name: nil, data_format: "netex", line_referential_id: 38, stop_area_referential_id: 26, workbench_id: 7, archived_at: nil, created_from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]
           +[#<Referential:0x007fd309268e30
           +  id: 11,
           +  name: "Test 10",
           +  slug: "test_10",
           +  created_at: Wed, 17 Jan 2018 11:19:00 CET +01:00,
           +  updated_at: Wed, 17 Jan 2018 11:19:02 CET +01:00,
           +  prefix: "organisation_15",
           +  projection_type: nil,
           +  time_zone: "Europe/Paris",
           +  bounds: nil,
           +  organisation_id: 16,
           +  geographical_bounds: nil,
           +  user_id: nil,
           +  user_name: nil,
           +  data_format: "netex",
           +  line_referential_id: 28,
           +  stop_area_referential_id: 20,
           +  workbench_id: 6,
           +  archived_at: nil,
           +  created_from_id: nil,
           +  ready: true,
           +  referential_suite_id: nil,
           +  objectid_format: "stif_netex",
           +  merged_at: nil>]

         # ./spec/views/offer_workbenches/show.html.erb_spec.rb:37:in `block (2 levels) in <top (required)>'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `block in load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:240:in `load_dependency'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call'
         # -e:1:in `<main>'

    Finished in 29.81 seconds (files took 1.7 seconds to load)
    3 examples, 3 failures

The new behaviour requires referentials to have the same workgroup in
order to be displayed on this page. Modify the test to give both
`same_organisation_referential` and `different_organisation_referential`
the same workgroup to get the tests to pass.

Refs #5592





I was getting the following test failures after having modified
`Workbench#all_referentials` in
93b60066cc49d699171d6a50798c5939a4644eea:

    Failures:

      1) workbenches/show should include #<Referential id: 5, name: "Test 4", slug: "test_4", created_at: "2018-01-17 10:18:47", updated_at: "...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>
         Failure/Error: expect(workbench.all_referentials).to include different_organisation_referential

           expected #<ActiveRecord::AssociationRelation [#<Referential id: 3, name: "Test 2", slug: "test_2", created_at:...om_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]> to include #<Referential id: 5, name: "Test 4", slug: "test_4", created_at: "2018-01-17 10:18:47", updated_at: "...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>
           Diff:
           @@ -1,2 +1,25 @@
           -[#<Referential id: 5, name: "Test 4", slug: "test_4", created_at: "2018-01-17 10:18:47", updated_at: "2018-01-17 10:18:49", prefix: "organisation_5", projection_type: nil, time_zone: "Europe/Paris", bounds: nil, organisation_id: 6, geographical_bounds: nil, user_id: nil, user_name: nil, data_format: "netex", line_referential_id: 14, stop_area_referential_id: 10, workbench_id: 3, archived_at: nil, created_from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]
           +[#<Referential:0x007fd30e897428
           +  id: 3,
           +  name: "Test 2",
           +  slug: "test_2",
           +  created_at: Wed, 17 Jan 2018 11:18:42 CET +01:00,
           +  updated_at: Wed, 17 Jan 2018 11:18:44 CET +01:00,
           +  prefix: "organisation_3",
           +  projection_type: nil,
           +  time_zone: "Europe/Paris",
           +  bounds: nil,
           +  organisation_id: 4,
           +  geographical_bounds: nil,
           +  user_id: nil,
           +  user_name: nil,
           +  data_format: "netex",
           +  line_referential_id: 4,
           +  stop_area_referential_id: 4,
           +  workbench_id: 2,
           +  archived_at: nil,
           +  created_from_id: nil,
           +  ready: true,
           +  referential_suite_id: nil,
           +  objectid_format: "stif_netex",
           +  merged_at: nil>]

         # ./spec/views/offer_workbenches/show.html.erb_spec.rb:37:in `block (2 levels) in <top (required)>'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `block in load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:240:in `load_dependency'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call'
         # -e:1:in `<main>'

      2) workbenches/show without permission should disable all the checkboxes
         Failure/Error: expect(workbench.all_referentials).to include different_organisation_referential

           expected #<ActiveRecord::AssociationRelation [#<Referential id: 7, name: "Test 6", slug: "test_6", created_at:...om_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]> to include #<Referential id: 9, name: "Test 8", slug: "test_8", created_at: "2018-01-17 10:18:55", updated_at: "...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>
           Diff:
           @@ -1,2 +1,25 @@
           -[#<Referential id: 9, name: "Test 8", slug: "test_8", created_at: "2018-01-17 10:18:55", updated_at: "2018-01-17 10:18:57", prefix: "organisation_11", projection_type: nil, time_zone: "Europe/Paris", bounds: nil, organisation_id: 12, geographical_bounds: nil, user_id: nil, user_name: nil, data_format: "netex", line_referential_id: 26, stop_area_referential_id: 18, workbench_id: 5, archived_at: nil, created_from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]
           +[#<Referential:0x007fd30eadc210
           +  id: 7,
           +  name: "Test 6",
           +  slug: "test_6",
           +  created_at: Wed, 17 Jan 2018 11:18:52 CET +01:00,
           +  updated_at: Wed, 17 Jan 2018 11:18:53 CET +01:00,
           +  prefix: "organisation_9",
           +  projection_type: nil,
           +  time_zone: "Europe/Paris",
           +  bounds: nil,
           +  organisation_id: 10,
           +  geographical_bounds: nil,
           +  user_id: nil,
           +  user_name: nil,
           +  data_format: "netex",
           +  line_referential_id: 16,
           +  stop_area_referential_id: 12,
           +  workbench_id: 4,
           +  archived_at: nil,
           +  created_from_id: nil,
           +  ready: true,
           +  referential_suite_id: nil,
           +  objectid_format: "stif_netex",
           +  merged_at: nil>]

         # ./spec/views/offer_workbenches/show.html.erb_spec.rb:37:in `block (2 levels) in <top (required)>'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `block in load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:240:in `load_dependency'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call'
         # -e:1:in `<main>'

      3) workbenches/show with permission referentials.destroy  should enable the checkbox for the referential which belongs to the same organisation and disable the other one
         Failure/Error: expect(workbench.all_referentials).to include different_organisation_referential

           expected #<ActiveRecord::AssociationRelation [#<Referential id: 11, name: "Test 10", slug: "test_10", created_...om_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]> to include #<Referential id: 13, name: "Test 12", slug: "test_12", created_at: "2018-01-17 10:19:03", updated_at...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>
           Diff:
           @@ -1,2 +1,25 @@
           -[#<Referential id: 13, name: "Test 12", slug: "test_12", created_at: "2018-01-17 10:19:03", updated_at: "2018-01-17 10:19:05", prefix: "organisation_17", projection_type: nil, time_zone: "Europe/Paris", bounds: nil, organisation_id: 18, geographical_bounds: nil, user_id: nil, user_name: nil, data_format: "netex", line_referential_id: 38, stop_area_referential_id: 26, workbench_id: 7, archived_at: nil, created_from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]
           +[#<Referential:0x007fd309268e30
           +  id: 11,
           +  name: "Test 10",
           +  slug: "test_10",
           +  created_at: Wed, 17 Jan 2018 11:19:00 CET +01:00,
           +  updated_at: Wed, 17 Jan 2018 11:19:02 CET +01:00,
           +  prefix: "organisation_15",
           +  projection_type: nil,
           +  time_zone: "Europe/Paris",
           +  bounds: nil,
           +  organisation_id: 16,
           +  geographical_bounds: nil,
           +  user_id: nil,
           +  user_name: nil,
           +  data_format: "netex",
           +  line_referential_id: 28,
           +  stop_area_referential_id: 20,
           +  workbench_id: 6,
           +  archived_at: nil,
           +  created_from_id: nil,
           +  ready: true,
           +  referential_suite_id: nil,
           +  objectid_format: "stif_netex",
           +  merged_at: nil>]

         # ./spec/views/offer_workbenches/show.html.erb_spec.rb:37:in `block (2 levels) in <top (required)>'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `block in load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:240:in `load_dependency'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call'
         # -e:1:in `<main>'

    Finished in 29.81 seconds (files took 1.7 seconds to load)
    3 examples, 3 failures

The new behaviour requires referentials to have the same workgroup in
order to be displayed on this page. Modify the test to give both
`same_organisation_referential` and `different_organisation_referential`
the same workgroup to get the tests to pass.

Refs #5592







workbenches/show: Filter referentials by workgroup
2018-01-16T16:24:12+00:00

Teddy Wing

2018-01-16T16:24:12+00:00

93b60066cc49d699171d6a50798c5939a4644eea

Previously, all `Referential`s would be listed on this page if they had
matching line metadata. Now, we exclude those referentials that are in
other workgroups to ensure users don't see referentials they're not
supposed to see.

Refs #5592





Previously, all `Referential`s would be listed on this page if they had
matching line metadata. Now, we exclude those referentials that are in
other workgroups to ensure users don't see referentials they're not
supposed to see.

Refs #5592







workbenches_show_spec: Test organisations in filtration list
2018-01-15T17:25:52+00:00

Teddy Wing

2018-01-15T16:36:58+00:00

88b1e7c640d89d5bb435e4e415105b071ef0d457

Check that only `Organisation`s associated with the current `Workgroup`
appear in the list of filters on `Workbenches#show`.

Also rewrite the `other_referential` object to put it in a different
workbench from the first referential, enabling us to have multiple
organisations in the same `Workgroup`.

Refs #5140





Check that only `Organisation`s associated with the current `Workgroup`
appear in the list of filters on `Workbenches#show`.

Also rewrite the `other_referential` object to put it in a different
workbench from the first referential, enabling us to have multiple
organisations in the same `Workgroup`.

Refs #5140







Merge pull request #236 from af83/5560-add-validation-on-customfields
2018-01-12T15:08:08+00:00

Luc Donnet

2018-01-12T15:08:08+00:00

d1626e2acf3dd14f240118a5c5f7dadbf0b6837e

5560 Add validation on CustomField




5560 Add validation on CustomField