chouette-core/spec, branch 0000-specs-easy-zip-setup Chouette manage transport static data Refs: #5006@2h; Zip Support for specs 2017-11-22T15:14:47+00:00 Robert 2017-11-22T15:14:47+00:00 caca3804a508481601d327ac3cd7f3f8b88e2680 






NetexImport: Don't destroy non-existent Referentials
2017-11-17T16:05:57+00:00

Teddy Wing

2017-11-17T16:05:57+00:00

fbb667fd728aea64f58b6f4e68e180afa169cb2b

Luc discovered this error in my method that destroys associated
non-ready `Referential`s:

    > WorkbenchImport.destroy_all
      WorkbenchImport Load (3.0ms)  SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."type" IN ('WorkbenchImport')
       (1.5ms)  BEGIN
      ImportMessage Load (2.7ms)  SELECT "public"."import_messages".* FROM "public"."import_messages" WHERE "public"."import_messages"."import_id" = $1  [["import_id", 58]]
      ImportResource Load (1.9ms)  SELECT "public"."import_resources".* FROM "public"."import_resources" WHERE "public"."import_resources"."import_id" = $1  [["import_id", 58]]
      Import Load (0.3ms)  SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."parent_id" = $1  [["parent_id", 58]]
      ImportMessage Load (0.5ms)  SELECT "public"."import_messages".* FROM "public"."import_messages" WHERE "public"."import_messages"."import_id" = $1  [["import_id", 59]]
      ImportResource Load (4.8ms)  SELECT "public"."import_resources".* FROM "public"."import_resources" WHERE "public"."import_resources"."import_id" = $1  [["import_id", 59]]
      SQL (1.3ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 636]]
      SQL (0.3ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 635]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 634]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 633]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 632]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 631]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 630]]
      SQL (0.1ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 629]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 628]]
      SQL (0.1ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 627]]
      SQL (0.1ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 626]]
      SQL (0.3ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 625]]
      SQL (0.3ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 624]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 623]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 622]]
      Import Load (0.3ms)  SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."parent_id" = $1  [["parent_id", 59]]
      Referential Load (0.6ms)  SELECT  "public"."referentials".* FROM "public"."referentials" WHERE "public"."referentials"."id" = $1 LIMIT 1  [["id", 18]]
       (0.2ms)  ROLLBACK
    NoMethodError: undefined method `ready' for nil:NilClass
    from .../stif-boiv/app/models/netex_import.rb:20:in `destroy_non_ready_referential'

Since `referential` is not a required attribute, it can be nil. That was
causing this to break because I tried to destroy a `Referential` that
doesn't exist. Check that there's an associated `Referential` before
trying to destroy it.

Refs #4991





Luc discovered this error in my method that destroys associated
non-ready `Referential`s:

    > WorkbenchImport.destroy_all
      WorkbenchImport Load (3.0ms)  SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."type" IN ('WorkbenchImport')
       (1.5ms)  BEGIN
      ImportMessage Load (2.7ms)  SELECT "public"."import_messages".* FROM "public"."import_messages" WHERE "public"."import_messages"."import_id" = $1  [["import_id", 58]]
      ImportResource Load (1.9ms)  SELECT "public"."import_resources".* FROM "public"."import_resources" WHERE "public"."import_resources"."import_id" = $1  [["import_id", 58]]
      Import Load (0.3ms)  SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."parent_id" = $1  [["parent_id", 58]]
      ImportMessage Load (0.5ms)  SELECT "public"."import_messages".* FROM "public"."import_messages" WHERE "public"."import_messages"."import_id" = $1  [["import_id", 59]]
      ImportResource Load (4.8ms)  SELECT "public"."import_resources".* FROM "public"."import_resources" WHERE "public"."import_resources"."import_id" = $1  [["import_id", 59]]
      SQL (1.3ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 636]]
      SQL (0.3ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 635]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 634]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 633]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 632]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 631]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 630]]
      SQL (0.1ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 629]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 628]]
      SQL (0.1ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 627]]
      SQL (0.1ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 626]]
      SQL (0.3ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 625]]
      SQL (0.3ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 624]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 623]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 622]]
      Import Load (0.3ms)  SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."parent_id" = $1  [["parent_id", 59]]
      Referential Load (0.6ms)  SELECT  "public"."referentials".* FROM "public"."referentials" WHERE "public"."referentials"."id" = $1 LIMIT 1  [["id", 18]]
       (0.2ms)  ROLLBACK
    NoMethodError: undefined method `ready' for nil:NilClass
    from .../stif-boiv/app/models/netex_import.rb:20:in `destroy_non_ready_referential'

Since `referential` is not a required attribute, it can be nil. That was
causing this to break because I tried to destroy a `Referential` that
doesn't exist. Check that there's an associated `Referential` before
trying to destroy it.

Refs #4991







Merge pull request #113 from af83/4823-compliance_check_show
2017-11-17T15:15:25+00:00

teddywing

2017-11-17T15:15:25+00:00

0d80f302bbf90334671b954b6788d581d5c852cb

4823 compliance check show




4823 compliance check show






Refs: #4823@0.2h; Code Review Part II
2017-11-17T13:57:36+00:00

Robert

2017-11-16T06:55:12+00:00

d8c0303c4f00998c546e9d3d06c0b13ed89b0391












Fixes: #4823@0.5h; Fixed regression in Ransack button "Effacer" implicit path does not work anymore
2017-11-17T13:57:36+00:00

Robert

2017-11-14T08:20:10+00:00

c0fa9f7de85fe32e95c7a923bb791525e0674c5d












Refs: #4823@2h; Chasing and fixing regressions in feature specs
2017-11-17T13:57:36+00:00

Robert

2017-11-13T18:09:33+00:00

83f193ee59af778a46f43fee8e9092c39c1390b8












Refs: #4823@0.5h; Translations changed
2017-11-17T13:57:36+00:00

Robert

2017-11-13T15:06:35+00:00

c656fe0c4bd1eeff0fb969819519034abeb84308












Refs: #4823@1.7h; CodeReview #show -> #executed
2017-11-17T13:57:36+00:00

Robert

2017-11-13T12:19:06+00:00

e4d75876d5bd9a4560133395f119abc05dc00b3d












Fixes #4823@1h;
2017-11-17T13:56:29+00:00

Robert

2017-11-10T06:41:07+00:00

5a1846208a2ef978c4582b91695be24ca5ee25cd

   - I18n.t explicit in helper so that it can be used in specs.
   - Typo in spec db setup fixed and setup of blocks put into create
     instead of later update.





   - I18n.t explicit in helper so that it can be used in specs.
   - Typo in spec db setup fixed and setup of blocks put into create
     instead of later update.







Refs: #4823@4h; Fixed Transport(Sub)mode validation bug
2017-11-17T13:56:29+00:00

Robert

2017-11-09T17:16:41+00:00

3fba11d14fb032802ea70240e4b204e93fe5a277