chouette-core/spec/views, branch 5765-customizable-importer Chouette manage transport static data Fixes vehicle_journeys#index spec 2018-02-06T19:10:19+00:00 Alban Peignier 2018-02-01T17:52:33+00:00 1e691dec5e86fcaf7982801ecfc32b67f560b27f 






Refs #5683 @2H; Fix specs and refactor action_links
2018-01-31T10:39:39+00:00

Zog

2018-01-31T10:39:39+00:00

fe7915ffac359db41c7737a3847f31a728f502e6

Note: Did not fix the missing workgroup in the calendar mailer





Note: Did not fix the missing workgroup in the calendar mailer







Fix infinity loop in spec/views/referentials/show.html.erb_spec.rb detected only in ruby 2.3.1
2018-01-30T12:55:33+00:00

Luc Donnet

2018-01-30T12:55:33+00:00

617a54cf63d7f11111b168534d49cdc04a5865d4












Refs #5586; Fix specs
2018-01-25T16:48:48+00:00

Zog

2018-01-25T16:48:48+00:00

734c03fdf3d6580da87107c474c5eeeda6a79ac4












Refs 5586; CR #1
2018-01-25T16:18:00+00:00

Zog

2018-01-21T10:59:33+00:00

e96174ac9c12c89b701307c50e7e1a2b09190316












Refs #5586 @1h; Ensure retrocompatibility
2018-01-25T16:17:59+00:00

Zog

2018-01-16T15:08:19+00:00

305c10faa98bcf157ca114293b634da32a16cc37

And remove snapshots (we don't need it anymore)





And remove snapshots (we don't need it anymore)







Refs #5586 @4h; First `action_links` refactor
2018-01-25T16:17:57+00:00

Zog

2018-01-15T09:34:30+00:00

8c9ce8f5c143d1e9d3f2c038e447a01ee59c91d3

- Implement new API
- Migrate the LineDecorator
- ensure no change on the "lines/index" view





- Implement new API
- Migrate the LineDecorator
- ensure no change on the "lines/index" view







offer_workbenches/show.html.erb_spec: Give workbenches same workgroup
2018-01-17T10:32:26+00:00

Teddy Wing

2018-01-17T10:32:26+00:00

9f3f7c5f71fee181f7f10a4a73d08fb1a0c1795b

I was getting the following test failures after having modified
`Workbench#all_referentials` in
93b60066cc49d699171d6a50798c5939a4644eea:

    Failures:

      1) workbenches/show should include #<Referential id: 5, name: "Test 4", slug: "test_4", created_at: "2018-01-17 10:18:47", updated_at: "...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>
         Failure/Error: expect(workbench.all_referentials).to include different_organisation_referential

           expected #<ActiveRecord::AssociationRelation [#<Referential id: 3, name: "Test 2", slug: "test_2", created_at:...om_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]> to include #<Referential id: 5, name: "Test 4", slug: "test_4", created_at: "2018-01-17 10:18:47", updated_at: "...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>
           Diff:
           @@ -1,2 +1,25 @@
           -[#<Referential id: 5, name: "Test 4", slug: "test_4", created_at: "2018-01-17 10:18:47", updated_at: "2018-01-17 10:18:49", prefix: "organisation_5", projection_type: nil, time_zone: "Europe/Paris", bounds: nil, organisation_id: 6, geographical_bounds: nil, user_id: nil, user_name: nil, data_format: "netex", line_referential_id: 14, stop_area_referential_id: 10, workbench_id: 3, archived_at: nil, created_from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]
           +[#<Referential:0x007fd30e897428
           +  id: 3,
           +  name: "Test 2",
           +  slug: "test_2",
           +  created_at: Wed, 17 Jan 2018 11:18:42 CET +01:00,
           +  updated_at: Wed, 17 Jan 2018 11:18:44 CET +01:00,
           +  prefix: "organisation_3",
           +  projection_type: nil,
           +  time_zone: "Europe/Paris",
           +  bounds: nil,
           +  organisation_id: 4,
           +  geographical_bounds: nil,
           +  user_id: nil,
           +  user_name: nil,
           +  data_format: "netex",
           +  line_referential_id: 4,
           +  stop_area_referential_id: 4,
           +  workbench_id: 2,
           +  archived_at: nil,
           +  created_from_id: nil,
           +  ready: true,
           +  referential_suite_id: nil,
           +  objectid_format: "stif_netex",
           +  merged_at: nil>]

         # ./spec/views/offer_workbenches/show.html.erb_spec.rb:37:in `block (2 levels) in <top (required)>'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `block in load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:240:in `load_dependency'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call'
         # -e:1:in `<main>'

      2) workbenches/show without permission should disable all the checkboxes
         Failure/Error: expect(workbench.all_referentials).to include different_organisation_referential

           expected #<ActiveRecord::AssociationRelation [#<Referential id: 7, name: "Test 6", slug: "test_6", created_at:...om_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]> to include #<Referential id: 9, name: "Test 8", slug: "test_8", created_at: "2018-01-17 10:18:55", updated_at: "...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>
           Diff:
           @@ -1,2 +1,25 @@
           -[#<Referential id: 9, name: "Test 8", slug: "test_8", created_at: "2018-01-17 10:18:55", updated_at: "2018-01-17 10:18:57", prefix: "organisation_11", projection_type: nil, time_zone: "Europe/Paris", bounds: nil, organisation_id: 12, geographical_bounds: nil, user_id: nil, user_name: nil, data_format: "netex", line_referential_id: 26, stop_area_referential_id: 18, workbench_id: 5, archived_at: nil, created_from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]
           +[#<Referential:0x007fd30eadc210
           +  id: 7,
           +  name: "Test 6",
           +  slug: "test_6",
           +  created_at: Wed, 17 Jan 2018 11:18:52 CET +01:00,
           +  updated_at: Wed, 17 Jan 2018 11:18:53 CET +01:00,
           +  prefix: "organisation_9",
           +  projection_type: nil,
           +  time_zone: "Europe/Paris",
           +  bounds: nil,
           +  organisation_id: 10,
           +  geographical_bounds: nil,
           +  user_id: nil,
           +  user_name: nil,
           +  data_format: "netex",
           +  line_referential_id: 16,
           +  stop_area_referential_id: 12,
           +  workbench_id: 4,
           +  archived_at: nil,
           +  created_from_id: nil,
           +  ready: true,
           +  referential_suite_id: nil,
           +  objectid_format: "stif_netex",
           +  merged_at: nil>]

         # ./spec/views/offer_workbenches/show.html.erb_spec.rb:37:in `block (2 levels) in <top (required)>'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `block in load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:240:in `load_dependency'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call'
         # -e:1:in `<main>'

      3) workbenches/show with permission referentials.destroy  should enable the checkbox for the referential which belongs to the same organisation and disable the other one
         Failure/Error: expect(workbench.all_referentials).to include different_organisation_referential

           expected #<ActiveRecord::AssociationRelation [#<Referential id: 11, name: "Test 10", slug: "test_10", created_...om_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]> to include #<Referential id: 13, name: "Test 12", slug: "test_12", created_at: "2018-01-17 10:19:03", updated_at...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>
           Diff:
           @@ -1,2 +1,25 @@
           -[#<Referential id: 13, name: "Test 12", slug: "test_12", created_at: "2018-01-17 10:19:03", updated_at: "2018-01-17 10:19:05", prefix: "organisation_17", projection_type: nil, time_zone: "Europe/Paris", bounds: nil, organisation_id: 18, geographical_bounds: nil, user_id: nil, user_name: nil, data_format: "netex", line_referential_id: 38, stop_area_referential_id: 26, workbench_id: 7, archived_at: nil, created_from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]
           +[#<Referential:0x007fd309268e30
           +  id: 11,
           +  name: "Test 10",
           +  slug: "test_10",
           +  created_at: Wed, 17 Jan 2018 11:19:00 CET +01:00,
           +  updated_at: Wed, 17 Jan 2018 11:19:02 CET +01:00,
           +  prefix: "organisation_15",
           +  projection_type: nil,
           +  time_zone: "Europe/Paris",
           +  bounds: nil,
           +  organisation_id: 16,
           +  geographical_bounds: nil,
           +  user_id: nil,
           +  user_name: nil,
           +  data_format: "netex",
           +  line_referential_id: 28,
           +  stop_area_referential_id: 20,
           +  workbench_id: 6,
           +  archived_at: nil,
           +  created_from_id: nil,
           +  ready: true,
           +  referential_suite_id: nil,
           +  objectid_format: "stif_netex",
           +  merged_at: nil>]

         # ./spec/views/offer_workbenches/show.html.erb_spec.rb:37:in `block (2 levels) in <top (required)>'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `block in load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:240:in `load_dependency'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call'
         # -e:1:in `<main>'

    Finished in 29.81 seconds (files took 1.7 seconds to load)
    3 examples, 3 failures

The new behaviour requires referentials to have the same workgroup in
order to be displayed on this page. Modify the test to give both
`same_organisation_referential` and `different_organisation_referential`
the same workgroup to get the tests to pass.

Refs #5592





I was getting the following test failures after having modified
`Workbench#all_referentials` in
93b60066cc49d699171d6a50798c5939a4644eea:

    Failures:

      1) workbenches/show should include #<Referential id: 5, name: "Test 4", slug: "test_4", created_at: "2018-01-17 10:18:47", updated_at: "...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>
         Failure/Error: expect(workbench.all_referentials).to include different_organisation_referential

           expected #<ActiveRecord::AssociationRelation [#<Referential id: 3, name: "Test 2", slug: "test_2", created_at:...om_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]> to include #<Referential id: 5, name: "Test 4", slug: "test_4", created_at: "2018-01-17 10:18:47", updated_at: "...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>
           Diff:
           @@ -1,2 +1,25 @@
           -[#<Referential id: 5, name: "Test 4", slug: "test_4", created_at: "2018-01-17 10:18:47", updated_at: "2018-01-17 10:18:49", prefix: "organisation_5", projection_type: nil, time_zone: "Europe/Paris", bounds: nil, organisation_id: 6, geographical_bounds: nil, user_id: nil, user_name: nil, data_format: "netex", line_referential_id: 14, stop_area_referential_id: 10, workbench_id: 3, archived_at: nil, created_from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]
           +[#<Referential:0x007fd30e897428
           +  id: 3,
           +  name: "Test 2",
           +  slug: "test_2",
           +  created_at: Wed, 17 Jan 2018 11:18:42 CET +01:00,
           +  updated_at: Wed, 17 Jan 2018 11:18:44 CET +01:00,
           +  prefix: "organisation_3",
           +  projection_type: nil,
           +  time_zone: "Europe/Paris",
           +  bounds: nil,
           +  organisation_id: 4,
           +  geographical_bounds: nil,
           +  user_id: nil,
           +  user_name: nil,
           +  data_format: "netex",
           +  line_referential_id: 4,
           +  stop_area_referential_id: 4,
           +  workbench_id: 2,
           +  archived_at: nil,
           +  created_from_id: nil,
           +  ready: true,
           +  referential_suite_id: nil,
           +  objectid_format: "stif_netex",
           +  merged_at: nil>]

         # ./spec/views/offer_workbenches/show.html.erb_spec.rb:37:in `block (2 levels) in <top (required)>'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `block in load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:240:in `load_dependency'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call'
         # -e:1:in `<main>'

      2) workbenches/show without permission should disable all the checkboxes
         Failure/Error: expect(workbench.all_referentials).to include different_organisation_referential

           expected #<ActiveRecord::AssociationRelation [#<Referential id: 7, name: "Test 6", slug: "test_6", created_at:...om_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]> to include #<Referential id: 9, name: "Test 8", slug: "test_8", created_at: "2018-01-17 10:18:55", updated_at: "...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>
           Diff:
           @@ -1,2 +1,25 @@
           -[#<Referential id: 9, name: "Test 8", slug: "test_8", created_at: "2018-01-17 10:18:55", updated_at: "2018-01-17 10:18:57", prefix: "organisation_11", projection_type: nil, time_zone: "Europe/Paris", bounds: nil, organisation_id: 12, geographical_bounds: nil, user_id: nil, user_name: nil, data_format: "netex", line_referential_id: 26, stop_area_referential_id: 18, workbench_id: 5, archived_at: nil, created_from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]
           +[#<Referential:0x007fd30eadc210
           +  id: 7,
           +  name: "Test 6",
           +  slug: "test_6",
           +  created_at: Wed, 17 Jan 2018 11:18:52 CET +01:00,
           +  updated_at: Wed, 17 Jan 2018 11:18:53 CET +01:00,
           +  prefix: "organisation_9",
           +  projection_type: nil,
           +  time_zone: "Europe/Paris",
           +  bounds: nil,
           +  organisation_id: 10,
           +  geographical_bounds: nil,
           +  user_id: nil,
           +  user_name: nil,
           +  data_format: "netex",
           +  line_referential_id: 16,
           +  stop_area_referential_id: 12,
           +  workbench_id: 4,
           +  archived_at: nil,
           +  created_from_id: nil,
           +  ready: true,
           +  referential_suite_id: nil,
           +  objectid_format: "stif_netex",
           +  merged_at: nil>]

         # ./spec/views/offer_workbenches/show.html.erb_spec.rb:37:in `block (2 levels) in <top (required)>'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `block in load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:240:in `load_dependency'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call'
         # -e:1:in `<main>'

      3) workbenches/show with permission referentials.destroy  should enable the checkbox for the referential which belongs to the same organisation and disable the other one
         Failure/Error: expect(workbench.all_referentials).to include different_organisation_referential

           expected #<ActiveRecord::AssociationRelation [#<Referential id: 11, name: "Test 10", slug: "test_10", created_...om_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]> to include #<Referential id: 13, name: "Test 12", slug: "test_12", created_at: "2018-01-17 10:19:03", updated_at...from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>
           Diff:
           @@ -1,2 +1,25 @@
           -[#<Referential id: 13, name: "Test 12", slug: "test_12", created_at: "2018-01-17 10:19:03", updated_at: "2018-01-17 10:19:05", prefix: "organisation_17", projection_type: nil, time_zone: "Europe/Paris", bounds: nil, organisation_id: 18, geographical_bounds: nil, user_id: nil, user_name: nil, data_format: "netex", line_referential_id: 38, stop_area_referential_id: 26, workbench_id: 7, archived_at: nil, created_from_id: nil, ready: true, referential_suite_id: nil, objectid_format: "stif_netex", merged_at: nil>]
           +[#<Referential:0x007fd309268e30
           +  id: 11,
           +  name: "Test 10",
           +  slug: "test_10",
           +  created_at: Wed, 17 Jan 2018 11:19:00 CET +01:00,
           +  updated_at: Wed, 17 Jan 2018 11:19:02 CET +01:00,
           +  prefix: "organisation_15",
           +  projection_type: nil,
           +  time_zone: "Europe/Paris",
           +  bounds: nil,
           +  organisation_id: 16,
           +  geographical_bounds: nil,
           +  user_id: nil,
           +  user_name: nil,
           +  data_format: "netex",
           +  line_referential_id: 28,
           +  stop_area_referential_id: 20,
           +  workbench_id: 6,
           +  archived_at: nil,
           +  created_from_id: nil,
           +  ready: true,
           +  referential_suite_id: nil,
           +  objectid_format: "stif_netex",
           +  merged_at: nil>]

         # ./spec/views/offer_workbenches/show.html.erb_spec.rb:37:in `block (2 levels) in <top (required)>'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `block in load'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:240:in `load_dependency'
         # .../.gem/ruby/2.3.3/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:268:in `load'
         # .../.gem/ruby/2.3.3/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call'
         # -e:1:in `<main>'

    Finished in 29.81 seconds (files took 1.7 seconds to load)
    3 examples, 3 failures

The new behaviour requires referentials to have the same workgroup in
order to be displayed on this page. Modify the test to give both
`same_organisation_referential` and `different_organisation_referential`
the same workgroup to get the tests to pass.

Refs #5592







Fix import messages style Refs #4473 @2
2018-01-03T15:21:22+00:00

Luc Donnet

2018-01-03T15:21:22+00:00

c29270e53191723dafd12461a3bb4c054c1602fd












Fixes selectors in imports#show specs. Refs #4473
2017-12-29T16:04:24+00:00

Alban Peignier

2017-12-29T16:04:24+00:00

80ccf3a771a26e9770fb0a5f698647b8ef30f724