chouette-core/spec/views, branch 3521-workbench_output_controller Chouette manage transport static data Remove rule parameter set controller, views, helper 2017-11-14T11:12:41+00:00 Xinhui 2017-11-14T10:33:31+00:00 cf1f0e3d236ec31a290918d10446d66b39826a56 Refs #4516 
Refs #4516
Fix specs for new tranport mode list 2017-10-02T12:23:52+00:00 cedricnjanga 2017-10-02T12:23:52+00:00 1fb361253d8f7bf50749ece699f2a3e5131291a3 






stop_areas/show.html.erb_spec.rb: Decorate stop area
2017-07-12T10:01:04+00:00

Teddy Wing

2017-07-12T10:01:04+00:00

7ea4ab54b53e9d14bf4562df24ed341fbe297f9e

In order to get the `#action_links` method to be found by the new table
builder, decorate the stop area.

Refs #3479





In order to get the `#action_links` method to be found by the new table
builder, decorate the stop area.

Refs #3479







routes/show.html.erb_spec.rb: Update for new table builder helper
2017-07-12T09:50:08+00:00

Teddy Wing

2017-07-12T09:50:08+00:00

25e0a8c896d2562a91f3fcea8e5f6ffba972f149

Need to decorate the stop points collection in order to be able to call
`#action_links` on the objects therein.

Added a stub for `pundit_user` to get around
`TableBuilderHelper#table_builder_2` having a dependency on
`ApplicationController#pundit_user`. Don't like this stub at all. Should
be doing this in a better way.

Refs #3479





Need to decorate the stop points collection in order to be able to call
`#action_links` on the objects therein.

Added a stub for `pundit_user` to get around
`TableBuilderHelper#table_builder_2` having a dependency on
`ApplicationController#pundit_user`. Don't like this stub at all. Should
be doing this in a better way.

Refs #3479







networks/show.html.erb_spec.rb: Decorate test network
2017-07-12T09:32:46+00:00

Teddy Wing

2017-07-12T09:32:46+00:00

e49dab499770d36a24c554019225092059a8cfa2

In order to get the view to render correctly and not fail on the
`network.action_links` call, decorate the network used in these tests.

Refs #3479





In order to get the view to render correctly and not fail on the
`network.action_links` call, decorate the network used in these tests.

Refs #3479







coherent spec file; no require (as in .rspec) and explicit RSpec.describe
2017-07-11T11:58:37+00:00

Robert

2017-07-11T11:58:37+00:00

b0495eab1f12c94ffa3b0e97a7c9e7a7166e6edc












Refs #2646: fix route view test
2017-07-11T10:54:55+00:00

jpl

2017-07-11T10:54:46+00:00

c9bf8f63221699d4b7c97d5f3bd4cced917884d8












time_tables/show.html.erb_spec.rb: Fix specs from `TimeTableDecorator`
2017-06-19T16:43:16+00:00

Teddy Wing

2017-06-19T16:43:16+00:00

3343920fe8df5378f7bced238b03860e249ac1cf

Was getting these failures after switching the controller over to use a
decorated `@time_table`:

    Failures:

      1) /time_tables/show should render h2 with the time_table comment
         Failure/Error: - @time_table.action_links.each do |link|

         ActionView::Template::Error:
           undefined method `action_links' for #<Chouette::TimeTable:0x007fc8cefb8260>
         # ./app/views/time_tables/show.html.slim:13:in `block in _app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'
         # ./app/helpers/newapplication_helper.rb:246:in `block (2 levels) in pageheader'
         # ./app/helpers/newapplication_helper.rb:244:in `block in pageheader'
         # ./app/helpers/newapplication_helper.rb:243:in `pageheader'
         # ./app/views/time_tables/show.html.slim:4:in `_app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'
         # ./spec/views/time_tables/show.html.erb_spec.rb:15:in `block (2 levels) in <top (required)>'
         # -e:1:in `<main>'
         # ------------------
         # --- Caused by: ---
         # NoMethodError:
         #   undefined method `action_links' for #<Chouette::TimeTable:0x007fc8cefb8260>
         #   ./app/views/time_tables/show.html.slim:13:in `block in _app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'

      2) /time_tables/show should render a link to edit the time_table
         Failure/Error: - @time_table.action_links.each do |link|

         ActionView::Template::Error:
           undefined method `action_links' for #<Chouette::TimeTable:0x007fc8cb65b148>
         # ./app/views/time_tables/show.html.slim:13:in `block in _app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'
         # ./app/helpers/newapplication_helper.rb:246:in `block (2 levels) in pageheader'
         # ./app/helpers/newapplication_helper.rb:244:in `block in pageheader'
         # ./app/helpers/newapplication_helper.rb:243:in `pageheader'
         # ./app/views/time_tables/show.html.slim:4:in `_app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'
         # ./spec/views/time_tables/show.html.erb_spec.rb:20:in `block (2 levels) in <top (required)>'
         # -e:1:in `<main>'
         # ------------------
         # --- Caused by: ---
         # NoMethodError:
         #   undefined method `action_links' for #<Chouette::TimeTable:0x007fc8cb65b148>
         #   ./app/views/time_tables/show.html.slim:13:in `block in _app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'

      3) /time_tables/show should render a link to remove the time_table
         Failure/Error: - @time_table.action_links.each do |link|

         ActionView::Template::Error:
           undefined method `action_links' for #<Chouette::TimeTable:0x007fc8cd251820>
         # ./app/views/time_tables/show.html.slim:13:in `block in _app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'
         # ./app/helpers/newapplication_helper.rb:246:in `block (2 levels) in pageheader'
         # ./app/helpers/newapplication_helper.rb:244:in `block in pageheader'
         # ./app/helpers/newapplication_helper.rb:243:in `pageheader'
         # ./app/views/time_tables/show.html.slim:4:in `_app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'
         # ./spec/views/time_tables/show.html.erb_spec.rb:25:in `block (2 levels) in <top (required)>'
         # -e:1:in `<main>'
         # ------------------
         # --- Caused by: ---
         # NoMethodError:
         #   undefined method `action_links' for #<Chouette::TimeTable:0x007fc8cd251820>
         #   ./app/views/time_tables/show.html.slim:13:in `block in _app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'

    Finished in 2.44 seconds (files took 0.82818 seconds to load)
    3 examples, 3 failures

    Failed examples:

    rspec ./spec/views/time_tables/show.html.erb_spec.rb:14 # /time_tables/show should render h2 with the time_table comment
    rspec ./spec/views/time_tables/show.html.erb_spec.rb:19 # /time_tables/show should render a link to edit the time_table
    rspec ./spec/views/time_tables/show.html.erb_spec.rb:24 # /time_tables/show should render a link to remove the time_table

To match the controller, we need to decorate the `time_table` objects
used in these tests as well, because the view code has changed.
Decoration is necessary to give us the `#action_links` method that we
use to render the header links on the page.

Refs #3479





Was getting these failures after switching the controller over to use a
decorated `@time_table`:

    Failures:

      1) /time_tables/show should render h2 with the time_table comment
         Failure/Error: - @time_table.action_links.each do |link|

         ActionView::Template::Error:
           undefined method `action_links' for #<Chouette::TimeTable:0x007fc8cefb8260>
         # ./app/views/time_tables/show.html.slim:13:in `block in _app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'
         # ./app/helpers/newapplication_helper.rb:246:in `block (2 levels) in pageheader'
         # ./app/helpers/newapplication_helper.rb:244:in `block in pageheader'
         # ./app/helpers/newapplication_helper.rb:243:in `pageheader'
         # ./app/views/time_tables/show.html.slim:4:in `_app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'
         # ./spec/views/time_tables/show.html.erb_spec.rb:15:in `block (2 levels) in <top (required)>'
         # -e:1:in `<main>'
         # ------------------
         # --- Caused by: ---
         # NoMethodError:
         #   undefined method `action_links' for #<Chouette::TimeTable:0x007fc8cefb8260>
         #   ./app/views/time_tables/show.html.slim:13:in `block in _app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'

      2) /time_tables/show should render a link to edit the time_table
         Failure/Error: - @time_table.action_links.each do |link|

         ActionView::Template::Error:
           undefined method `action_links' for #<Chouette::TimeTable:0x007fc8cb65b148>
         # ./app/views/time_tables/show.html.slim:13:in `block in _app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'
         # ./app/helpers/newapplication_helper.rb:246:in `block (2 levels) in pageheader'
         # ./app/helpers/newapplication_helper.rb:244:in `block in pageheader'
         # ./app/helpers/newapplication_helper.rb:243:in `pageheader'
         # ./app/views/time_tables/show.html.slim:4:in `_app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'
         # ./spec/views/time_tables/show.html.erb_spec.rb:20:in `block (2 levels) in <top (required)>'
         # -e:1:in `<main>'
         # ------------------
         # --- Caused by: ---
         # NoMethodError:
         #   undefined method `action_links' for #<Chouette::TimeTable:0x007fc8cb65b148>
         #   ./app/views/time_tables/show.html.slim:13:in `block in _app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'

      3) /time_tables/show should render a link to remove the time_table
         Failure/Error: - @time_table.action_links.each do |link|

         ActionView::Template::Error:
           undefined method `action_links' for #<Chouette::TimeTable:0x007fc8cd251820>
         # ./app/views/time_tables/show.html.slim:13:in `block in _app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'
         # ./app/helpers/newapplication_helper.rb:246:in `block (2 levels) in pageheader'
         # ./app/helpers/newapplication_helper.rb:244:in `block in pageheader'
         # ./app/helpers/newapplication_helper.rb:243:in `pageheader'
         # ./app/views/time_tables/show.html.slim:4:in `_app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'
         # ./spec/views/time_tables/show.html.erb_spec.rb:25:in `block (2 levels) in <top (required)>'
         # -e:1:in `<main>'
         # ------------------
         # --- Caused by: ---
         # NoMethodError:
         #   undefined method `action_links' for #<Chouette::TimeTable:0x007fc8cd251820>
         #   ./app/views/time_tables/show.html.slim:13:in `block in _app_views_time_tables_show_html_slim__2702796193816469913_70250218141540'

    Finished in 2.44 seconds (files took 0.82818 seconds to load)
    3 examples, 3 failures

    Failed examples:

    rspec ./spec/views/time_tables/show.html.erb_spec.rb:14 # /time_tables/show should render h2 with the time_table comment
    rspec ./spec/views/time_tables/show.html.erb_spec.rb:19 # /time_tables/show should render a link to edit the time_table
    rspec ./spec/views/time_tables/show.html.erb_spec.rb:24 # /time_tables/show should render a link to remove the time_table

To match the controller, we need to decorate the `time_table` objects
used in these tests as well, because the view code has changed.
Decoration is necessary to give us the `#action_links` method that we
use to render the header links on the page.

Refs #3479







lines/show.html.erb_spec.rb: Fix specs resulting from `LineDecorator`
2017-06-19T16:40:09+00:00

Teddy Wing

2017-06-19T16:35:26+00:00

140270297b1db064b78472ccd7e59b8279d21be7

The tests failed because we weren't using a decorated `Chouette::Line`
object, but the views now expect decorated lines in order to be able to
call the `#action_links` method.

Here are our failures:

    5) /lines/show should render h1 with the line name
       Failure/Error: - @line.action_links.each do |link|

       ActionView::Template::Error:
         undefined method `action_links' for #<Chouette::Line:0x007fc8cdf0bb88>
       # ./app/views/lines/show.html.slim:10:in `block in _app_views_lines_show_html_slim___3813514632397395671_70250211127360'
       # ./app/helpers/newapplication_helper.rb:246:in `block (2 levels) in pageheader'
       # ./app/helpers/newapplication_helper.rb:244:in `block in pageheader'
       # ./app/helpers/newapplication_helper.rb:243:in `pageheader'
       # ./app/views/lines/show.html.slim:2:in `_app_views_lines_show_html_slim___3813514632397395671_70250211127360'
       # ./spec/views/lines/show.html.erb_spec.rb:16:in `block (2 levels) in <top (required)>'
       # -e:1:in `<main>'
       # ------------------
       # --- Caused by: ---
       # NoMethodError:
       #   undefined method `action_links' for #<Chouette::Line:0x007fc8cdf0bb88>
       #   ./app/views/lines/show.html.slim:10:in `block in _app_views_lines_show_html_slim___3813514632397395671_70250211127360'

    6) /lines/show should render a link to remove the line
       Failure/Error: - @line.action_links.each do |link|

       ActionView::Template::Error:
         undefined method `action_links' for #<Chouette::Line:0x007fc8cfdaa710>
       # ./app/views/lines/show.html.slim:10:in `block in _app_views_lines_show_html_slim___3813514632397395671_70250211127360'
       # ./app/helpers/newapplication_helper.rb:246:in `block (2 levels) in pageheader'
       # ./app/helpers/newapplication_helper.rb:244:in `block in pageheader'
       # ./app/helpers/newapplication_helper.rb:243:in `pageheader'
       # ./app/views/lines/show.html.slim:2:in `_app_views_lines_show_html_slim___3813514632397395671_70250211127360'
       # ./spec/views/lines/show.html.erb_spec.rb:31:in `block (2 levels) in <top (required)>'
       # -e:1:in `<main>'
       # ------------------
       # --- Caused by: ---
       # NoMethodError:
       #   undefined method `action_links' for #<Chouette::Line:0x007fc8cfdaa710>
       #   ./app/views/lines/show.html.slim:10:in `block in _app_views_lines_show_html_slim___3813514632397395671_70250211127360'

Update the test to decorate the lines used in them.

Turn `current_organisation` into a `context` field on `LineDecorator`
because otherwise it's a global variable that comes from wherever that's
required in `LineDecorator`. And we'd have to mock
`current_organisation` on `line` in the test, which I wasn't keen on.

Refs #3479





The tests failed because we weren't using a decorated `Chouette::Line`
object, but the views now expect decorated lines in order to be able to
call the `#action_links` method.

Here are our failures:

    5) /lines/show should render h1 with the line name
       Failure/Error: - @line.action_links.each do |link|

       ActionView::Template::Error:
         undefined method `action_links' for #<Chouette::Line:0x007fc8cdf0bb88>
       # ./app/views/lines/show.html.slim:10:in `block in _app_views_lines_show_html_slim___3813514632397395671_70250211127360'
       # ./app/helpers/newapplication_helper.rb:246:in `block (2 levels) in pageheader'
       # ./app/helpers/newapplication_helper.rb:244:in `block in pageheader'
       # ./app/helpers/newapplication_helper.rb:243:in `pageheader'
       # ./app/views/lines/show.html.slim:2:in `_app_views_lines_show_html_slim___3813514632397395671_70250211127360'
       # ./spec/views/lines/show.html.erb_spec.rb:16:in `block (2 levels) in <top (required)>'
       # -e:1:in `<main>'
       # ------------------
       # --- Caused by: ---
       # NoMethodError:
       #   undefined method `action_links' for #<Chouette::Line:0x007fc8cdf0bb88>
       #   ./app/views/lines/show.html.slim:10:in `block in _app_views_lines_show_html_slim___3813514632397395671_70250211127360'

    6) /lines/show should render a link to remove the line
       Failure/Error: - @line.action_links.each do |link|

       ActionView::Template::Error:
         undefined method `action_links' for #<Chouette::Line:0x007fc8cfdaa710>
       # ./app/views/lines/show.html.slim:10:in `block in _app_views_lines_show_html_slim___3813514632397395671_70250211127360'
       # ./app/helpers/newapplication_helper.rb:246:in `block (2 levels) in pageheader'
       # ./app/helpers/newapplication_helper.rb:244:in `block in pageheader'
       # ./app/helpers/newapplication_helper.rb:243:in `pageheader'
       # ./app/views/lines/show.html.slim:2:in `_app_views_lines_show_html_slim___3813514632397395671_70250211127360'
       # ./spec/views/lines/show.html.erb_spec.rb:31:in `block (2 levels) in <top (required)>'
       # -e:1:in `<main>'
       # ------------------
       # --- Caused by: ---
       # NoMethodError:
       #   undefined method `action_links' for #<Chouette::Line:0x007fc8cfdaa710>
       #   ./app/views/lines/show.html.slim:10:in `block in _app_views_lines_show_html_slim___3813514632397395671_70250211127360'

Update the test to decorate the lines used in them.

Turn `current_organisation` into a `context` field on `LineDecorator`
because otherwise it's a global variable that comes from wherever that's
required in `LineDecorator`. And we'd have to mock
`current_organisation` on `line` in the test, which I wasn't keen on.

Refs #3479







Add auto assign of slug and prefix for referential#create
2017-06-16T10:21:15+00:00

Xinhui

2017-06-16T10:20:55+00:00

f862664da731aaa9c7377fc9afc054ba8a033867

Refs #3657





Refs #3657