chouette-core/spec/models, branch 3521-workbench_output_controller Chouette manage transport static data NetexImport: Don't destroy non-existent Referentials 2017-11-17T16:05:57+00:00 Teddy Wing 2017-11-17T16:05:57+00:00 fbb667fd728aea64f58b6f4e68e180afa169cb2b Luc discovered this error in my method that destroys associated non-ready `Referential`s: > WorkbenchImport.destroy_all WorkbenchImport Load (3.0ms) SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."type" IN ('WorkbenchImport') (1.5ms) BEGIN ImportMessage Load (2.7ms) SELECT "public"."import_messages".* FROM "public"."import_messages" WHERE "public"."import_messages"."import_id" = $1 [["import_id", 58]] ImportResource Load (1.9ms) SELECT "public"."import_resources".* FROM "public"."import_resources" WHERE "public"."import_resources"."import_id" = $1 [["import_id", 58]] Import Load (0.3ms) SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."parent_id" = $1 [["parent_id", 58]] ImportMessage Load (0.5ms) SELECT "public"."import_messages".* FROM "public"."import_messages" WHERE "public"."import_messages"."import_id" = $1 [["import_id", 59]] ImportResource Load (4.8ms) SELECT "public"."import_resources".* FROM "public"."import_resources" WHERE "public"."import_resources"."import_id" = $1 [["import_id", 59]] SQL (1.3ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 636]] SQL (0.3ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 635]] SQL (0.2ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 634]] SQL (0.2ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 633]] SQL (0.2ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 632]] SQL (0.2ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 631]] SQL (0.2ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 630]] SQL (0.1ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 629]] SQL (0.2ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 628]] SQL (0.1ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 627]] SQL (0.1ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 626]] SQL (0.3ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 625]] SQL (0.3ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 624]] SQL (0.2ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 623]] SQL (0.2ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 622]] Import Load (0.3ms) SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."parent_id" = $1 [["parent_id", 59]] Referential Load (0.6ms) SELECT "public"."referentials".* FROM "public"."referentials" WHERE "public"."referentials"."id" = $1 LIMIT 1 [["id", 18]] (0.2ms) ROLLBACK NoMethodError: undefined method `ready' for nil:NilClass from .../stif-boiv/app/models/netex_import.rb:20:in `destroy_non_ready_referential' Since `referential` is not a required attribute, it can be nil. That was causing this to break because I tried to destroy a `Referential` that doesn't exist. Check that there's an associated `Referential` before trying to destroy it. Refs #4991 
Luc discovered this error in my method that destroys associated
non-ready `Referential`s:

    > WorkbenchImport.destroy_all
      WorkbenchImport Load (3.0ms)  SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."type" IN ('WorkbenchImport')
       (1.5ms)  BEGIN
      ImportMessage Load (2.7ms)  SELECT "public"."import_messages".* FROM "public"."import_messages" WHERE "public"."import_messages"."import_id" = $1  [["import_id", 58]]
      ImportResource Load (1.9ms)  SELECT "public"."import_resources".* FROM "public"."import_resources" WHERE "public"."import_resources"."import_id" = $1  [["import_id", 58]]
      Import Load (0.3ms)  SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."parent_id" = $1  [["parent_id", 58]]
      ImportMessage Load (0.5ms)  SELECT "public"."import_messages".* FROM "public"."import_messages" WHERE "public"."import_messages"."import_id" = $1  [["import_id", 59]]
      ImportResource Load (4.8ms)  SELECT "public"."import_resources".* FROM "public"."import_resources" WHERE "public"."import_resources"."import_id" = $1  [["import_id", 59]]
      SQL (1.3ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 636]]
      SQL (0.3ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 635]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 634]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 633]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 632]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 631]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 630]]
      SQL (0.1ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 629]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 628]]
      SQL (0.1ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 627]]
      SQL (0.1ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 626]]
      SQL (0.3ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 625]]
      SQL (0.3ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 624]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 623]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 622]]
      Import Load (0.3ms)  SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."parent_id" = $1  [["parent_id", 59]]
      Referential Load (0.6ms)  SELECT  "public"."referentials".* FROM "public"."referentials" WHERE "public"."referentials"."id" = $1 LIMIT 1  [["id", 18]]
       (0.2ms)  ROLLBACK
    NoMethodError: undefined method `ready' for nil:NilClass
    from .../stif-boiv/app/models/netex_import.rb:20:in `destroy_non_ready_referential'

Since `referential` is not a required attribute, it can be nil. That was
causing this to break because I tried to destroy a `Referential` that
doesn't exist. Check that there's an associated `Referential` before
trying to destroy it.

Refs #4991
Merge pull request #113 from af83/4823-compliance_check_show 2017-11-17T15:15:25+00:00 teddywing 2017-11-17T15:15:25+00:00 0d80f302bbf90334671b954b6788d581d5c852cb 4823 compliance check show 
4823 compliance check show
 Refs: #4823@4h; Fixed Transport(Sub)mode validation bug 2017-11-17T13:56:29+00:00 Robert 2017-11-09T17:16:41+00:00 3fba11d14fb032802ea70240e4b204e93fe5a277 






Refs: #4283@16h;
2017-11-17T13:56:29+00:00

Robert

2017-11-06T18:06:57+00:00

76d11c7f973867e305d6841f69c62c5fd37d65a7

 - Implements the view

Missing:

 - Spex failing (xpath navigation inside the display blocks is still faulty)
 - Links to compliance_checks#show do not work (actually not this page's problem)





 - Implements the view

Missing:

 - Spex failing (xpath navigation inside the display blocks is still faulty)
 - Links to compliance_checks#show do not work (actually not this page's problem)







Refs: #4461@0.75h;  Fixing netex_import after_create callback to after_commit on: :create
2017-11-17T13:53:03+00:00

Robert

2017-11-17T10:32:47+00:00

86082170302a5b07dc15fbc61b628bb89b775f04












Refs: #4461@1h; CodeReview
2017-11-17T13:49:19+00:00

Robert

2017-11-16T15:03:06+00:00

1b84658f5f3ab98f7338a319ad1dc2f3ee8a1842

  - using webmock instead of mocking Net::HTTP
    therefore removing the connascence between the spec and the
    HTTP lib used in the implementation, thank you Teddy





  - using webmock instead of mocking Net::HTTP
    therefore removing the connascence between the spec and the
    HTTP lib used in the implementation, thank you Teddy







Fixes: #4461@2h; Specing and Implementing
2017-11-17T13:49:19+00:00

Robert

2017-11-15T16:15:24+00:00

2b925fe2bf8f33a0d10dfe1307b086d9e3f0add4












Refs: #4461@1.5h; Repaired netex_import factory, adapted spec/models/import_spec
2017-11-17T13:47:37+00:00

Robert

2017-11-15T14:23:27+00:00

21ddaefb9fc092463261284b0b7b493709201a3b












Merge branch '4516_cleanup_rule_parameter_set'
2017-11-17T11:09:42+00:00

Xinhui

2017-11-17T11:07:58+00:00

1261698d213964a3391fe1880198da00e7ac9831












Merge pull request #116 from af83/4962-when-WorkbenchImport-is-deleted-also-delete-associated-Referential-if-ready-false
2017-11-17T06:47:56+00:00

Luc Donnet

2017-11-17T06:47:56+00:00

f677c08029ccb3b910ab6a2401fa56ccacb2b4d9

4962 when workbench import is deleted also delete associated referential if ready false




4962 when workbench import is deleted also delete associated referential if ready false