chouette-core/spec/models/referential, branch 5505-custom_fields Chouette manage transport static data referential_lock_during_creation_spec: Skip truncation tests 2017-12-13T16:46:07+00:00 Teddy Wing 2017-12-13T16:33:05+00:00 a9557b7f042dd25c56d0af75d55fadb63e862a26 Just discussed this with Alban. The truncation tests are breaking the test suite, and I've spent way too long on this already. Take the specs out of the suite for now until we can come up with a different way to run these or test this behaviour without breaking everything. The new task to fix this is #5295. Refs #5024 
Just discussed this with Alban. The truncation tests are breaking the
test suite, and I've spent way too long on this already. Take the specs
out of the suite for now until we can come up with a different way to
run these or test this behaviour without breaking everything.

The new task to fix this is #5295.

Refs #5024
referential_lock_during_creation_spec: Make truncation strategy stick 2017-12-13T16:01:15+00:00 Teddy Wing 2017-12-13T16:01:15+00:00 bd8a999b12963b7303500ce93449bb7932afeec3 The `truncation: true` strategy wasn't sticking. The config `before` block only ran once for this test file. Instead of attaching the filter to the `it` blocks, put it on the `context`. This correctly gets each test to run in a transaction. Remove the `truncation: false` filter I had added previously as this didn't do what I wanted it to: it prevented the `before` block from running instead of filtering out tests with `truncation: true`. Refs #5024 
The `truncation: true` strategy wasn't sticking. The config `before`
block only ran once for this test file. Instead of attaching the filter
to the `it` blocks, put it on the `context`. This correctly gets each
test to run in a transaction.

Remove the `truncation: false` filter I had added previously as this
didn't do what I wanted it to: it prevented the `before` block from
running instead of filtering out tests with `truncation: true`.

Refs #5024
referential_lock_during_creation_spec: Extract method for threads 2017-12-13T14:16:03+00:00 Johan Van Ryseghem 2017-12-13T14:12:48+00:00 c21bcff5849190d87a2f2869a0f4714de118cb15 Refactor these tests to abstract the thread & transaction creation & handling. Thread creation and joining can now live in one place apart from the tests, and the tests have an interface to set up concurrent referential saving. Thanks to Johan for this refactor. Refs #5024 
Refactor these tests to abstract the thread & transaction creation &
handling. Thread creation and joining can now live in one place apart
from the tests, and the tests have an interface to set up concurrent
referential saving.

Thanks to Johan for this refactor.

Refs #5024
referential_lock_during_creation_spec: Don't create unnecessary Ref 2017-12-12T16:06:50+00:00 Teddy Wing 2017-12-12T16:06:50+00:00 83a0f74b02d9dc2b3e1eb6b3f7c7c068148f0856 The `referential_metadata` factory will create an associated referential by default. This causes errors in our tests because we haven't cleaned up the trailing referential. Refs #5024 
The `referential_metadata` factory will create an associated referential
by default. This causes errors in our tests because we haven't cleaned
up the trailing referential.

Refs #5024
Referential: Lock table on :update 2017-12-12T16:01:49+00:00 Teddy Wing 2017-12-12T16:01:49+00:00 df13a9b7b26b568b5edcea590a2e867d26580d22 We had been locking the `referentials` table on :create, but we also want to handle :update. Paired on this with Johan. When I used: referential_2.metadatas << metadata_2 the referential was saved. To add the metadata without automatically saving the referential + metadata, Johan suggested using the nested attribute method: referential_2.metadatas_attributes = [metadata_2.attributes] This allows us to add the metadata and still use the `#save` method to lock the table. Also change the callback from `before_validation` to `before_save` because before_validation :lock_table, on: [:create, :update] didn't work. That caused an error in our `expect`, as the `be_valid` triggered the lock callback. To enable the callback on both :create and :update, use a `before_save` instead. Refs #5024 
We had been locking the `referentials` table on :create, but we also
want to handle :update. Paired on this with Johan.

When I used:

    referential_2.metadatas << metadata_2

the referential was saved. To add the metadata without automatically
saving the referential + metadata, Johan suggested using the nested
attribute method:

    referential_2.metadatas_attributes = [metadata_2.attributes]

This allows us to add the metadata and still use the `#save` method to
lock the table.

Also change the callback from `before_validation` to `before_save`
because

    before_validation :lock_table, on: [:create, :update]

didn't work. That caused an error in our `expect`, as the `be_valid`
triggered the lock callback. To enable the callback on both :create and
:update, use a `before_save` instead.

Refs #5024
Referential: Raise an error if the table lock times out 2017-12-12T15:56:49+00:00 Teddy Wing 2017-12-12T15:56:49+00:00 55b995531b2504792dfa1b0314b5cc5b55a775ac Paired with Johan on this one. There's an internal timeout on our table lock. If it's reached, an `ActiveRecord::StatementInvalid<PG::LockNotAvailable>` error is raised. Use a custom error instead by "overriding" `#save` with a method that raises our custom error in that case instead. This will enable us to provide a custom user-facing error in the event this happens. Refs #5024 
Paired with Johan on this one. There's an internal timeout on our table
lock. If it's reached, an
`ActiveRecord::StatementInvalid<PG::LockNotAvailable>` error is raised.
Use a custom error instead by "overriding" `#save` with a method that
raises our custom error in that case instead. This will enable us to
provide a custom user-facing error in the event this happens.

Refs #5024
referential_lock spec: Don't create unnecessary referential 2017-12-06T14:01:02+00:00 Teddy Wing 2017-12-06T14:01:02+00:00 0ec72aa1ce6598f48943df33827a6d700ee15153 The factory for `referential_metadata` was creating an unnecessary `Referential` object since it has an association set up. This was causing the test to fail because that referential's schema wasn't getting cleaned in the `ensure` block. Don't create that referential to avoid the error. Refs #5024 
The factory for `referential_metadata` was creating an unnecessary
`Referential` object since it has an association set up. This was
causing the test to fail because that referential's schema wasn't
getting cleaned in the `ensure` block. Don't create that referential to
avoid the error.

Refs #5024
Merge remote-tracking branch 'origin/master' into 5024-prevent-duplicate-referentials-from-being-created-during-parallel-db-transactions--rb201711271659 2017-12-05T17:26:57+00:00 Teddy Wing 2017-12-05T17:26:57+00:00 47181fd81105396b2db394958c39a6e40bc6f0f0 Conflicts: app/models/referential.rb A whitespace conflict in a place I don't even remember editing? Okaay. 
Conflicts:
	app/models/referential.rb

A whitespace conflict in a place I don't even remember editing? Okaay.
Fixes: #5179@1h; Referential Creation Enforces objectid_format from associated Workbench 2017-12-05T14:52:44+00:00 Robert 2017-12-05T14:52:44+00:00 b50bcb8d6d0da921c002afb550a8aa4dffa3c2f0 - CR changes implemented 
  - CR changes implemented
Refs: #5179@1.25h; Referential Creation Enforces objectid_format from associated Workbench 2017-12-05T11:19:42+00:00 Robert 2017-12-05T10:37:25+00:00 642d2bd3a46a4b459acf18748dbfebf0cb6ca7df - changed ObjectIdFormatterSupport as requested - respeced all defined cases - implemented respec Missing: What to do in `define_default_attributes` if ref has no workbench and no `objectid_format`? 
  - changed ObjectIdFormatterSupport as requested
  - respeced all defined cases
  - implemented respec

Missing:
  What to do in `define_default_attributes` if ref has no workbench and no `objectid_format`?