<feed xmlns='http://www.w3.org/2005/Atom'>
<title>chouette-core/app, branch robert-bup</title>
<subtitle>Chouette manage transport static data</subtitle>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/chouette-core/'/>
<entry>
<title>Fixes: #4461@2h; Specing and Implementing</title>
<updated>2017-11-15T16:15:24+00:00</updated>
<author>
<name>Robert</name>
</author>
<published>2017-11-15T16:15:24+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/chouette-core/commit/?id=30c362f0371c081e0ddb9bc13c5873b1aecda1eb'/>
<id>30c362f0371c081e0ddb9bc13c5873b1aecda1eb</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Refs: #4461@1.5h; Repaired netex_import factory, adapted spec/models/import_spec</title>
<updated>2017-11-15T14:23:27+00:00</updated>
<author>
<name>Robert</name>
</author>
<published>2017-11-15T14:23:27+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/chouette-core/commit/?id=fff9c009c885a4ed99d50ccaa8c8d01c12f86f19'/>
<id>fff9c009c885a4ed99d50ccaa8c8d01c12f86f19</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Refs #4952 Add conidtion to display ComplianceControlBlock edit button depending on user permissions</title>
<updated>2017-11-13T17:01:39+00:00</updated>
<author>
<name>cedricnjanga</name>
</author>
<published>2017-11-13T17:01:11+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/chouette-core/commit/?id=96afaed78fa043449c0264ea09f0106147755c8e'/>
<id>96afaed78fa043449c0264ea09f0106147755c8e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>ComplianceCheckSet#update_status: Return `true` if no update happened</title>
<updated>2017-11-13T16:52:54+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2017-11-13T15:27:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/chouette-core/commit/?id=e57f45bd6478baeab25ae96ae688587dda85247f'/>
<id>e57f45bd6478baeab25ae96ae688587dda85247f</id>
<content type='text'>
Return `true` from this method by default. If the `#update` call fails,
then it will return `false`, but in all other cases, we should return
`true`. That way, when the
`Api::V1::ComplianceCheckSetsController#validated` endpoint is called,
it will respond with the `ComplianceCheckSet` object instead of:

    {"status":"error","messages":[]}

with no error messages.

Refs #4757
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Return `true` from this method by default. If the `#update` call fails,
then it will return `false`, but in all other cases, we should return
`true`. That way, when the
`Api::V1::ComplianceCheckSetsController#validated` endpoint is called,
it will respond with the `ComplianceCheckSet` object instead of:

    {"status":"error","messages":[]}

with no error messages.

Refs #4757
</pre>
</div>
</content>
</entry>
<entry>
<title>ComplianceCheckSet#update_status: Handle resources with "IGNORED" status</title>
<updated>2017-11-13T16:52:54+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2017-11-13T15:09:20+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/chouette-core/commit/?id=5dd6b2f963d3ae732c6f56112e5f5ac56b6c2764'/>
<id>5dd6b2f963d3ae732c6f56112e5f5ac56b6c2764</id>
<content type='text'>
If any associated resources have the "IGNORED" status, this shouldn't
affect the outcome of a "successful" status. Allow the
`ComplianceCheckSet` to be "successful" even if some `Resource`s are
"IGNORED".

Refs #4757
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If any associated resources have the "IGNORED" status, this shouldn't
affect the outcome of a "successful" status. Allow the
`ComplianceCheckSet` to be "successful" even if some `Resource`s are
"IGNORED".

Refs #4757
</pre>
</div>
</content>
</entry>
<entry>
<title>ComplianceCheckSet: Rename to `all_statuses_ok?`</title>
<updated>2017-11-13T16:52:54+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2017-11-09T15:44:38+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/chouette-core/commit/?id=32d8376cd407c24a6eca5ebf2adfca3c7d9d776f'/>
<id>32d8376cd407c24a6eca5ebf2adfca3c7d9d776f</id>
<content type='text'>
Another suggestion from Robert, since this method returns a boolean,
maybe its name should end with a question mark.

Refs #4757
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Another suggestion from Robert, since this method returns a boolean,
maybe its name should end with a question mark.

Refs #4757
</pre>
</div>
</content>
</entry>
<entry>
<title>ComplianceCheckSet: Rename to `all_statuses_ok`</title>
<updated>2017-11-13T16:52:54+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2017-11-09T13:21:38+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/chouette-core/commit/?id=b172d774513ffbae5c8a88f39b3d4bb7e4ae51e0'/>
<id>b172d774513ffbae5c8a88f39b3d4bb7e4ae51e0</id>
<content type='text'>
Suggestion from Robert to have a simpler name. I had just written it the
way it sounded in my head when I wrote the method.

Refs #4757
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Suggestion from Robert to have a simpler name. I had just written it the
way it sounded in my head when I wrote the method.

Refs #4757
</pre>
</div>
</content>
</entry>
<entry>
<title>ComplianceCheckSet#update_status: Return result of `#update`</title>
<updated>2017-11-13T16:52:54+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2017-11-09T10:49:32+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/chouette-core/commit/?id=08bb5790c7637e338700ae7f8100770a4d1c9d6e'/>
<id>08bb5790c7637e338700ae7f8100770a4d1c9d6e</id>
<content type='text'>
We should return the result of the `ActiveRecord` `#update` call, so
that we can determine if there was an error saving the
`ComplianceCheckSet` record.

Refs #4757
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We should return the result of the `ActiveRecord` `#update` call, so
that we can determine if there was an error saving the
`ComplianceCheckSet` record.

Refs #4757
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "ComplianceCheckSet#update_status: Should return a boolean"</title>
<updated>2017-11-13T16:52:54+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2017-11-09T10:46:42+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/chouette-core/commit/?id=8602bf7a265f32fc84f609eca790c9a76a723be0'/>
<id>8602bf7a265f32fc84f609eca790c9a76a723be0</id>
<content type='text'>
This reverts commit b7477e28f90c961079c7b12c4992071cbc11b2d6.

This logic isn't right. We should return true/false based on the result
of `update`, as in, whether the value was able to be updated, instead of
on the contents of the status.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts commit b7477e28f90c961079c7b12c4992071cbc11b2d6.

This logic isn't right. We should return true/false based on the result
of `update`, as in, whether the value was able to be updated, instead of
on the contents of the status.
</pre>
</div>
</content>
</entry>
<entry>
<title>ComplianceCheckSet#update_status: Should return a boolean</title>
<updated>2017-11-13T16:52:54+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2017-11-09T10:44:28+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/chouette-core/commit/?id=406726c7d9f1d98a36e263c57a1fa361003cface'/>
<id>406726c7d9f1d98a36e263c57a1fa361003cface</id>
<content type='text'>
Ensure that `#update_status` always returns a boolean value. We'll be
using this to determine whether the updated status was 'successful' or
not. Hmmm. Wait. That's not right. We want to return true from the
update, we don't care about the status. The error case should be when
the `update` fails. Darn.

Refs #4757
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Ensure that `#update_status` always returns a boolean value. We'll be
using this to determine whether the updated status was 'successful' or
not. Hmmm. Wait. That's not right. We want to return true from the
update, we don't care about the status. The error case should be when
the `update` fails. Darn.

Refs #4757
</pre>
</div>
</content>
</entry>
</feed>
