chouette-core/app, branch 0000-refactor_netex_file Chouette manage transport static data NetexImport: Don't destroy non-existent Referentials 2017-11-17T16:05:57+00:00 Teddy Wing 2017-11-17T16:05:57+00:00 fbb667fd728aea64f58b6f4e68e180afa169cb2b Luc discovered this error in my method that destroys associated non-ready `Referential`s: > WorkbenchImport.destroy_all WorkbenchImport Load (3.0ms) SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."type" IN ('WorkbenchImport') (1.5ms) BEGIN ImportMessage Load (2.7ms) SELECT "public"."import_messages".* FROM "public"."import_messages" WHERE "public"."import_messages"."import_id" = $1 [["import_id", 58]] ImportResource Load (1.9ms) SELECT "public"."import_resources".* FROM "public"."import_resources" WHERE "public"."import_resources"."import_id" = $1 [["import_id", 58]] Import Load (0.3ms) SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."parent_id" = $1 [["parent_id", 58]] ImportMessage Load (0.5ms) SELECT "public"."import_messages".* FROM "public"."import_messages" WHERE "public"."import_messages"."import_id" = $1 [["import_id", 59]] ImportResource Load (4.8ms) SELECT "public"."import_resources".* FROM "public"."import_resources" WHERE "public"."import_resources"."import_id" = $1 [["import_id", 59]] SQL (1.3ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 636]] SQL (0.3ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 635]] SQL (0.2ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 634]] SQL (0.2ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 633]] SQL (0.2ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 632]] SQL (0.2ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 631]] SQL (0.2ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 630]] SQL (0.1ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 629]] SQL (0.2ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 628]] SQL (0.1ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 627]] SQL (0.1ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 626]] SQL (0.3ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 625]] SQL (0.3ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 624]] SQL (0.2ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 623]] SQL (0.2ms) DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1 [["id", 622]] Import Load (0.3ms) SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."parent_id" = $1 [["parent_id", 59]] Referential Load (0.6ms) SELECT "public"."referentials".* FROM "public"."referentials" WHERE "public"."referentials"."id" = $1 LIMIT 1 [["id", 18]] (0.2ms) ROLLBACK NoMethodError: undefined method `ready' for nil:NilClass from .../stif-boiv/app/models/netex_import.rb:20:in `destroy_non_ready_referential' Since `referential` is not a required attribute, it can be nil. That was causing this to break because I tried to destroy a `Referential` that doesn't exist. Check that there's an associated `Referential` before trying to destroy it. Refs #4991 
Luc discovered this error in my method that destroys associated
non-ready `Referential`s:

    > WorkbenchImport.destroy_all
      WorkbenchImport Load (3.0ms)  SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."type" IN ('WorkbenchImport')
       (1.5ms)  BEGIN
      ImportMessage Load (2.7ms)  SELECT "public"."import_messages".* FROM "public"."import_messages" WHERE "public"."import_messages"."import_id" = $1  [["import_id", 58]]
      ImportResource Load (1.9ms)  SELECT "public"."import_resources".* FROM "public"."import_resources" WHERE "public"."import_resources"."import_id" = $1  [["import_id", 58]]
      Import Load (0.3ms)  SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."parent_id" = $1  [["parent_id", 58]]
      ImportMessage Load (0.5ms)  SELECT "public"."import_messages".* FROM "public"."import_messages" WHERE "public"."import_messages"."import_id" = $1  [["import_id", 59]]
      ImportResource Load (4.8ms)  SELECT "public"."import_resources".* FROM "public"."import_resources" WHERE "public"."import_resources"."import_id" = $1  [["import_id", 59]]
      SQL (1.3ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 636]]
      SQL (0.3ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 635]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 634]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 633]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 632]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 631]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 630]]
      SQL (0.1ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 629]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 628]]
      SQL (0.1ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 627]]
      SQL (0.1ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 626]]
      SQL (0.3ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 625]]
      SQL (0.3ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 624]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 623]]
      SQL (0.2ms)  DELETE FROM "public"."import_resources" WHERE "public"."import_resources"."id" = $1  [["id", 622]]
      Import Load (0.3ms)  SELECT "public"."imports".* FROM "public"."imports" WHERE "public"."imports"."parent_id" = $1  [["parent_id", 59]]
      Referential Load (0.6ms)  SELECT  "public"."referentials".* FROM "public"."referentials" WHERE "public"."referentials"."id" = $1 LIMIT 1  [["id", 18]]
       (0.2ms)  ROLLBACK
    NoMethodError: undefined method `ready' for nil:NilClass
    from .../stif-boiv/app/models/netex_import.rb:20:in `destroy_non_ready_referential'

Since `referential` is not a required attribute, it can be nil. That was
causing this to break because I tried to destroy a `Referential` that
doesn't exist. Check that there's an associated `Referential` before
trying to destroy it.

Refs #4991
Merge pull request #113 from af83/4823-compliance_check_show 2017-11-17T15:15:25+00:00 teddywing 2017-11-17T15:15:25+00:00 0d80f302bbf90334671b954b6788d581d5c852cb 4823 compliance check show 
4823 compliance check show
 Refs: #4823; Rebase fixed 2017-11-17T14:48:22+00:00 Robert 2017-11-17T14:48:22+00:00 b5536b6f8d7e5fbfe52d24e0b71bcc4984b87262 






bup
2017-11-17T14:18:09+00:00

Robert

2017-11-17T14:18:09+00:00

8eec4e215f969ba416c7b0e31852f9200b9abd59












Refs: #4823@0.2h; Last CR
2017-11-17T14:00:01+00:00

Robert

2017-11-17T08:58:22+00:00

371968fbe6365667bc83ac7e5b01a7782b62e1b7












Refs: #4823@0.2h; Code Review Part V
2017-11-17T13:57:36+00:00

Robert

2017-11-17T08:42:35+00:00

dd4c7df4193c32d20f9772159217741c14d1184e












Refs: #4823@0.1h; Code Review Part IV
2017-11-17T13:57:36+00:00

Robert

2017-11-16T07:17:12+00:00

9eecb15fb3381e67c28e0978016eb5ac1ec472ca












Refs: #4823@0.3h; Code Review Part III
2017-11-17T13:57:36+00:00

Robert

2017-11-16T07:13:24+00:00

05223891b456d043b8999b8ebce6a7b2eaf6ec6d












Refs: #4823@0.6h; Code Review Part I
2017-11-17T13:57:36+00:00

Robert

2017-11-16T06:45:22+00:00

21faf9940a6f7a9f685788eba2bdd267528cb0aa












Fixes: #4823@0.5h; Fixed regression in Ransack button "Effacer" implicit path does not work anymore
2017-11-17T13:57:36+00:00

Robert

2017-11-14T08:20:10+00:00

c0fa9f7de85fe32e95c7a923bb791525e0674c5d