chouette-core, branch robert-bup Chouette manage transport static data Refs: #4461@1h; CodeReview 2017-11-16T15:03:06+00:00 Robert 2017-11-16T15:03:06+00:00 3b855c870e39f4a607ff3b473abfa169e231648d - using webmock instead of mocking Net::HTTP therefore removing the connascence between the spec and the HTTP lib used in the implementation, thank you Teddy 
  - using webmock instead of mocking Net::HTTP
    therefore removing the connascence between the spec and the
    HTTP lib used in the implementation, thank you Teddy
Fixes: #4461@2h; Specing and Implementing 2017-11-15T16:15:24+00:00 Robert 2017-11-15T16:15:24+00:00 30c362f0371c081e0ddb9bc13c5873b1aecda1eb 






Refs: #4461@1.5h; Repaired netex_import factory, adapted spec/models/import_spec
2017-11-15T14:23:27+00:00

Robert

2017-11-15T14:23:27+00:00

fff9c009c885a4ed99d50ccaa8c8d01c12f86f19












Refs #4952 Add conidtion to display ComplianceControlBlock edit button depending on user permissions
2017-11-13T17:01:39+00:00

cedricnjanga

2017-11-13T17:01:11+00:00

96afaed78fa043449c0264ea09f0106147755c8e












ComplianceCheckSet#update_status: Return `true` if no update happened
2017-11-13T16:52:54+00:00

Teddy Wing

2017-11-13T15:27:49+00:00

e57f45bd6478baeab25ae96ae688587dda85247f

Return `true` from this method by default. If the `#update` call fails,
then it will return `false`, but in all other cases, we should return
`true`. That way, when the
`Api::V1::ComplianceCheckSetsController#validated` endpoint is called,
it will respond with the `ComplianceCheckSet` object instead of:

    {"status":"error","messages":[]}

with no error messages.

Refs #4757





Return `true` from this method by default. If the `#update` call fails,
then it will return `false`, but in all other cases, we should return
`true`. That way, when the
`Api::V1::ComplianceCheckSetsController#validated` endpoint is called,
it will respond with the `ComplianceCheckSet` object instead of:

    {"status":"error","messages":[]}

with no error messages.

Refs #4757







ComplianceCheckSet#update_status: Handle resources with "IGNORED" status
2017-11-13T16:52:54+00:00

Teddy Wing

2017-11-13T15:09:20+00:00

5dd6b2f963d3ae732c6f56112e5f5ac56b6c2764

If any associated resources have the "IGNORED" status, this shouldn't
affect the outcome of a "successful" status. Allow the
`ComplianceCheckSet` to be "successful" even if some `Resource`s are
"IGNORED".

Refs #4757





If any associated resources have the "IGNORED" status, this shouldn't
affect the outcome of a "successful" status. Allow the
`ComplianceCheckSet` to be "successful" even if some `Resource`s are
"IGNORED".

Refs #4757







ComplianceCheckSet: Rename to `all_statuses_ok?`
2017-11-13T16:52:54+00:00

Teddy Wing

2017-11-09T15:44:38+00:00

32d8376cd407c24a6eca5ebf2adfca3c7d9d776f

Another suggestion from Robert, since this method returns a boolean,
maybe its name should end with a question mark.

Refs #4757





Another suggestion from Robert, since this method returns a boolean,
maybe its name should end with a question mark.

Refs #4757







ComplianceCheckSet: Rename to `all_statuses_ok`
2017-11-13T16:52:54+00:00

Teddy Wing

2017-11-09T13:21:38+00:00

b172d774513ffbae5c8a88f39b3d4bb7e4ae51e0

Suggestion from Robert to have a simpler name. I had just written it the
way it sounded in my head when I wrote the method.

Refs #4757





Suggestion from Robert to have a simpler name. I had just written it the
way it sounded in my head when I wrote the method.

Refs #4757







ComplianceCheckSet#update_status: Return result of `#update`
2017-11-13T16:52:54+00:00

Teddy Wing

2017-11-09T10:49:32+00:00

08bb5790c7637e338700ae7f8100770a4d1c9d6e

We should return the result of the `ActiveRecord` `#update` call, so
that we can determine if there was an error saving the
`ComplianceCheckSet` record.

Refs #4757





We should return the result of the `ActiveRecord` `#update` call, so
that we can determine if there was an error saving the
`ComplianceCheckSet` record.

Refs #4757







Revert "ComplianceCheckSet#update_status: Should return a boolean"
2017-11-13T16:52:54+00:00

Teddy Wing

2017-11-09T10:46:42+00:00

8602bf7a265f32fc84f609eca790c9a76a723be0

This reverts commit b7477e28f90c961079c7b12c4992071cbc11b2d6.

This logic isn't right. We should return true/false based on the result
of `update`, as in, whether the value was able to be updated, instead of
on the contents of the status.





This reverts commit b7477e28f90c961079c7b12c4992071cbc11b2d6.

This logic isn't right. We should return true/false based on the result
of `update`, as in, whether the value was able to be updated, instead of
on the contents of the status.