chouette-core, branch 4986-compliance_control_sets_fix

Refs #4986 Add new filer by compliance control set name, add new styles for display input search inside a form-group filter layout

2017-11-17T16:02:54+00:00

Merge branch '4516_cleanup_rule_parameter_set'

2017-11-17T11:09:42+00:00

Remove migration

2017-11-17T11:04:51+00:00

Refs #4516

Merge pull request #116 from af83/4962-when-WorkbenchImport-is-deleted-also-delete-associated-Referential-if-ready-false

2017-11-17T06:47:56+00:00

4962 when workbench import is deleted also delete associated referential if ready false

Merge pull request #117 from af83/4951-spec-to-validate-that-primary-and-foreign-keys-in-the-database-are-type-bigint

2017-11-15T16:21:59+00:00

4951 spec to validate that primary and foreign keys in the database are type bigint

schema_spec: Make regex more readable with whitespace

2017-11-15T15:51:54+00:00

Thanks again to Robert. Today I learned what the `x` flag is. It ignores
whitespace inside the regex pattern. This way we can add spaces to make
the pattern more readable and still match what we were matching before
when the code was more condensed. Nice!

Refs #4951

schema_spec: Remove unnecessary capture

2017-11-15T15:22:05+00:00

Thanks to Robert for suggesting `(?:...)`. I didn't know that syntax,
happy I learned something new. Here, I had used parentheses for the "or"
(`|`), but didn't need the captured value. To do the "or" without
capturing, you can use the `?:` inside the start of the parentheses.

Refs #4951

schema_spec: Change spaces to `\s`

2017-11-15T15:20:31+00:00

Robert wisely recommended using `\s` just in case somehow tabs end up in
the `schema.rb` file.

Refs #4951

schema_spec: Use Ruby 2.2-compatible heredoc

2017-11-14T15:38:52+00:00

Apparently the Jenkins server runs Ruby 2.2.0.

Sample log output:

    /usr/bin/ruby2.2 -I/var/lib/jenkins/workspace/stif-boiv-branches/vendor/bundle-201746/ruby/2.2.0/gems/rspec-core-3.5.4/lib:/var/lib/jenkins/workspace/stif-boiv-branches/vendor/bundle-201746/ruby/2.2.0/gems/rspec-support-3.5.0/lib /var/lib/jenkins/workspace/stif-boiv-branches/vendor/bundle-201746/ruby/2.2.0/gems/rspec-core-3.5.4/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb

WTF? I thought we were all using Ruby 2.3.

Here's the error:

    /var/lib/jenkins/workspace/stif-boiv-branches/spec/db/schema_spec.rb:38: syntax error, unexpected << (SyntaxError)
        <<~EOS
          ^
    /var/lib/jenkins/workspace/stif-boiv-branches/spec/db/schema_spec.rb:40: syntax error, unexpected ':', expecting keyword_end
          Diff: #{diff}
               ^

Convert the tilde-heredoc to a dash-heredoc to make Jenkins happy.

Refs #4951

Remove test migration for schema_spec.rb

2017-11-14T15:06:14+00:00

I had created this as a temporary migration for testing the `bigint`
spec in `schema_spec.rb`. Now that I've finished writing the spec, I
don't need this any more.

Refs #4951