chouette-core, branch 4800-hstore-numeric-validation Chouette manage transport static data Refs: #4800@0.5h; Very rude, proof of concept implementation of HstoreAtts 2017-11-17T06:16:17+00:00 Robert 2017-11-17T06:16:17+00:00 8034138a769d710e67167f1435f021ef2e8b8977 






Refs: #4800@0.8h; sketching our own hstore_accessor implementation
2017-11-17T05:35:51+00:00

Robert

2017-11-17T05:17:46+00:00

85f7fe2a43fcd26278098ed6a2f4fa916f3c03be












Refs: #4800@1h; Dead end, trying manual override, is waaay to much work [skip-ci]
2017-11-16T13:33:18+00:00

Robert

2017-11-16T13:33:18+00:00

4fa233cb131f586d310faec8c9fc3ed88805ae76












Refs: #4800@2h; sketching out an alternative solution
2017-11-16T06:07:42+00:00

Robert

2017-11-15T22:55:32+00:00

83cee8ade1c6a9cfd7db724ba60f82f2229e78a2












Refs #4952 Add conidtion to display ComplianceControlBlock edit button depending on user permissions
2017-11-13T17:01:39+00:00

cedricnjanga

2017-11-13T17:01:11+00:00

96afaed78fa043449c0264ea09f0106147755c8e












ComplianceCheckSet#update_status: Return `true` if no update happened
2017-11-13T16:52:54+00:00

Teddy Wing

2017-11-13T15:27:49+00:00

e57f45bd6478baeab25ae96ae688587dda85247f

Return `true` from this method by default. If the `#update` call fails,
then it will return `false`, but in all other cases, we should return
`true`. That way, when the
`Api::V1::ComplianceCheckSetsController#validated` endpoint is called,
it will respond with the `ComplianceCheckSet` object instead of:

    {"status":"error","messages":[]}

with no error messages.

Refs #4757





Return `true` from this method by default. If the `#update` call fails,
then it will return `false`, but in all other cases, we should return
`true`. That way, when the
`Api::V1::ComplianceCheckSetsController#validated` endpoint is called,
it will respond with the `ComplianceCheckSet` object instead of:

    {"status":"error","messages":[]}

with no error messages.

Refs #4757







ComplianceCheckSet#update_status: Handle resources with "IGNORED" status
2017-11-13T16:52:54+00:00

Teddy Wing

2017-11-13T15:09:20+00:00

5dd6b2f963d3ae732c6f56112e5f5ac56b6c2764

If any associated resources have the "IGNORED" status, this shouldn't
affect the outcome of a "successful" status. Allow the
`ComplianceCheckSet` to be "successful" even if some `Resource`s are
"IGNORED".

Refs #4757





If any associated resources have the "IGNORED" status, this shouldn't
affect the outcome of a "successful" status. Allow the
`ComplianceCheckSet` to be "successful" even if some `Resource`s are
"IGNORED".

Refs #4757







ComplianceCheckSet: Rename to `all_statuses_ok?`
2017-11-13T16:52:54+00:00

Teddy Wing

2017-11-09T15:44:38+00:00

32d8376cd407c24a6eca5ebf2adfca3c7d9d776f

Another suggestion from Robert, since this method returns a boolean,
maybe its name should end with a question mark.

Refs #4757





Another suggestion from Robert, since this method returns a boolean,
maybe its name should end with a question mark.

Refs #4757







ComplianceCheckSet: Rename to `all_statuses_ok`
2017-11-13T16:52:54+00:00

Teddy Wing

2017-11-09T13:21:38+00:00

b172d774513ffbae5c8a88f39b3d4bb7e4ae51e0

Suggestion from Robert to have a simpler name. I had just written it the
way it sounded in my head when I wrote the method.

Refs #4757





Suggestion from Robert to have a simpler name. I had just written it the
way it sounded in my head when I wrote the method.

Refs #4757







ComplianceCheckSet#update_status: Return result of `#update`
2017-11-13T16:52:54+00:00

Teddy Wing

2017-11-09T10:49:32+00:00

08bb5790c7637e338700ae7f8100770a4d1c9d6e

We should return the result of the `ActiveRecord` `#update` call, so
that we can determine if there was an error saving the
`ComplianceCheckSet` record.

Refs #4757





We should return the result of the `ActiveRecord` `#update` call, so
that we can determine if there was an error saving the
`ComplianceCheckSet` record.

Refs #4757