From e1da727a4e1952156be851816cc377bb9704fc02 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Wed, 22 Aug 2012 19:49:17 -0500 Subject: FormulaInstaller: disambiguate show_header usage show_header should default to false (we don't want to display it in the case of installing a single formula without dependencies), but it only worked this way by accident. The assignment "show_header = true" creates a local variable named show_header, and in the case where needed_deps is empty and this assignment is not actually executed, the latter usage evaluates the local variable instead of calling the method. Signed-off-by: Jack Nagel --- Library/Homebrew/formula_installer.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'Library') diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb index 5ceaa9fe4..65f6d44b3 100644 --- a/Library/Homebrew/formula_installer.rb +++ b/Library/Homebrew/formula_installer.rb @@ -15,7 +15,7 @@ class FormulaInstaller def initialize ff, tab=nil @f = ff @tab = tab - @show_header = true + @show_header = false @ignore_deps = ARGV.ignore_deps? || ARGV.interactive? @install_bottle = install_bottle? ff @@ -99,7 +99,7 @@ class FormulaInstaller end end # now show header as all the deps stuff has clouded the original issue - show_header = true + @show_header = true end end -- cgit v1.2.3