From 690e841fcac1088043e259e273d79707e0616992 Mon Sep 17 00:00:00 2001 From: mansimarkaur Date: Fri, 23 Jun 2017 06:26:23 +0530 Subject: Added tests for language/java --- Library/Homebrew/test/language/java_spec.rb | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 Library/Homebrew/test/language/java_spec.rb (limited to 'Library') diff --git a/Library/Homebrew/test/language/java_spec.rb b/Library/Homebrew/test/language/java_spec.rb new file mode 100644 index 000000000..7c9262ef3 --- /dev/null +++ b/Library/Homebrew/test/language/java_spec.rb @@ -0,0 +1,25 @@ +require "language/java" + +describe Language::Java do + describe "#self.java_home_env" do + it "returns java_home path with version if version specified" do + java_home = described_class.java_home_env("blah") + expect(java_home[:JAVA_HOME]).to include(" --version blah") + end + it "returns java_home path without version if version is not specified" do + java_home = described_class.java_home_env + expect(java_home[:JAVA_HOME]).not_to include(" --version") + end + end + + describe "#self.overridable_java_home_env" do + it "returns java_home path with version if version specified" do + java_home = described_class.overridable_java_home_env("blah") + expect(java_home[:JAVA_HOME]).to include(" --version blah") + end + it "returns java_home path without version if version is not specified" do + java_home = described_class.overridable_java_home_env + expect(java_home[:JAVA_HOME]).not_to include(" --version") + end + end +end -- cgit v1.2.3 From 66d5baf3fe544a69b0a7279740616d013dc15fdd Mon Sep 17 00:00:00 2001 From: mansimarkaur Date: Sat, 24 Jun 2017 02:18:52 +0530 Subject: Removed extra space from include clause --- Library/Homebrew/test/language/java_spec.rb | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'Library') diff --git a/Library/Homebrew/test/language/java_spec.rb b/Library/Homebrew/test/language/java_spec.rb index 7c9262ef3..2c5dcd3a2 100644 --- a/Library/Homebrew/test/language/java_spec.rb +++ b/Library/Homebrew/test/language/java_spec.rb @@ -4,22 +4,25 @@ describe Language::Java do describe "#self.java_home_env" do it "returns java_home path with version if version specified" do java_home = described_class.java_home_env("blah") - expect(java_home[:JAVA_HOME]).to include(" --version blah") + expect(java_home[:JAVA_HOME]).to include("--version blah") end + it "returns java_home path without version if version is not specified" do java_home = described_class.java_home_env - expect(java_home[:JAVA_HOME]).not_to include(" --version") + expect(java_home[:JAVA_HOME]).not_to include("--version") end end describe "#self.overridable_java_home_env" do + let(:JAVA_HOME) { "haha" } it "returns java_home path with version if version specified" do java_home = described_class.overridable_java_home_env("blah") - expect(java_home[:JAVA_HOME]).to include(" --version blah") + expect(java_home[:JAVA_HOME]).to eq("haha") end + it "returns java_home path without version if version is not specified" do java_home = described_class.overridable_java_home_env - expect(java_home[:JAVA_HOME]).not_to include(" --version") + expect(java_home[:JAVA_HOME]).not_to include("--version") end end end -- cgit v1.2.3 From 1df9a475a8ebad1c15bb7f81a6ce70e4940255a6 Mon Sep 17 00:00:00 2001 From: mansimarkaur Date: Sun, 25 Jun 2017 06:04:09 +0530 Subject: Set java environment var to test overriding --- Library/Homebrew/test/language/java_spec.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'Library') diff --git a/Library/Homebrew/test/language/java_spec.rb b/Library/Homebrew/test/language/java_spec.rb index 2c5dcd3a2..86f0b478c 100644 --- a/Library/Homebrew/test/language/java_spec.rb +++ b/Library/Homebrew/test/language/java_spec.rb @@ -14,15 +14,15 @@ describe Language::Java do end describe "#self.overridable_java_home_env" do - let(:JAVA_HOME) { "haha" } + ENV["JAVA_HOME"] = "java_home" it "returns java_home path with version if version specified" do java_home = described_class.overridable_java_home_env("blah") - expect(java_home[:JAVA_HOME]).to eq("haha") + expect(java_home[:JAVA_HOME]).to eq("java_home") end it "returns java_home path without version if version is not specified" do java_home = described_class.overridable_java_home_env - expect(java_home[:JAVA_HOME]).not_to include("--version") + expect(java_home[:JAVA_HOME]).to eq("java_home") end end end -- cgit v1.2.3 From fac708da7a436996535b4c3cfd1a321267ff6d08 Mon Sep 17 00:00:00 2001 From: mansimarkaur Date: Sun, 25 Jun 2017 06:27:53 +0530 Subject: changes test names for class methods --- Library/Homebrew/test/language/java_spec.rb | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'Library') diff --git a/Library/Homebrew/test/language/java_spec.rb b/Library/Homebrew/test/language/java_spec.rb index 86f0b478c..7b132e996 100644 --- a/Library/Homebrew/test/language/java_spec.rb +++ b/Library/Homebrew/test/language/java_spec.rb @@ -1,7 +1,7 @@ require "language/java" describe Language::Java do - describe "#self.java_home_env" do + describe "::java_home_env" do it "returns java_home path with version if version specified" do java_home = described_class.java_home_env("blah") expect(java_home[:JAVA_HOME]).to include("--version blah") @@ -13,16 +13,15 @@ describe Language::Java do end end - describe "#self.overridable_java_home_env" do - ENV["JAVA_HOME"] = "java_home" + describe "::overridable_java_home_env" do it "returns java_home path with version if version specified" do java_home = described_class.overridable_java_home_env("blah") - expect(java_home[:JAVA_HOME]).to eq("java_home") + expect(java_home[:JAVA_HOME]).to include("--version blah") end it "returns java_home path without version if version is not specified" do java_home = described_class.overridable_java_home_env - expect(java_home[:JAVA_HOME]).to eq("java_home") + expect(java_home[:JAVA_HOME]).not_to include("--version") end end end -- cgit v1.2.3