From 60f96df44dc9d3145d605cddee1d27b1980ae14a Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Wed, 15 Mar 2017 19:29:16 +0100 Subject: formula_installer: need up to date req formulae. This makes them behave consistently to other dependencies. Otherwise other checks for them being `installed?` will fail. Fixes #2333 Closes #2302 Fixes https://github.com/Homebrew/homebrew-science/issues/5247 --- Library/Homebrew/formula_installer.rb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'Library') diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb index 1f91ad5c4..fa46a30f4 100644 --- a/Library/Homebrew/formula_installer.rb +++ b/Library/Homebrew/formula_installer.rb @@ -410,10 +410,13 @@ class FormulaInstaller end def install_requirement_formula?(req, dependent, build) - return false unless req.to_dependency + req_dependency = req.to_dependency + return false unless req_dependency return true unless req.satisfied? return false if req.run? - install_bottle_for?(dependent, build) || build_bottle? + return true if build_bottle? + return true unless req_dependency.installed? + install_bottle_for?(dependent, build) end def expand_requirements -- cgit v1.2.3