From 62c0a391b41d64b5c7634e2ebfa4a0415a3c9aa4 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Wed, 31 Dec 2014 10:37:29 -0500 Subject: Don't attempt to detect version if URL is not set --- Library/Homebrew/resource.rb | 2 ++ Library/Homebrew/test/test_resource.rb | 4 ++++ 2 files changed, 6 insertions(+) (limited to 'Library') diff --git a/Library/Homebrew/resource.rb b/Library/Homebrew/resource.rb index 573a7bcb1..0b30d72ad 100644 --- a/Library/Homebrew/resource.rb +++ b/Library/Homebrew/resource.rb @@ -148,6 +148,8 @@ class Resource private def detect_version(val) + return if val.nil? && url.nil? + case val when nil then Version.detect(url, specs) when String then Version.new(val) diff --git a/Library/Homebrew/test/test_resource.rb b/Library/Homebrew/test/test_resource.rb index e5cb288d2..245bc1789 100644 --- a/Library/Homebrew/test/test_resource.rb +++ b/Library/Homebrew/test/test_resource.rb @@ -81,6 +81,10 @@ class ResourceTests < Homebrew::TestCase assert_raises(TypeError) { @resource.version(Object.new) } end + def test_version_when_url_is_not_set + assert_nil @resource.version + end + def test_mirrors assert_empty @resource.mirrors @resource.mirror('foo') -- cgit v1.2.3