From 5c88e8d654f2ab8c5c3158bf28f13f08cfe6af50 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Tue, 21 Oct 2014 15:34:20 +0100 Subject: brew-test-bot: be more resilient to bad arguments. --- Library/Homebrew/cmd/test-bot.rb | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) (limited to 'Library') diff --git a/Library/Homebrew/cmd/test-bot.rb b/Library/Homebrew/cmd/test-bot.rb index 740a112ff..bb7aa7f73 100644 --- a/Library/Homebrew/cmd/test-bot.rb +++ b/Library/Homebrew/cmd/test-bot.rb @@ -175,7 +175,7 @@ module Homebrew elsif formula @formulae = [argument] else - odie "#{argument} is not a pull request URL, commit URL or formula name." + raise ArgumentError.new("#{argument} is not a pull request URL, commit URL or formula name.") end @category = __method__ @@ -597,8 +597,14 @@ module Homebrew tests << test else ARGV.named.each do |argument| - test = Test.new(argument, tap) - test_error = !test.run + test_error = false + begin + test = Test.new(argument, tap) + test_error = !test.run + rescue ArgumentError => e + test_error = true + ofail e.message + end any_errors ||= test_error tests << test end -- cgit v1.2.3