From 26f887d4ab02c9e1e061cb3537238fc5d6e81508 Mon Sep 17 00:00:00 2001 From: Adam Vandenberg Date: Mon, 3 Sep 2012 19:18:58 -0700 Subject: add audit for ENV.x11 --- Library/Homebrew/cmd/audit.rb | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'Library') diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index b0efe040f..030555beb 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -352,6 +352,10 @@ class FormulaAuditor problem "xcodebuild should be passed an explicit \"SYMROOT\"" end + if text =~ /ENV\.x11/ + problem "Use \"depends_on :x11\" instead of \"ENV.x11\"" + end + # Avoid hard-coding compilers if text =~ %r[(system|ENV\[.+\]\s?=)\s?['"](/usr/bin/)?(gcc|llvm-gcc|clang)['" ]] problem "Use \"\#{ENV.cc}\" instead of hard-coding \"#{$3}\"" -- cgit v1.2.3