From 73b79de7bcd97e10c8d3719988bf08f94373872f Mon Sep 17 00:00:00 2001 From: Xu Cheng Date: Fri, 26 Feb 2016 16:10:48 +0800 Subject: ARGV: switch? should only has one dash If user inputs argument such as `-with-flag`, we can assume it's a bad flag. Closes Homebrew/homebrew#49256 Closes Homebrew/homebrew#49550. Signed-off-by: Xu Cheng --- Library/Homebrew/test/test_ARGV.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'Library/Homebrew/test') diff --git a/Library/Homebrew/test/test_ARGV.rb b/Library/Homebrew/test/test_ARGV.rb index 4dc3f2677..39f32f452 100644 --- a/Library/Homebrew/test/test_ARGV.rb +++ b/Library/Homebrew/test/test_ARGV.rb @@ -48,9 +48,9 @@ class ArgvExtensionTests < Homebrew::TestCase end def test_switch? - @argv << "-ns" << "-i" << "--bar" + @argv << "-ns" << "-i" << "--bar" << "-a-bad-arg" %w[n s i].each { |s| assert @argv.switch?(s) } - %w[b ns bar --bar -n].each { |s| assert !@argv.switch?(s) } + %w[b ns bar --bar -n a bad arg].each { |s| assert !@argv.switch?(s) } end def test_flag? -- cgit v1.2.3