From 3efba57cd936f1e53b72a9e66561d594fcf37d65 Mon Sep 17 00:00:00 2001
From: Gautham Goli
Date: Mon, 14 Aug 2017 02:18:46 +0530
Subject: Add negated? method to formula cop and add tests for negated
 build.without?

---
 Library/Homebrew/test/rubocops/lines_cop_spec.rb | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

(limited to 'Library/Homebrew/test')

diff --git a/Library/Homebrew/test/rubocops/lines_cop_spec.rb b/Library/Homebrew/test/rubocops/lines_cop_spec.rb
index 8e3f42adf..e00834963 100644
--- a/Library/Homebrew/test/rubocops/lines_cop_spec.rb
+++ b/Library/Homebrew/test/rubocops/lines_cop_spec.rb
@@ -691,6 +691,30 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
         expect_offense(expected, actual)
       end
     end
+
+    it "with negated build.with?" do
+      source = <<-EOS.undent
+        class Foo < Formula
+          desc "foo"
+          url 'http://example.com/foo-1.0.tgz'
+          def post_install
+            return if !build.without? "bar"
+          end
+        end
+      EOS
+
+      expected_offenses = [{  message: "Don't negate 'build.without?': use 'build.with?'",
+                              severity: :convention,
+                              line: 5,
+                              column: 14,
+                              source: source }]
+
+      inspect_source(cop, source)
+
+      expected_offenses.zip(cop.offenses).each do |expected, actual|
+        expect_offense(expected, actual)
+      end
+    end
   end
   def expect_offense(expected, actual)
     expect(actual.message).to eq(expected[:message])
-- 
cgit v1.2.3