From 774a508d1ac9e8be8a2d3cc3a753d513e1b962e3 Mon Sep 17 00:00:00 2001 From: Baptiste Fontaine Date: Fri, 23 Oct 2015 10:41:39 +0200 Subject: audit: warn about unknown bottle modifiers This prevents typos like `bottle :uneeded` or `bottle :disable` Closes Homebrew/homebrew#45264. Signed-off-by: Xu Cheng --- Library/Homebrew/cmd/audit.rb | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'Library/Homebrew/cmd') diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index da07d207f..f21df6e26 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -463,6 +463,12 @@ class FormulaAuditor end end + def audit_bottle_spec + if formula.bottle_disabled? && !formula.bottle_disable_reason.valid? + problem "Unrecognized bottle modifier" + end + end + def audit_github_repository return unless @online @@ -904,6 +910,7 @@ class FormulaAuditor audit_specs audit_desc audit_homepage + audit_bottle_spec audit_github_repository audit_deps audit_conflicts -- cgit v1.2.3