From 144453368ed42c13e24143dd4e234795eb67f3cb Mon Sep 17 00:00:00 2001 From: Xu Cheng Date: Thu, 5 Mar 2015 18:05:07 +0800 Subject: test-bot pathname: use Utils.popen_read instead of backticks Closes Homebrew/homebrew#37418. Signed-off-by: Xu Cheng --- Library/Homebrew/cmd/test-bot.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'Library/Homebrew/cmd') diff --git a/Library/Homebrew/cmd/test-bot.rb b/Library/Homebrew/cmd/test-bot.rb index 44672dd58..44b67574b 100644 --- a/Library/Homebrew/cmd/test-bot.rb +++ b/Library/Homebrew/cmd/test-bot.rb @@ -365,12 +365,12 @@ module Homebrew end test "brew", "uses", canonical_formula_name - dependencies = `brew deps #{canonical_formula_name}`.split("\n") - dependencies -= `brew list`.split("\n") + dependencies = Utils.popen_read("brew", "deps", canonical_formula_name).split("\n") + dependencies -= Utils.popen_read("brew", "list").split("\n") unchanged_dependencies = dependencies - @formulae changed_dependences = dependencies - unchanged_dependencies - dependents = `brew uses --skip-build --skip-optional #{canonical_formula_name}`.split("\n") + dependents = Utils.popen_read("brew", "uses", "--skip-build", "--skip-optional", canonical_formula_name).split("\n") dependents -= @formulae dependents = dependents.map {|d| Formulary.factory(d)} @@ -573,7 +573,7 @@ module Homebrew non_dependencies = [] @formulae.each do |formula| - formula_dependencies = `brew deps #{formula}`.split("\n") + formula_dependencies = Utils.popen_read("brew", "deps", formula).split("\n") unchanged_dependencies = formula_dependencies - @formulae changed_dependences = formula_dependencies - unchanged_dependencies changed_dependences.each do |changed_formula| -- cgit v1.2.3