From 7ee98eb421380afd45144ef8df1656cb22d4bb66 Mon Sep 17 00:00:00 2001 From: L. E. Segovia Date: Fri, 24 Nov 2017 00:48:14 +0000 Subject: Implement more of @reitermarkus's comments - Simplify outdated Casks checks - Make use of RSpec's let(:) and .and syntax --- Library/Homebrew/cask/lib/hbc/cli/upgrade.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'Library/Homebrew/cask/lib/hbc/cli') diff --git a/Library/Homebrew/cask/lib/hbc/cli/upgrade.rb b/Library/Homebrew/cask/lib/hbc/cli/upgrade.rb index a6c679142..b567f6d20 100644 --- a/Library/Homebrew/cask/lib/hbc/cli/upgrade.rb +++ b/Library/Homebrew/cask/lib/hbc/cli/upgrade.rb @@ -12,7 +12,8 @@ module Hbc end def run - outdated_casks = casks(alternative: -> { Hbc.installed }).select { |cask| cask.outdated?(greedy?) || (args.include?(cask.token) && cask.outdated?(true)) } + outdated_casks = casks(alternative: -> { Hbc.installed.select { |cask| + cask.outdated?(greedy?) } }).select { |cask| cask.outdated?(true) } if outdated_casks.empty? oh1 "No Casks to upgrade" -- cgit v1.2.3