| Age | Commit message (Collapse) | Author |
|
Closes Homebrew/homebrew#44946.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Closes Homebrew/homebrew#44343.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
|
|
Closes Homebrew/homebrew#44893.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Just do a few things rather than doing e.g. a full compile.
Closes Homebrew/homebrew#44936.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Fixes Homebrew/homebrew#44331.
Closes Homebrew/homebrew#44709.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
|
|
See bfab4b0e65db4667ab09159b1040701fa75ec687
Closes Homebrew/homebrew#44889.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Removing all sysroot flags is ok until a non-OS X SDK is needed. In
that case, builds can fail due to the non-OS X SDK being overwritten or
overridden by the OS X SDK.
Sysroot flags are now only stripped if they are an OS X SDK. This is
reliant on only OS X SDKs containing the string "macosx", so this will
break if if the wrong SDK shows up. However, the chances of that
happening seem low, as Apple probably doesn't want to introduce
something OS X that doesn't work with OS X, so it should be robust for
the near future.
This could break in an environment without the command line tools. The
fix for that is a bit more involved, though, so that will have to go
later.
Closes Homebrew/homebrew#44312.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Closes Homebrew/homebrew#44843.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Closes Homebrew/homebrew#44458.
Closes Homebrew/homebrew#44773.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
There are audit rules which check cellar. Therefore, we need
`ARGV.resolved_formula` to get proper spec and prefix.
Closes Homebrew/homebrew#44781.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Otherwise, it will use the wrong prefix to test devel/HEAD install.
|
|
The flow is as follow:
* If tap is nil(DIY install), search using name.
* If tap is found, search using full name.
* If tap is found and full name searching failed, search using name.
This usually means the formula may be migrated to different tap.
Closes Homebrew/homebrew#44771.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Fixes Homebrew/homebrew#44729.
Fixes Homebrew/homebrew#40863.
Closes Homebrew/homebrew#44779.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Fixes Homebrew/homebrew#44687.
Closes Homebrew/homebrew#44770.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
Add `java` to `SHARE_PATHS` so that `HOMEBREW_PREFIX/share/java` is a folder with symlinks in it, rather than a symlink to a folder for a specific formula.
This way we avoid conflicts if multiple formulas put `jar` files in the
standard location `HOMEBREW_PREFIX/share/java`.
See also:
[pull request 44420](https://github.com/Homebrew/homebrew/pull/44420)
Closes Homebrew/homebrew#44456.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Fixes https://github.com/Homebrew/homebrew/issues/44320#issuecomment-143951973
Closes Homebrew/homebrew#44440.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Closes Homebrew/homebrew#44705.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Closes Homebrew/homebrew#44417.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
In the data returned from the GitHub API, “watchers_count” is actually the
number of stars.
See https://developer.github.com/v3/activity/starring/#starring-vs-watching
Closes Homebrew/homebrew#44477.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
Closes Homebrew/homebrew#44626.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Closes Homebrew/homebrew#44305.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Closes Homebrew/homebrew#44450.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Closes Homebrew/homebrew#44182.
Closes Homebrew/homebrew#44349.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
Closes Homebrew/homebrew#44544.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Closes Homebrew/homebrew#44542.
|
|
Closes Homebrew/homebrew#44497.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Closes Homebrew/homebrew#44451.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
|
|
|
|
|
|
There are plenty of IO operations inside Tap object, and it will be more
when implementing formula alias reverse look up(e.g. list all of alias
names for a formula). So let's cache them.
Some benchmark:
$ time brew info $(brew ruby -e 'puts Formula.tap_names') > /dev/null
Before: 6.40s user 2.42s system 96% cpu 9.134 total
After: 4.75s user 0.77s system 97% cpu 5.637 total
Closes Homebrew/homebrew#44377.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
This can help to solve the broken layout of doctor.out in brew gist-logs
|
|
Will replace it when we implemented `brew repair-permission`
|
|
Closes Homebrew/homebrew#42048
Closes Homebrew/homebrew#44434.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
|
|
Closes Homebrew/homebrew#44441.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
This ensures that binaries in /usr/local/bin would not overwrite
superenv.
Closes Homebrew/homebrew#44376.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
When a PR is merged during the test, the commit tree will be looked like
this:
master PR
\ /
\ /
|
root
The start_revision will be poined to the commit used to merging PR,
instead of common root commit. As result, `git diff-tree start end`
will list file changes both in PR and master branch, which later
contributes to additional formulae are tested in some Travis builds.
To fix the problem, we use `git merge-base` to get common ancestor as
the real start_revision.
Closes Homebrew/homebrew#44379.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Closes Homebrew/homebrew#44325.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
We previously set `ignore_deps?` as true for DependencyInstaller to
avoid duplicated dependencies resolution. (See a9fc82aea30506eeacbddeb8b53fb85de8acb9d4)
However, this will cause problem when pouring bottle of a dependency is
failed. In this case, it will try to build dependency from source but
failed due to uninstalled build deps for this formula.
Another disadvantage for using `ignore_deps?` hack is we cannot
distinguish users passing `--ignore-dependencies` flag from we are in
`DependencyInstaller`.
So, let's differentiate these using `skip_deps_check?`
|
|
|
|
When there's absolute symlinks in a linked directory in the `keg`
(e.g. `bin`)that point to the `Cellar` or `opt` then linking the `keg`
will fail before the `Cellar` or `opt` has been linked.
Closes Homebrew/homebrew#44306.
Closes Homebrew/homebrew#44329.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|