aboutsummaryrefslogtreecommitdiffstats
path: root/Library
AgeCommit message (Collapse)Author
2017-10-29Merge pull request #3376 from tomjonandy/fix/keychain-credentialsMike McQuaid
Fix issue where keychain github credentials wouldn't work
2017-10-29Merge pull request #2795 from issyl0/desc_no_full_stopsMike McQuaid
formula_desc_cop: ensure no full stops at the end of desc
2017-10-29formula_desc_cop: ensure no full stops at the end of descIsabell Long
- This was a suggestion by Mike McQuaid in my `homebrew-core` audit description PR. Based on ilovezfs's incantation `grep -r -E 'desc ".*\."' *.rb`, some formulae descriptions do end in full stops. (My initial assessment of this failed to account for the fact that descriptions are strings and so end in `"`.) - Add an autocorrect for this cop, too.
2017-10-29Tweak use of with_envMike McQuaid
- Use it in more places where it saves code - Allow using symbolic keys for a cleaner interface - Use `HOMEBREW_GEM_*` instead of `GEM_OLD_*`
2017-10-29ENV/std: fully extend from HOMEBREW_PATH.Mike McQuaid
Rather than just re-adding HOMEBREW_PREFIX/bin if it's missing re-add everything from HOMEBREW_PATH. This works well with or without environment filtering being enabled but with environment filtering it ensures that ENV/std just builds on the original user environment.
2017-10-29Merge pull request #3388 from MikeMcQuaid/bump-formula-pr-env-filteringMike McQuaid
bump-formula-pr: always use HOMEBREW_PATH.
2017-10-28Check that a single uninstall_* and zap stanzas is definedL. E. Segovia
2017-10-28bump-formula-pr: always use HOMEBREW_PATH.Mike McQuaid
Fixes this when using environment filtering.
2017-10-28system_config: get perl/ruby from HOMEBREW_PATH.Mike McQuaid
This is the actual user path when env filtering is enabled.
2017-10-28Merge pull request #3380 from jmsundar/apfs_tap-infoMike McQuaid
tap-info: handle APFS returning hash order
2017-10-28style changesJayendra Minakshisundar
2017-10-27Merge pull request #3381 from iMichka/flockMike McQuaid
lock.sh: suppress error output when looking for flock
2017-10-27lines_cop: add missing e.g. clang++ regex SOL.Mike McQuaid
You need a start of line check in this regex (like was added in the others) to allow things like `#{bin}/clang++`.
2017-10-27lock.sh: suppress error output when looking for flockMichka Popoff
Fixes (on centos6): which: no flock in (/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin)
2017-10-27rubocop.yml: re-add Homebrew metrics maximums.Mike McQuaid
2017-10-27rubocop.yml: reduce tap maximum line length.Mike McQuaid
2017-10-27test.flac: add flac fixture.Mike McQuaid
2017-10-27Merge pull request #3372 from MikeMcQuaid/rubocop-length-tapsMike McQuaid
rubocop: disable length checks.
2017-10-27Merge pull request #3368 from MikeMcQuaid/unhide-readall-update-resetMike McQuaid
Unhide readall and update-reset from manpage.
2017-10-27tap-info: sort taps by name to handle APFSJayendra Minakshisundar
2017-10-26Fix issue where keychain github credentials wouldn't workThomas Andrew
2017-10-26Merge pull request #3352 from JCount/legacy-java-cask-requirement-supportJCount
java_requirement: support prompting users to install legacy Java casks
2017-10-26Unhide readall and update-reset from manpage.Mike McQuaid
These are both tools that end-users can find useful on occasion so it doesn't make sense to hide them.
2017-10-26rubocop: disable length checks.Mike McQuaid
We should keep these enabled for Homebrew/brew but for taps these just end up being annoying and making `brew style` fail for little benefit
2017-10-26Merge pull request #3366 from GauthamGoli/lines-cop-false-positives-fixMike McQuaid
lines_cop: Fix detection of negated expression
2017-10-26java_requirement: support prompting users to install legacy Java casksJCount
This enhances the Java requirement to support prompting the user to install the correct legacy Java version via Cask for formulae that don't yet work with the latest version of Java. Previously, even if the formula had a strict requirement that a specific, older version of Java be used, the messaging would tell the user to `brew cask install java` (i.e. to install the latest version of Java), which wouldn't actually satisfy the requirement.
2017-10-26lines_cop: Fix detection of negated expressionGautham Goli
2017-10-26rubocop-cask: 0.15.1commitay
2017-10-25Merge pull request #3361 from MikeMcQuaid/lines_cop_clangMike McQuaid
lines_cop: fix clang detection.
2017-10-24Merge pull request #3349 from reitermarkus/rubocop-0.51Markus Reiter
Rubocop 0.51
2017-10-24Merge pull request #3306 from amyspark/hacktoberfest-quash-cask-helpMarkus Reiter
Fixes querying Cask commands' help
2017-10-24Update `rubocop-cask` to `0.15.0`.Markus Reiter
2017-10-24Add missing `require "forwardable"`.Markus Reiter
2017-10-24Use `/` to join path.Markus Reiter
2017-10-24Remove usless comments.Markus Reiter
2017-10-24Don't `require "thread"`.Markus Reiter
2017-10-24Include `FileUtils` in `spec_helper`.Markus Reiter
2017-10-24Don’t use `Style/StderrPuts`.Markus Reiter
2017-10-24Refactor and fix RuboCop specs.Markus Reiter
2017-10-24Update to RuboCop 0.51.Markus Reiter
2017-10-24lines_cop: fix clang detection.Mike McQuaid
We only care about e.g. `gcc`/`llvm-gcc`/`clang` being at the beginning of a `system` call and not anywhere within the string.
2017-10-24brew style fixesL. E. Segovia
2017-10-24Simplify cask help checkL. E. Segovia
2017-10-24github: require formula name to be in issue titleilovezfs
2017-10-24Merge pull request #3313 from ↵Mike McQuaid
GauthamGoli/audit_line_rubocop_part_4_rebase_attempt_1 audit: Port line_problems to rubocop and add tests part 4
2017-10-24Merge pull request #3345 from maxim-belkin/coffee-leavesMike McQuaid
leaves: account for requirements
2017-10-24Merge pull request #3358 from maxim-belkin/build-env2Mike McQuaid
build_environment: add Linux-specific environment variables
2017-10-22Merge pull request #3350 from DomT4/gpg_executableMike McQuaid
gpg: a little intentional yak shaving
2017-10-22Merge pull request #3337 from sjackman/pullMike McQuaid
pull: Fix pull --bottle 1234
2017-10-22pull: Fix pull --bottle 1234Shaun Jackman
Fix the error: Error: undefined method `casecmp' for nil:NilClass