| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
We always return the token/password first and, if applicable, the user
name is the second element in the returned array.
Closes #581.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
Closes #573.
|
|
`Tap.fetch` and commands building on top of it accepted tap names like
`homebrew/homebrew/bogus` causing some misbehavior. Ensure neither
`user` nor `repo` include slashes and print a more helpful error message
that additionally includes the problematic tap name.
Closes #585.
Closes #591.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Fixes #575.
|
|
Closes #577.
Signed-off-by: Baptiste Fontaine <b@ptistefontaine.fr>
|
|
In fact, we don't really care about undeclared dependencies for optional
installations. Because, this is mainly used to help us to detect breakage
for bottles so we can do a revision bump.
|
|
This makes BuildOptions more compatible with Tab object. Otherwise,
`brew reinstall foo` will just crash if foo is not installed.
|
|
This fixes a regression caused by 2e961dc9dee63f641f7f162fd7a2845c5fd092fe,
where a misplaced `+` cause the regex only catch one character.
Fixes https://github.com/Homebrew/homebrew-science/issues/3847.
|
|
|
|
|
|
|
|
|
|
Make sure to call `brew tests` only once with `--coverage` to avoid
expensive multiple runs and to prevent later runs from overwriting
previously sent results to Coveralls. (The previous setup overwrote the
results from a regular run with results from the `--generic` run.)
The `--no-compat` variant without any other options specified seemed to
be the most appropriate for a coverage report.
Closes #546.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
SimpleCov 0.12.0 brings some moderate speed improvements and soon (sadly
not yet) can be switched back to a stable release. Update to matching
Coveralls release, fortunately with fewer dependencies than before.
|
|
Make `Library/Homebrew` the new root now that *all* implementation files
are in this directory. Update filters/groups accordingly.
Note that paths in filters/groups are not anchored at the root and are
always matched against the full path. Our rules are effectively anchored
because they always include the `/Homebrew/` path component.
|
|
Provides feature parity between the block and non-block forms of
inreplace by creating a four-argument version of the non-block form,
where the fourth argument is an optional Boolean value, defaulting to
true, which specifies whether a failed inreplace should cause an
InreplaceError error to be raised. The fourth argument is passed along
to StringInreplaceExtension#gsub!, which already supports an optional
audit_result argument.
This resolves the Catch-22 that single replacements aren't permissible
in the block form (in that they now cause `brew audit` to complain), but
the audit_result argument is not available in the non-block form.
Closes #552.
Signed-off-by: ilovezfs <ilovezfs@icloud.com>
|
|
Since we are loading options as Formula#build from tab, we will have to explicitly read
options from ARGV as well.
Fixes #3066.
Closes #537.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
We already loaded tab in ARGV.resolved_formulae or Formulary.from_rack
|
|
We already loaded build options in ARGV.resolved_formulae for test and
postinstall
|
|
BuiltOptions#without? already handles the option_names for dependencies.
Also check disabled recommended deps.
|
|
Closes #524.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
|
|
Fixes https://github.com/Homebrew/homebrew-core/issues/3067.
|
|
|
|
Aside from being bad style, this also assigns to an unused variable.
|
|
If rubocop invocation from brew audit exits with nil exitstatus,
brew audit fails with 'undefined method `>' for nil:NilClass'.
|
|
Also prevent the commit of formula's HeadVersion from passing to the resource.
This is a fix of #531
|
|
On systems prior to 10.9, formulae that use CVS as a download source
check whether the installed Xcode already provides CVS to avoid adding
a dependency on the `cvs` formula. Unfortunately, if no Xcode is
installed the check fails with
undefined method `<' for nil:NilClass
causing the formula to become unloadable. This in turn causes some taps
to be untappable since #396 added the `readall` check on `tap`.
Closes #508.
|
|
Closes #529.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
|
|
This prevents a link conflict during `brew upgrade` causing opt link
stuck to old version. At this point, users will have to run `brew switch`
to fix it.
Closes #533.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
