aboutsummaryrefslogtreecommitdiffstats
path: root/Library
AgeCommit message (Collapse)Author
2012-08-26Formula factory: add commentAdam Vandenberg
2012-08-26Formula factory: re-raise certain NameErrors.Adam Vandenberg
Some name errors, such as NoMethodError, represent programming errors. Re-raise them to get a usable error message. Closes Homebrew/homebrew#14467.
2012-08-26Ask the user for help if MacOS.compilers_standard? failsJack Nagel
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-26create: allow --set-name and --set-versionAdam Vandenberg
Closes Homebrew/homebrew#10873. Closes Homebrew/homebrew#14401. Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2012-08-25formula_installer: make "linking" more clearsamueljohn
When building software "linking step did not complete" sounds like ld failed. Let's be clear about this. Closes Homebrew/homebrew#14407. Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2012-08-25tests: adjust test_bottle_spec_selection for new bottle codeJack Nagel
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-25brew-test-bot: add missing 'formula' require.Mike McQuaid
2012-08-25Don't fail to cleanup redacted formula.Mike McQuaid
2012-08-25Miscellaneous bottle code cleanup.Mike McQuaid
2012-08-25Check formula options properly to rule out bottle.Mike McQuaid
Fixes Homebrew/homebrew#14148.
2012-08-25Fix ARGV and bottles circular dependency.Mike McQuaid
2012-08-25Rename tab 'built_bottle' to 'build_as_bottle'.Mike McQuaid
2012-08-25Move used_options and unused_options to ARGV.Mike McQuaid
2012-08-25Fix tests and NoMethodError with no X11 installed.Mike McQuaid
2012-08-25erlang: fix version detection and bottles.Mike McQuaid
2012-08-25audit checks for passing dashes to build.include?Adam Vandenberg
2012-08-24XCodeDependency: Clarify that Xcode.app is neededCharlie Sharpsteen
Clarify the error message arising from XCodeDependency so that users know XCode.app is needed and that just installing the CLT does not count as "installing XCode".
2012-08-23Compact whitespace when removing flagsJack Nagel
This prevents multiple calls to flag-modifying ENV methods from resulting in large amounts of consecutive spaces. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-23Version: make MacOSVersion comparison more robustJack Nagel
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-23factory: always check const_defined? before requiringJack Nagel
Specifying dependencies with a URL works, even if by accident, but factory is called repeatedly on this URL and this results in multiple downloads of the same file. Fix this by checking const_defined? here too, and DRY up the code a bit. Fixes Homebrew/homebrew#14285. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-23Xcode-only: Clean up compiler flags. Use CPATH.samueljohn
- When using CPATH, we only need -isysroot and not the other -I spam. - LDFLAGS use -isysroot instead of -L Turns out that the linker also understands the -isysroot flag which behaves more natural (in the sense: "like the internal defaults `/usr/lib` etc.) than adding `-L$(SDKROOT). Especially for duplicates, the linker first searches through all `-L` dirs and then looks at the sysroot or internal defaults. This is what we want. - Pkg-config needs CC with CFLAGS passed to configure. Closes Homebrew/homebrew#14351. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-23Fix keg-only on pre-Mountain Lion formulae.Mike McQuaid
2012-08-22audit: be a bit more lenientAdam Vandenberg
2012-08-22audit: allow certain ARGV usagesAdam Vandenberg
2012-08-22audit: complain until we use option and buildAdam Vandenberg
2012-08-22Don't use XQuartz for e.g. :libpng on 10.8.Mike McQuaid
XQuartz isn't added to the default library paths so if something is linked against a Homebrew libpng then it doesn't work against the XQuartz libpng. The CLT provides X11 on Lion so don't request users install XQuartz if it isn't needed on Mountain Lion. Fixes Homebrew/homebrew#14325.
2012-08-22Cache found svn binaryAdam Vandenberg
2012-08-22Honor GIT env varAdam Vandenberg
2012-08-21factory: rescue NameErrorJack Nagel
Due to the new const_defined? checks, passing certain names (such as those that start with a digit) that are illegal constant names will raise NameError. Catch this and error out gracefully, as we would have previously. Fixes Homebrew/homebrew#14342. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-21keg_fix_install_names doesn't need FindJack Nagel
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-21mach-o: use any? instead of map and include?Jack Nagel
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-21Support ENV[VERBOSE]Max Howell
2012-08-21`brew irb` uses correct RubyMax Howell
Conversation here: 0a45d96b21a5056e5131f136e94533a6a57bf808
2012-08-21conflicts_with message: recommend unlinkMax Howell
Yes uninstall works, but lets not push people towards that, they can presumably guess that, in the rare case they'd prefer that option.
2012-08-21Better message if multiple kegs need linkingMax Howell
2012-08-21Formula.EnumerableMax Howell
Deprecated Formula.all, replaced usage with more appropriate enumerable options. Just check out how much nicer `brew audit` runs now.
2012-08-21In fact, there are 2 xcode-select files to deleteMax Howell
2012-08-20Simplify MacOS.locateJack Nagel
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-20MacOS.dev_tools_path: return nil if not foundJack Nagel
This matches the semantics of other path methods, such as Xcode.prefix. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-20Simplify build options APIJack Nagel
Simplify access to the different forms of a formula's build options by making options into real objects rather than strings, and expose both the 'name' and 'flag' form.
2012-08-20HOMEBREW_CONTRIBJack Nagel
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-19factory: don't reload previously defined formulaeJack Nagel
build.rb calls Formula.factory to get a usable Formula object to pass to its install method. However, because the formula file is the actual executing script, its class is already defined, and loading it again causes the class to be re-evaluated, which, unfortunately, is not idempotent. This bug has existed for a very long time, and its side effects include duplicate entries the deps array and mirrors array, among others. Fortunately, the fix is very simple. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-18Don't lie about upgrading up-to-date formulaeJack Nagel
Usually, the "foo-version already installed" error is printed by FormulaInstaller. However, if an up-to-date formula that has outdated deps is passed on the command line, we proceed to upgrade the deps and then print a message saying that the formulae given on the command line is already installed. Catch this earlier, when the outdated list is being populated, print an appropriate message, and skip the up-to-date formula. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-18upgrade: filter ARGV when expanding depsJack Nagel
This serves the same purpose as similar code in FormulaInstaller, but we duplicate it because we do the dependency expansion in an ad-hoc fashion here. Fixes Homebrew/homebrew#11863. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-18Add ARGV.ignore_deps?Jack Nagel
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-18Test version interrogation methodsJack Nagel
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-18Simplify version comparison testsJack Nagel
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-18Version: build-in devel version comparisonsJack Nagel
The heuristic used by the default version comparison is simple. A version string is scanned for strings of digits, split into an array of these strings, and then an element-wise comparison is done. This fails when presented with something like Version.new("1.0.0beta7") <=> Version.new("1.0.0") because the first three digits match, and the fourth digit of the receiver (7) is greater than the assumed fourth digit of the parameter (0). Fix this by defining an element-wise comparator on a new VersionElement class. This allows us to correctly compare "alpha", "beta", and "rc" style version strings, and keeps the logic out of the main version comparison. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-18brew-mirror-check: update for new specs APIJack Nagel
This was missed as part of the specs refactor. Fixes Homebrew/homebrew#14280. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-18Refer to the real keg when dying because the keg existsJack Nagel
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2026-01-02 18:16:52 +0000