| Age | Commit message (Collapse) | Author |
|---|
|
This should make more bottles relocatable e.g. ansible.
.pyo files are bytecode as .pyc files but optimized -
[ref](https://www.python.org/dev/peps/pep-0488/)
Ref https://github.com/Homebrew/homebrew-core/pull/2125#issuecomment-226987124
|
|
Closes #378.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
MachOFile#cputype now returns a Symbol.
|
|
|
|
|
|
|
|
Move check for emptiness into the display method, avoiding repetitive
checks on the call site.
Closes #381.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
|
|
Prevent raising an error when `HOMEBREW_RUBY_MACHO=1` is set. Skipping
symlinks and directories while iterating over a directory structure to
find Mach-O binaries makes sense and similar logic is applied elsewhere.
|
|
Closes #377.
Signed-off-by: Baptiste Fontaine <b@ptistefontaine.fr>
|
|
|
|
Prefer `Utils.git_version` instead of duplicating version detection
logic. Decouple unnecessary conflated availability and version checks.
Closes #351.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
Due to our SCM wrapper in `Library/ENV/scm/git`, lookup is a bit more
complicated than just picking the first match in `PATH`. Make debugging
easier by printing the version and path of the Git actually used by us.
|
|
|
|
Print path of first detected Git instead of executing it. This is hidden
behind a `--homebrew=print-path` argument that is unlikely to conflict
with any existing or future Git flags.
|
|
If we're bumping the formula's stable version, then we also must reset
the formula revision to zero.
Note that if and only if a revision is being removed, this commit will
enforce the convention that there should be a blank line before a simple
head spec if and only if there is a formula revision. Any preexisting
violation of the convention (in particular, a blank line before a simple
head spec in the absence of a formula revision) won't be proactively
corrected since we'd not be removing a formula revision in that case.
Closes #369.
Signed-off-by: ilovezfs <ilovezfs@icloud.com>
|
|
- simulate version change for dry-run
- make sure we're using :devel version if called with --devel
Closes #318.
Signed-off-by: ilovezfs <ilovezfs@icloud.com>
|
|
Add SharedEnvExtension#gcc_with_cxx11_support? to centralise the
logic for checking whether a compiler is known to support C++11.
Update logic to accept GCC 4.8 and above (including 6). Thereby also
address oversight in #163 where support for GCC 6 was added without
updating the C++11 compiler whitelist.
Add tests for Superenv#cxx11.
Closes #346.
|
|
|
|
|
|
They may not but it's nice to be a bit more explicit.
|
|
|
|
|
|
Problems fixed:
- Broken and leaking test if run as part of `brew tests --coverage` due
to the `cmd` call being nested in the `Pathname#cd` block.
- Output during `git clone` operation because of a missing `shutup do`.
- Still incomplete coverage for `cmd/log.rb` because `brew log` is
invoked on the formula in the origin instead of the shallow clone.
- Minor stylistic fixes:
- Superfluous parentheses around `core_tap.path.dirname`.
- Overly long lines.
|
|
There is no good reason to configure the options specific to integration
tests in a completely different location from all other options.
|
|
Simply drop because the `require`s are not actually used by the tests
and no file from `compat/` should be loaded unconditionally. (This can
otherwise lead to incorrect results for `brew tests --no-compat`.)
|
|
Fixes:
```
1) Error:
FormularyFactoryTest#test_factory_from_bottle:
Errno::ENOENT: No such file or directory - /usr/local/Library/Homebrew/test/bottles/testball_bottle-0.1.sierra.bottle.tar.gz
/usr/local/Library/Homebrew/formulary.rb:98:in `realpath'
/usr/local/Library/Homebrew/formulary.rb:98:in `realpath'
/usr/local/Library/Homebrew/formulary.rb:98:in `initialize'
/usr/local/Library/Homebrew/formulary.rb:274:in `new'
/usr/local/Library/Homebrew/formulary.rb:274:in `loader_for'
/usr/local/Library/Homebrew/formulary.rb:215:in `factory'
/usr/local/Library/Homebrew/test/test_formulary.rb:79:in `test_factory_from_bottle'
```
Closes #358.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
Closes #357.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
|
|
|
|
|
|
As they may use e.g. `git pull` which may result in them having formulae
that aren't migrated (and they mind less about the slight slowdown).
|
|
|
|
This gives the JSON output the same type of information as
`recommended_dependencies` or `optional_dependencies`, but for those
marked `:build` in the formula.
|
|
For example, `brew deps libass --skip-recommended` shouldn't print
harfbuzz because, even though libass builds with harfbuzz when harfbuzz
is not skipped, we asked to skip recommended, of which harfbuzz is one.
The corresponding change is made for `brew uses` as well.
Thanks to Xu Cheng for contributing the code. Any errors are mine.
Closes #129.
Signed-off-by: ilovezfs <ilovezfs@icloud.com>
|
|
Add a new developer command (i.e., requires `HOMEBREW_DEVELOPER` set in
your environment) to "boneyard" a formula, by creating one pull request
removing the formula from its current tap and updating (or creating)
tap_migrations.json, and another pull request importing the formula into
homebrew/boneyard with any bottle block removed.
Closes #53.
Signed-off-by: ilovezfs <ilovezfs@icloud.com>
|
|
otherwise would get "cannot be installed as a a binary package"
since `package_text` contains "a binary package" in the singular case
|
|
This avoids `xcrun` popups when installing Homebrew on a non-Xcode
non-CLT machine.
|
|
Since #292, HOMEBREW_CACHE was moved to a per-user directory. This makes
it unsuitable to store global lock files on multiple users environment.
Therefore, introducing a global lock directory `/Library/Lock.d` to
store lock files from formula lockers as well as `brew update`.
|
|
Since patches sometimes change .gitignore and .travis.yml, it's
desirable to install them along with everything else if a resource needs
patching. Also, for resources that are git respositories, this allows
install to interact with git objects other than the commit specifically
checked out. More generally, this may help to avoid subtle issues by
preserving the fidelity of resources in cases where invisible dot files
play a functional role.
Closes #329.
Signed-off-by: ilovezfs <ilovezfs@icloud.com>
|
|
The new check also allows the `+` operator instead of our (still heavily
preferred) `/` operator for path concatenation and also triggers if the
operator is surrounded by whitespace.
Also recognizes single-quoted strings and uses a back reference to
match the closing quote for a slightly lower chance of false positives.
Closes #322.
|
|
git stash pop -q will print "Already up-to-date!" if untracked changes
are being poppped. This quiets it down unless verbose is set.
Closes #320.
Signed-off-by: ilovezfs <ilovezfs@icloud.com>
|
|
|
|
`Formula#keg_only?` could fail if it was invoked on a formula with a
`:provided_until_xcode43` or `:provided_until_xcode5` reason given to
`keg_only`, if neither the Command Line Tools nor Xcode was installed.
Check whether Xcode is installed before querying the Xcode version.
Closes #317.
|
|
|
|
|
|
Always pop stashed changes for Homebrew developers and only checkout
original branches for them (to avoid users who don't understand Git
ending up "stuck" on branches).
|
|
Closes https://github.com/Homebrew/homebrew-core/issues/1687.
|
|
|
|
* Move GitHub API module to utils/github.rb.
* Move curl method to utils/curl.rb.
* global: use long curl arguments and an array.
This makes the code more self-documenting.
* utils/curl: support reading curl's output.
* utils/github: use curl instead of open-uri.
It has far better proxy support.
* pull: set Homebrew user agent.
* gist-logs: remove trailing whitespace.
* gist-logs: use first instead of [0].
Easier to read.
* gist-logs: use curl-based GitHub.open method.
|
