| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Changes to our style configuration:
- Consolidate all rules related to Ruby 1.8 compatibility in one place.
- Codify our de-facto preference for `alias_method` over `alias` (drops
offense count by 54 after turning this on).
- Drop `Style/SignalException` as `only_raise` has been the new default
for quite a while (since RuboCop 0.37.0).
|
|
Fixes #491.
|
|
|
|
vendor ruby
|
|
|
|
* Use vendor Ruby if it's present
* Install vendor Ruby for system without Ruby 2.x
|
|
|
|
Requirement tweaks
|
|
The vendor Ruby will be put inside `Library/Homebrew/vendor/portable-ruby/<version>`,
with a symlink `Library/Homebrew/vendor/portable-ruby/current` pointed to it.
In addition, a `Library/Homebrew/vendor/portable-ruby-version` will
track the latest version of vendor binaries.
This gives us version control on vendor Ruby and enables us to bump vendor
Ruby whenever needed such as security update.
|
|
Most of our formulae do compilation so let's do it here too.
|
|
We’re just supporting the Cask now.
|
|
We’re just supporting the Cask now.
|
|
Nicer to split this onto two lines.
|
|
Previously this was only using the last line.
|
|
Make it more obvious which class was unsatisfied to produce this error
message.
|
|
Or how many taps are private when summarizing all installed taps.
|
|
|
|
Closes #488.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
|
|
|
|
Fix minor regression in b55250c44eacd49646407b26a73753965d4d36d0. The
bottle is placed in the current working directory, is unaffected by the
the single teardown introduced in #475, and thus needs manual handling.
Closes #483.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
The latter was replacing the former due to an identical method name.
|
|
Test was added in 61614d35294c8faffaeb5c7f0ec6dea78dbbc30f, but never
had any effect because it was replaced by a method of the same name a
few lines further down.
|
|
Closes #481.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
We might as well be consistent about it, since it's not obvious to people
what the next step is after we've pointed out the directory isn't writable.
Fixes #476.
|
|
and download-mirror.savannah.gnu.org
|
|
|
|
|
|
|
|
|
|
|
|
* readall: move readall logic to new class.
* tap: run readall when tapping.
This will prevent tapping an tap with syntax errors from causing issues
for users.
Fixes #58.
|
|
Including the extension is not an error, but we don't normally do this.
|
|
|
|
Autoupdate has been working well for me/opt-in folks for a while so lets
enable it for Homebrew developers to test before we enable it for
everyone.
|
|
Instead of writing a custom ensure for every test let's just nuke
all the files every time. This may be something we might want to use for
other unit tests too. It leans heavily on the fact that a
`FileUtils.rm_rf` on files that don't exist is very quick and things
like `brew cleanup` are super slow in comparison.
Before:
```
$ brew tests --only=integration_cmds --official-cmd-taps
Finished in 49.764724s, 1.0047 runs/s, 5.2648 assertions/s.
```
After:
```
$ brew tests --only=integration_cmds --official-cmd-taps
Finished in 43.014769s, 1.1624 runs/s, 5.8352 assertions/s.
```
|
|
linkage: don't conflate broken and undeclared
|
|
The `build` and `source_modified_time` arguments are always coming from
the matching attributes of the `Formula` instance. Thus query `formula`
for them instead of passing them individually.
|
|
This reverts commit 080ddd8804be14f4b18f9558b58270456ff313c2.
|
|
This reverts commit 310d7067e01952cdcefe8b2c877bc4c792654de2.
|
|
* Don't infinitely recurse `brew update --preinstall`.
This could happen when trying to `brew install git` inside `brew update
--preinstall`.
* update.sh: cache Git PATH.
We don’t need to look it up from superenv every time; this is slow.
* update.sh: print message before preinstall updates.
* update.sh: verbose output fetch directory.
This aids reading `brew update --verbose --debug` output.
* update.sh: skip taps without formulae on preinstall.
We don’t need to update them as we’re not invoking them.
* update.sh: don't force update-report on developer preinstall.
This is too slow.
|
|
The length of the commit hash returned for `--short` can vary depending
on user configuration. Make sure this works independently of what might
have been configured via a user's `.gitconfig`. This also fixes the
failing `GitDownloadStrategyTests#test_last_commit` test for such users.
|
|
Closes #464.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
|
|
Add an extension for accessing Git-related meta data that can be mixed
in into a Pathname object (e.g. `HOMBREW_REPOSITORY` or the path of a
`Tap` instance). The goal here is to eliminate code duplication.
|
|
Remove an exact duplicate from further up in the same file. (It was
accidentally added in 8a582f2bd976ce7044c3b2dc6eef701f94b9ace5.)
|
|
|
|
|
|
|
