aboutsummaryrefslogtreecommitdiffstats
path: root/Library
AgeCommit message (Collapse)Author
2016-04-17man: pipe markup to 'ronn' to avoid temporary fileMartin Afanasjew
2016-04-17man: refactor and fix code styleMartin Afanasjew
Split monolithic method into more manageable chunks and fix code style.
2016-04-17list: exclude zsh completions from unbrewedMartin Afanasjew
Since edf000e4cd30c3626ccc28c52ed32f2d84a200dd `zsh` completions are in `share/zsh/site-functions/_brew`, making this path a part of Homebrew. Hide it from `brew list --unbrewed` to reduce confusion/noise.
2016-04-16tests: ensure desc prints short name only if there are conflictsJosh Hagins
Fixes #70. Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2016-04-16audit.rb: Base desc length check on short nameCory Donnelly
Currently, brew audit --strict includes the name of the tap when calculating the length of a formula's description. This makes it difficult to pass the audit for formulas in taps with lengthy names. In #47033 @jawshooah called out head-only or devel-only taps specifically, but this is an issue elsewhere. For example: homebrew/versions/elasticsearch20: Distributed search & analytics engine (72) This commit updates audit.rb to use formula.name rather than formula.full_name. Closes #47033 -- Audit shouldn't include tap name in description length
2016-04-16desc: print short name unless multiple formulae have the same nameJosh Hagins
2016-04-16test-bot: update for new deps/uses optionsXu Cheng
Closes #92. Signed-off-by: Xu Cheng <xucheng@me.com>
2016-04-16update manpage for deps/usesXu Cheng
2016-04-16uses/deps: default to skip optional/build deps.Xu Cheng
Also add options to include optional/build deps and an option to skip recommended deps. Closes Homebrew/legacy-homebrew#50066.
2016-04-16analytics: add more documentation, Linuxbrew ID. (#98)Mike McQuaid
2016-04-14style: use rubocop 0.39Dominyk Tiller
(#85)
2016-04-13superenv: fix formula prefix path to consider revisionsAndrew Janke
Old logic doesn't include revision. This fixes that, and passes the whole formula prefix path to avoid duplicating the path-construction logic. Closes #80. Signed-off-by: Andrew Janke <andrew@apjanke.net>
2016-04-13superenv: allow paths under self's kegAndrew Janke
Fixes build error in Homebrew/homebrew-core#100. Closes #63. Signed-off-by: Andrew Janke <andrew@apjanke.net>
2016-04-12Document disabling of opt-in Homebrew analytics. (#79)Mike McQuaid
2016-04-12tap: various improvements (#77)Xu Cheng
* make `read_or_set_private_config` private * add doc * add test
2016-04-12update: use official GitHub SHA API. (#75)Mike McQuaid
This is coming out of preview shortly so use the new API content-type.
2016-04-12Homebrew (opt-in) Analytics tweaks. (#57)Mike McQuaid
- add `HOMEBREW_PRODUCT` global variable - only differentiate between `/usr/local` and `non-/usr/local` Homebrew prefixes to avoid sharing sensitive user information - note if e.g. build errors are occurring under CI - Add `HOMEBREW_NO_ANALYTICS` variable (this will be how people opt-out when this is enabled for everyone) - Add `HOMEBREW_ANALYTICS_DEBUG` variable to output all the analytics that are sent - Move Bash analytics code to `Library/Homebrew/utils/analytics.sh` - Add documentation for our analytics and why/what/when/how and opt-out - Only official Homebrew commands are reported - Ruby analytics are now reported in a forked, background process
2016-04-12Cache `Tap#private?` checks.Mike McQuaid
Use both an in-class and a `.git/config` cache for this so we can ensure that the `Tap#private?` check is fast. Also, make sure this cache value is set both when initially installing and updating a tap. Thanks to @xu-cheng for most of the implementation here.
2016-04-12help: support highlighted outputXu Cheng
Closes #68. Signed-off-by: Xu Cheng <xucheng@me.com>
2016-04-12help: handle aliasXu Cheng
Before this fix ``` $ brew --help ls Error: Unknown command: ls ``` After this fix ``` $ brew --help ls brew list, ls <snip> ```
2016-04-11Auto-update when running `brew install`/`upgrade`.Mike McQuaid
Also, slightly tweak the behavior of `brew update` in this case so that it doesn't print annoying output and still allows the `brew edit` flow for people with `HOMEBREW_DEVELOPER` set.
2016-04-10brew.rb: adjust behavior for undocumented commandsMartin Afanasjew
Don't exit with a non-zero status code just because an internal command happens to be undocumented. Also print the generic help in these cases to provide some help (including a reference to the man page).
2016-04-10Fix documentation errorMax Nordlund
Closes #10. Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
2016-04-10Generate the new man pageMax Nordlund
2016-04-10Add all the top level commentsMax Nordlund
2016-04-10Implement the `brew help` commandMax Nordlund
This is also used by `brew <cmd> --help`. The basic idea is to have the documentation as a top level comment in each command file. To find these comments, they have to be like this `#:`. This is also used by the `brew man` command to keep the documentation DRY, and for that there are now a header and footer for the man page.
2016-04-10xcode: expect 7.3 on 10.11Dominyk Tiller
xcode: expect 7.3 on 10.11
2016-04-09diagnostic: fix style of previously skipped methodMartin Afanasjew
Fix style of previously omitted `check_for_bad_install_name_tool` method to be in line with changes made in #49. Closes #56. Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
2016-04-09Revert "diagnostic: improve check for 'install_name_tool'"Martin Afanasjew
This reverts commit 9f79c05656a44f926898774c6029025002bcd621. Restore check to continue to inspect `/usr/bin/install_name_tool`. See Homebrew/legacy-homebrew#50091 and Homebrew/legacy-homebrew#50509 for the full context and more details.
2016-04-08diagnostic: prefer guard clauses for readabilityMartin Afanasjew
Guard clauses instead of if/unless blocks make the checks easier to understand and reduce nesting, thus improving overall readability. This includes the following additional minor changes: - Make indentation of commands consistent inside diagnostic messages. - Fix minor typos and inconsistent punctuation in diagnostic messages. - Fix here documents to always start with `<<-EOS.undent` on a new line, followed by the message (indented once), followed by `EOS` (at the same level like `<<-EOS.undent`). - Always separate the check logic (and guard clauses) from the following message by a single empty line (for consistency and readability). - Standardize on `message` as the variable name when diagnostic messages need to be constructed from multiple parts. - Where easily possible, adapt check logic to stay within 80-column limit, use more expressive variable names, and break down long expressions into multiple statements with intermediate results. Closes #49. Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
2016-04-08brew.sh: make sure to always use system 'awk'Martin Afanasjew
This should prevent issues like #47 and make us more resilient.
2016-04-08scm/git: prevent exec bomb with 'env :userpaths'Martin Afanasjew
Using `git` from `Formula#install` can cause an exec bomb if used in a formula with `env :userpaths` because that causes both `Library/ENV/4.3` and `Library/ENV/scm` to be in PATH, both of which contain a `git` binary that is the same SCM wrapper. Those will mutually exec each other indefinitely as they fail to detect that they are the same wrapper. Extend the exec-bomb protection to check the paths after all symbolic links have been expanded to prevent this situation. Fixes #43. Fixes Homebrew/homebrew-core#133. Fixed Homebrew/homebrew-core#143. Closes #46. Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
2016-04-07remove legacy Aliases/Formula symlink from LibraryMartin Afanasjew
2016-04-07curl: fall back to /usr/bin/curl when HOMEBREW_CURL doesn't existXu Cheng
This can happen when `HOMEBREW_CURL` is set to brewed curl, but during `brew resinstall curl`, brewed curl's symlink is temporary unlinked. So let's fallback to /usr/bin/curl in this case.
2016-04-07brew.sh: tweak HOMEBREW_PROCESSOR on LinuxMartin Afanasjew
`uname -p` seems to be less useful on Linux (Debian 8 yields `unknown`), thus prefer `uname -m` on those systems to determine the processor type. Closes #35. Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
2016-04-07brew.sh: fix HOMEBREW_OS_VERSION on Linux et al.Martin Afanasjew
On Linux (and other non-OS X platforms), `HOMEBREW_OS_VERSION` was *always* replaced with the product name, leading to less useful user agent. E.g., on a reasonably up-to-date Debian system: Linuxbrew/0.9.9 (Linux; unknown Linuxbrew) With this fix the user agent is instead (first if `lsb_release` is available and outputs something, second otherwise): Linuxbrew/0.9.9 (Linux; unknown Debian GNU/Linux 8.3 (jessie)) Linuxbrew/0.9.9 (Linux; unknown 3.16.0-4-amd64)
2016-04-07brew.sh: avoid unnecessary 'cat'Martin Afanasjew
Bash can read directly from a file in its command substitution.
2016-04-07brew.sh: simplify HOMEBREW_OSX_VERSION_NUMERICMartin Afanasjew
Use `printf -v` and strip out the unnecessary `echo`, thus avoiding two unnecessary command substitutions.
2016-04-07brew.sh: streamline setting HOMEBREW_{OSX,LINUX}Martin Afanasjew
For uses like this one, `case` is much more compact and easier to read.
2016-04-07analytics: avoid unnecessary string interpolationMartin Afanasjew
2016-04-07always prefer HOMEBREW_CURL over plain 'curl'Martin Afanasjew
2016-04-06superenv: comment sources of ignored pathsMisty De Meo
Closes #32. Signed-off-by: Misty De Meo <mistydemeo@github.com>
2016-04-06superenv: don't filter out all /opt pathsMisty De Meo
This was intended to filter out MacPorts and X11 paths, but the user may have valid reasons to have other things here that might get linked against.
2016-04-06test-bot: add safety margin to output truncation sizeAndrew Janke
2016-04-06test-bot: stop using --recursive for `brew uses`Dominyk Tiller
We're not sure this is working as it was intended to, and the primary end product so far has been making every Ruby 1.8.7 build, which is the Ruby we use on Mavericks for compatibility, take 5-15 minutes longer per build than 2.x Rubies. Cumulatively this is responsible for the vast majority of CI slowness over the last couple months as Mavericks plays catch-up and everything else waits for it to do so. We may revisit this in future, but for now the harm is greater than the "risk". This technically reverts https://github.com/Homebrew/brew/commit/7b26c585c2a26ec0dad201852ca4934c77fcc493.
2016-04-06tests: update prune --verbose testMartin Afanasjew
Closes #15. Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
2016-04-06tests: update linkapps/unlinkapps testsMartin Afanasjew
2016-04-06prune: handle broken app symlinksMartin Afanasjew
Remove broken symlinks from `/Applications` and `~/Applications` that were previously created by `brew linkapps`, but are no longer valid because formulae were uninstalled or the provided apps have changed.
2016-04-06unlinkapps: add --dry-run optionMartin Afanasjew
Add `--dry-run` option as is customary for destructive commands. Update `bash` completion and man page accordingly. Also correct and update documentation for both `brew linkapps` and `brew unlinkapps` in more general terms.
2016-04-06unlinkapps: modernizeMartin Afanasjew
Simplify code by using `Pathname` methods as much as possible. Also avoid calling external commands for basic functionality like unlinking, reduce code duplication by using a method from `cmd/linkapps.rb`, count unlinked symlinks with `ObserverPathnameExtension`, and adjust output for consistency with `brew linkapps`.
generated by cgit v1.2.3 (git 2.25.1) at 2026-03-05 22:27:10 +0000