| Age | Commit message (Collapse) | Author |
|---|
|
The new check also allows the `+` operator instead of our (still heavily
preferred) `/` operator for path concatenation and also triggers if the
operator is surrounded by whitespace.
Also recognizes single-quoted strings and uses a back reference to
match the closing quote for a slightly lower chance of false positives.
Closes #322.
|
|
git stash pop -q will print "Already up-to-date!" if untracked changes
are being poppped. This quiets it down unless verbose is set.
Closes #320.
Signed-off-by: ilovezfs <ilovezfs@icloud.com>
|
|
|
|
`Formula#keg_only?` could fail if it was invoked on a formula with a
`:provided_until_xcode43` or `:provided_until_xcode5` reason given to
`keg_only`, if neither the Command Line Tools nor Xcode was installed.
Check whether Xcode is installed before querying the Xcode version.
Closes #317.
|
|
|
|
|
|
Always pop stashed changes for Homebrew developers and only checkout
original branches for them (to avoid users who don't understand Git
ending up "stuck" on branches).
|
|
Closes https://github.com/Homebrew/homebrew-core/issues/1687.
|
|
|
|
* Move GitHub API module to utils/github.rb.
* Move curl method to utils/curl.rb.
* global: use long curl arguments and an array.
This makes the code more self-documenting.
* utils/curl: support reading curl's output.
* utils/github: use curl instead of open-uri.
It has far better proxy support.
* pull: set Homebrew user agent.
* gist-logs: remove trailing whitespace.
* gist-logs: use first instead of [0].
Easier to read.
* gist-logs: use curl-based GitHub.open method.
|
|
When a given dependency appears multiple times in a formula's dependency
tree, the inherited options for that dependency should accumulate rather
than being overwritten each time that dependency is considered by
expand_dependencies. In particular, this impacts "universal" since the
dependency should be built with universal unless all of its instances in
the dependency tree don't have "universal" as opposed to only if the last
instance considered has "universal."
Closes Homebrew/homebrew-core#1604.
Closes #308.
Signed-off-by: ilovezfs <ilovezfs@icloud.com>
|
|
Amends e4d0187120e61bc80d31ebecc3b38f0740b20bb5. The `require` was
accidentally omitted causing the tests to fail very sporadically (or
always, when invoked as `brew tests --only=integration_cmds`).
|
|
Should help with being more consistent and makes sure to suggest the
HTTPS redirector even if equally valid HTTP URLs for specific hosts or
`central.maven.org` are used.
|
|
|
|
|
|
If the deletion of `HOMEBREW_CACHE` fails then the
`.migration_attempted` file will have still been deleted so ensure it is
recreated.
|
|
It defaults to being in $HOME but we override this meaning that we would
destroy the cache every time.
|
|
|
|
|
|
* cleanup: accept cache as an argument.
* config: move default HOMEBREW_CACHE to ~/Library.
* brew.1: document new default Homebrew cache.
* update-report: migrate legacy Homebrew cache.
|
|
Prior to this change there were only 3 instances of `STD(IN|OUT|ERR)`
versus 74 instances of `$std(in|out|err)` in the Homebrew code base. The
latter variant is also strongly suggested by bbatsov's Ruby Style Guide.
|
|
Some elements already used two-space indentation and we also prefer two
spaces in our Ruby code.
Closes #306.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
|
|
Some Git versions create absolute `gitdir:` pointers in a submodule's
`.git` file, which can be problematic once the resource is staged and
causes various Git operations for those submodules to fail. Work around
this issue by fixing the submodule `.git` files after submodule update.
See Homebrew/homebrew-core#1520 for details and an affected formula.
|
|
Closes #302.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
The FTP protocol is prone to getting firewalled to death in places, so where
we know we can avoid that by using either secure or more commonly accepted
protocols let's do so.
Examples of output:
```
* Stable: ftp://ftp.cpan.org/pub/CPAN/authors/id/N/NE/NEILB/Time-Duration-1.20.tar.gz should be `http://search.cpan.org/CPAN/authors/id/N/NE/NEILB/Time-Duration-1.20.tar.gz`
* Stable: Please use https:// for ftp://ftp.mirrorservice.org/sites/lsof.itap.purdue.edu/pub/tools/unix/lsof/lsof_4.89.tar.bz2
```
|
|
mirrorservice accepts `http://ftp.mirrorservice.org` as well, apparently.
|
|
|
|
This reverts commit 7bbcf9cacc18aabf78a21ec5cc5892d440631e08.
|
|
This reverts commit 146a16d66bc796f0c6a4c7e2b88f1b73fb0aaa4c.
|
|
|
|
|
|
You need a non-shallow clone to push branches upstream so if you often
tap and untap taps (e.g. `homebrew/boneyard`) then you need to remember
to manually `fetch -unshallow`.
|
|
Check the syntax for Homebrew/brew and don't bother for taps.
|
|
This is not a command designed for end-users.
|
|
This will almost certainly fail every time so let's disable this error.
|
|
Based on how it's used to construct URLs, the bintray "package" should
be the formula name not the formula full_name. For core formulae, there
is no difference, but that's not the case in other taps.
See https://github.com/Homebrew/homebrew-gui/pull/10
Closes #301.
Signed-off-by: ilovezfs <ilovezfs@icloud.com>
|
|
As mentioned in:
https://github.com/Homebrew/homebrew-core/pull/1396#discussion_r64774080
|
|
|
|
|
|
This adds >1m to every build on every node and it can't actually be
affected/fixed by formula PRs.
|
|
|
|
|
|
There's no more pull requests left to pull on this repository.
|
|
This job takes almost a minute and it's not useful for all core taps
to run this.
|
|
We're not really getting any more PRs here and this code makes this file
harder to follow and refactor.
|
|
|
|
|
|
This means that we do not need to read formulae or evaluate Ruby at
upload time.
|
|
Both the `CctoolsMachO` and `RubyMachO` module implement a common set of
methods that simplify querying `mach_data`. Move these into a shared
module, that gets included after either of these implementations is
loaded and included in `Pathname`.
|
