aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew
AgeCommit message (Collapse)Author
2014-02-20Delegate downloader to active_spec instead of storing it in an ivarJack Nagel
2014-02-20Consistently pass path into Formula constructorJack Nagel
2014-02-19Pass path into the Formula constructorJack Nagel
When the path argument to the Formula constructor is omitted, the instance's path attribute is created using the Formula.path class method. However, we have already done this work, so we can just pass it into the constructor. This translates to one less call to Pathname#to_s per formula, or about 2600 calls when running `brew readall`.
2014-02-19Eliminate some Pathname -> String -> Pathname conversionsJack Nagel
2014-02-19Push expand_path call down into FromPathLoaderJack Nagel
2014-02-19Fix building universal binaries on 32-bit CPUscadrpear
[jn: style, update comment] Closes Homebrew/homebrew#25728. Fixes Homebrew/homebrew#26834. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-02-18Stop exporting HOMEBREW_VERBOSE to build environmentJack Nagel
This flag no longer affects the output of the compiler wrappers, since everything is buffered by the build process rather than each individual tool. Additionally, this is a user-facing knob that affects ARGV.verbose?, and the combination of these two issues broke the --quieter feature.
2014-02-18Use standard curl progress output in verbose modeJack Nagel
Closes Homebrew/homebrew#26818.
2014-02-18Tweak DownloadError message to include wrapped exceptionJack Nagel
2014-02-18Collapse begin..end into def..end and use else clauseJack Nagel
2014-02-18Add DownloadError to catch a broader range of resource download errors.Drew Rodman
Adding a broader exception class allows for errors raised in Resource.fetch to be caught in upgrade and prevent the process from being killed when a download fails. This should resolve issue 18364. Fixes Homebrew/homebrew#18364. Closes Homebrew/homebrew#26618. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-02-18Inline static exception text to remove a rescueJack Nagel
2014-02-16search: use a queue to collect errorsJack Nagel
The threading in the tap search code makes handling errors difficult. If an API-related error is raised in one thread, it is likely to be raised in each of the rest as well. This results in duplicated error messages, which is ugly and bad UX. This patch adds a synchronized queue to collect these exceptions. The first one added to the queue is re-raised after all operations are complete. It's not ideal, but it's minimally invasive and I don't have the energy or time to do a rewrite.
2014-02-16Add helpful error message for authentication failuresJack Nagel
2014-02-16Move error text and helper into error classJack Nagel
2014-02-16Add a more useful message when ratelimit is exceededJack Nagel
2014-02-16Make GitHub::Error a RuntimeError to suppress backtraceJack Nagel
2014-02-16Handle GitHub API authentication failuresJack Nagel
2014-02-16Extract error handling from GitHub.openJack Nagel
2014-02-16audit: handle recommended/optional options better.Mike McQuaid
2014-02-16audit: whitelist pyobject3 use of ARGV.Mike McQuaid
2014-02-16versions: ignore validation errors.Mike McQuaid
References Homebrew/homebrew#26748.
2014-02-15Formula#system: simplify xcodebuild special caseJack Nagel
2014-02-15Formula#system: remove unnecessary string castsJack Nagel
2014-02-15bottle: fail if there is no stable version.Mike McQuaid
Closes Homebrew/homebrew#26742.
2014-02-15GitDownloadStrategy: fix typo'd parameter nameJack Nagel
This should be "resource", not "resources", though it works anyway because there is a also "resource" reader method.
2014-02-14ARGV.help?: anchor to end of stringMisty De Meo
Fixes Homebrew/homebrew#26735.
2014-02-14GitDownloadStrategy: allow disabling of shallow cloneJack Nagel
Closes Homebrew/homebrew#25751. Closes Homebrew/homebrew#26730.
2014-02-14VCSDownloadStrategy: use REF_TYPES when extracting ref to useJack Nagel
2014-02-14VCSDownloadStrategy: document acceptable ref typesJack Nagel
2014-02-14GitDownloadStrategy: inline simple methodJack Nagel
2014-02-14GitDownloadStrategy: move constant to top of class bodyJack Nagel
2014-02-14brew: check for --help and friends in more of ARGVMike McQuaid
Let's check for e.g. --help anywhere in the ARGV array rather than just the first value to avoid brew upgrade --help causing problems. Closes Homebrew/homebrew#26675. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-02-13Use a more accurate method name and drop unhelpful blockJack Nagel
2014-02-13Always print top-level issue URLJack Nagel
2014-02-13Delete comment that isn't relevant to this code anymoreJack Nagel
2014-02-13Offload more filtering to the search APIJack Nagel
2014-02-13Allow passing arbitrary qualifiers to issue searchJack Nagel
2014-02-13Implement equality for Dependencies collectionsJack Nagel
2014-02-13Eliminate unnecessary arrays and call to flattenJack Nagel
2014-02-12Delete unused methodJack Nagel
2014-02-12Pass the string instead of reconstructing it from a regexpJack Nagel
2014-02-12Let the API do more work for usJack Nagel
2014-02-12Drop TODO that nobody has ever worked onJack Nagel
2014-02-12Drop unnecessary type check, we never pass a Formula instanceJack Nagel
2014-02-12Return only open issues in GitHub.issues_for_formulaJack Nagel
2014-02-12osmium: add to blacklist.Mike McQuaid
References Homebrew/homebrew#12652.
2014-02-11Revert "Recognize --head as an alias for --HEAD"Adam Vandenberg
This reverts commit c32ab0a35a2dfa9b593f759ef0ae8b7af077b0b7. There are other hard-coded uses of HEAD, in build_options for instance. These all need to be fixed before enabling this.
2014-02-10python_dependency: only set PYTHONPATH for system.Mike McQuaid
2014-02-10Update vendored OkJsonJack Nagel