| Age | Commit message (Collapse) | Author |
|
When fixing references to regular dylibs, it is sufficient to search for
a file with the same base name, e.g., `libpoppler.56.dylib`. However, if
the broken reference is to a framework, we also have to take into
account preceding path components to find a suitable match. Framework
references (according to the `dyld` man page) come in two flavors:
- `XXX.framework/Versions/YYY/XXX` (with version)
- `XXX.framework/XXX` (without version)
The change here is to detect these patterns and to make sure that the
fixed library reference has the same suffix as the broken one.
Prior to this fix, a broken framework reference (if originating in a
sister framework) to `QtXml.framework/Versions/5/QtXml` would have been
rewritten to `<qt5-keg>/lib/QtXml.framework/QtXml`. In practice, this
mostly works, but is technically incorrect and thus creates problems
like in Homebrew/homebrew#42191. With this fix, the framework reference is correctly
rewritten to `<qt5-keg>/lib/QtXml.framework/Versions/5/QtXml`.
Closes Homebrew/homebrew#45494.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Necessary to allow system Python to find Python modules installed by Homebrew.
Closes Homebrew/homebrew#45076. Fixes Homebrew/homebrew#43919. Probably fixes Homebrew/homebrew#44813.
|
|
Closes Homebrew/homebrew#45611.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
Closes Homebrew/homebrew#45574.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
|
|
|
|
Closes Homebrew/homebrew#45676.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Closes Homebrew/homebrew#45637.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
Closes Homebrew/homebrew#45658.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
Closes Homebrew/homebrew#45618.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Fixes Homebrew/homebrew#45623.
|
|
|
|
Fixes Homebrew/homebrew#45596.
|
|
Closes Homebrew/homebrew#45567.
Signed-off-by: Alex Dunn <dunn.alex@gmail.com>
|
|
Require that the subdirectory in site-lisp match the formula name
exactly. This lets us provide better information in the caveats and
will make it easier for helper methods to write to the correct
location (as in in Homebrew/homebrew-emacs#13).
|
|
The order ought not to matter, but GCC can fail with -arch i386 -arch
x86_64 (producing an error like "FATAL:Bad fx_size (0x8) in
fix_to_relocation_info()") but succeed with -arch x86_64 -arch i386.
Closes Homebrew/homebrew#45401.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Closes Homebrew/homebrew#45569.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
|
|
|
|
Fixes Homebrew/homebrew#45575
Closes Homebrew/homebrew#45577.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
|
|
|
|
Use one of the Travis CI default environment variables:
http://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables
Closes Homebrew/homebrew#44446.
Closes https://github.com/travis-ci/travis-ci/issues/4936.
Closes Homebrew/homebrew#45561.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Closes Homebrew/homebrew#45563.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
It made less sense to call a method `java_version` when it returns
boolean value.
Closes Homebrew/homebrew#45501.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
The Emacs shell sets $EMACS to "t" for detection purposes, but it causes
builds to fail when they attempt to call Emacs using the variable.
Fixes Homebrew/homebrew-emacs#30.
Closes Homebrew/homebrew#45495.
Signed-off-by: Alex Dunn <dunn.alex@gmail.com>
|
|
Closes Homebrew/homebrew#45398.
|
|
The previous version didn’t work with descs like:
"TheFormula serves a web page"
|
|
Closes Homebrew/homebrew#45465.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Closes Homebrew/homebrew#45492.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Closes Homebrew/homebrew#45493.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Closes Homebrew/homebrew#45443.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Fixes Homebrew/homebrew#45414
Closes Homebrew/homebrew#45420.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
see Homebrew/homebrew-emacs#29
Closes Homebrew/homebrew#45426.
Signed-off-by: Alex Dunn <dunn.alex@gmail.com>
|
|
Closes Homebrew/homebrew#45254.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
Fixes Homebrew/homebrew#45310.
Closes Homebrew/homebrew#45336.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Feature it a bit more prominently in the documentation as a result.
Closes Homebrew/homebrew#45374.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
There's been a few issues where users have been confused about these
errors. They may have modified stuff but we probably don't care about
telling them that unless we're debugging other issues.
Closes Homebrew/homebrew#45373.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Closes Homebrew/homebrew#45337.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Until a point in time when the Cask/Homebrew codebases are harmonised a little
more it probably makes sense to refuse to `cat` Casks. Right now the Homebrew
codebase is only minimally aware of what a Cask is.
Fixes Homebrew/homebrew#45300.
Fixes Homebrew/homebrew#44630.
Closes Homebrew/homebrew#45302.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
`Pathname#children(with_directory = false)` doesn't filter directories,
instead it returns path with basename.
Closes Homebrew/homebrew#45325.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Closes Homebrew/homebrew#45266.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
* Checks for placement of the bottle modifier variable.
* Checks there isn't a bottle modifier and a bottle do block - The former makes
the latter redundant.
Closes Homebrew/homebrew#45146.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
|
|
Closes Homebrew/homebrew#45263.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
This prevents typos like `bottle :uneeded` or `bottle :disable`
Closes Homebrew/homebrew#45264.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
Provide `OS::Mac.prerelease?` for pre-release checks and use it where
appropriate. This should simplify updating the test once a new OS X
release lands.
This also fixes a bug in `BuildError#dump`, where an empty warning
message was printed on El Capitan after a failed from-source build,
because the check there and the one in `check_for_unsupported_osx` were
out of sync.
Closes Homebrew/homebrew#45257.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|