| Age | Commit message (Collapse) | Author |
|
- Name of the brewed formula in "Summary" heading.
- At the beginning of the summary line a 🍺 is given out
(but only on Lion or above). This acts as a nice
visual marker for the end of a brew-ing process.
- When brewing a dependency, the name is highlighted in green.
- `oh1` is bold, too (like ohai).
Closes Homebrew/homebrew#16020.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
When a dependency of a formula specified on the command-line is also
specified, *after* the dependent formula, installation proceeds as part
of the dependent's dependency tree and then is attempted again because
the user asked for it explicitly. This results in the installer raising
a CannotInstallFormulaError because it has already been installed.
For example:
$ brew install graphviz pkg-config
==> Installing graphviz dependency: pkg-config
...
==> Installing graphviz
...
Error: pkg-config-0.27.1 already installed
We already have a mechanism for dealing with this, but it does not kick
in early enough. Move the installation attempt check into
FormulaInstaller#check_install_sanity and catch the exception in the
appropriate places.
Fixes Homebrew/homebrew#16957.
|
|
Closes Homebrew/homebrew#16409.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
|
|
|
|
|
|
Procs cannot be marshalled, but formula objects may be as part of the
BuildError exception. If the formula object has a reference to a Proc,
this will fail.
Work around it by not storing the test Procs during installations.
|
|
Ruby 1.8.6 doesn't have Symbol#to_proc, which allows things like
map(&:to_s) rather than map { |o| o.to_s }. 1.8.7 does, though, and
since it is used in a bunch of the superenv code we should attempt to
keep it compatible with 1.8.6.
Closes Homebrew/homebrew#16046.
|
|
`python --version` doesn't work in some (very) old versions of
python. While I doubt this is going to come up very often, it's
theoretically possible someone has an old python first in their
path. (python -V works on all versions I'm aware of, including
python3, and comes before --version in the --help anyway.)
Also skips the warning in case the regexp matches nothing, which
probably shouldn't happen. But if it does we shouldn't produce the
wrong warning.
|
|
|
|
|
|
Closes Homebrew/homebrew#16947.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
|
|
Fixes Homebrew/homebrew#16948.
|
|
|
|
This is needed for the intersection code in `brew deps` to work right,
but can hopefully be refactored away somehow eventually.
|
|
|
|
Inheriting from Array (and other core types) is problematic:
- It exposes a very wide interface with many methods that are not
really relevant to the subclass.
- It can cause some weird side effects, as many Array operations are
in C and have hardcoded return values; for example, combining two
array subclasses returns a new Array instead of the subclass.
Avoid these problems using delegation and the Enumerable module where
applicable.
|
|
|
|
|
|
Tests can now be specified as a block in the DSL. A temporary test
directory is set up automatically when calling Formula#test. The
semantics of the test remain the same: the block can either raise an
exception or return false to signal failure.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
|
|
|
|
Closes Homebrew/homebrew#16280.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
|
|
Closes Homebrew/homebrew#16901.
|
|
|
|
|
|
Superenv scripts have a stripped PATH, which may not include
the brew binary itself. Make this explicitly available to
superenv scripts.
Fixes bsdmake wrapper.
Closes Homebrew/homebrew#16805.
Closes Homebrew/homebrew#16846.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
|
|
Fixes Homebrew/homebrew#16857.
|
|
Probably a better approach than reverted e721c7.
Fixes Homebrew/homebrew#16604.
|
|
|
|
|
|
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
|
|
Xcode.prefix and Xcode.installed? use slightly different heuristics to
find Xcode. In fact, .installed? basically duplicates a portion of the
.prefix logic. In practice, the methods results are usually consistent,
but .installed? does not handle non-standard prefixes if mdfind cannot
locate Xcode (for example, if the user has disabled Spotlight indexing).
Since .installed? is essentially a subset of the .prefix logic, we can
rely on the result from .prefix instead.
Fixes Homebrew/homebrew#16790.
|
|
|
|
@sceaga has discontinued his homebrew fork, so tigerbrew is now PPC/
Tiger users' best bet.
|
|
Originally written for tigerbrew, but useful enough for core.
Replaces the shelled-out which in utils.rb with a native-ruby
equivalent, which is moderately faster.
Closes Homebrew/homebrew#16659.
Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
|
|
|
|
|
|
|
|
c.f. Homebrew/homebrew#16296.
|
|
|
|
|
|
c.f. Homebrew/homebrew#16688.
|
|
|
|
|
|
|
|
|
|
|
|
Fixes Homebrew/homebrew#16655.
|
|
Two issues were preventing `brew upgrade` from functioning properly:
- `Tab.for_formula` was used to recover options from prior installs. The
problem is that during an upgrade `for_formula` will be directed to a
non-existant install of the newer version and thus returns a forged tab
claiming no options were invoked.
- The assignment to `installer.install_bottle` requires parenthesis in order
to function properly.
|
|
closes Homebrew/homebrew#15853.
|