| Age | Commit message (Collapse) | Author |
|
|
|
The API used (`Net::HTTP::Post`) does not handle basic authentication
credentials in the same way as `open` so fix both cases so they work.
Also, do some general usability tweaks to point out to people what could
be wrong with their tokens or credentials to help them debug.
Closes Homebrew/homebrew#50410.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Fixes Homebrew/homebrew#50050. Closes Homebrew/homebrew#50059.
|
|
- Use empty array when `git credential-osxkeychain` lookup fails to
cache and avoid rerunning it when there's no valid results.
- Redirect `stderr` to avoid printing errors when there's a failure
or no `git credential-osxkeychain` installed.
Closes Homebrew/homebrew#49954.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Closes Homebrew/homebrew#49882.
|
|
As requested in Homebrew/homebrew#46578. Falls back to existing functionality.
Closes Homebrew/homebrew#46578.
Closes Homebrew/homebrew#49846.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
This avoids crashing with an unknown key error, if the GitHub api
response does not contain the ratelimit headers, e.g. when GitHub is
down. It also tries to display the JSON error message in addition to
the HTTP status.
Closes Homebrew/homebrew#48538.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Particularly the `bundler` Gem requires the right Ruby binary to be in
the PATH to work correctly if the Ruby binary used to run Homebrew is
overridden via `HOMEBREW_RUBY_PATH` and thus intentionally not prefixed
to the PATH (as that would affect formulae with a Ruby dependency).
The workaround here is to prefix this path only when a Gem is activated
via `Homebrew.install_gem_setup_path!` (currently used in `brew man`,
`brew style`, and `brew tests`).
|
|
Closes Homebrew/homebrew#47646.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
Similar to which, except it returns all of paths where binary is found.
i.e. it's equivalent to `which -a`.
|
|
* Avoid parallel assignment.
* Avoid string manipulation.
|
|
|
|
Also reuse this improved implementation in the GitHub rate limit errors.
Closes Homebrew/homebrew#44721.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Without this the returned string is not as accurate if the method is
called with an int larger than 120.
Closes Homebrew/homebrew#47002.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Across info, search and update.
Closes Homebrew/homebrew#45131.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Setting the environment variable `HOMEBREW_RUBY_PATH` allows one to run
Homebrew with a non-standard Ruby, even one that is not in `PATH`. This
creates the problem that the `gem` in `PATH` might not be the right one
to call, possibly leading to confusing results as the wrong RubyGems
installation is queried/manipulated.
Closes Homebrew/homebrew#46185.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Use one of the Travis CI default environment variables:
http://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables
Closes Homebrew/homebrew#44446.
Closes https://github.com/travis-ci/travis-ci/issues/4936.
Closes Homebrew/homebrew#45561.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
|
|
Closes Homebrew/homebrew#45134.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
|
|
The yellow background made the text unreadable for light-on-dark color
schemes. Fix by making the highlighted text just bold.
Fixes Homebrew/homebrew#45028.
Closes Homebrew/homebrew#45030.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Closes Homebrew/homebrew#44343.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
|
|
|
|
|
|
Closes Homebrew/homebrew#42281.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
It's kinda annoying that quiet_system wasn't really quiet. This commit
fixes that.
|
|
|
|
Two methods:
* `Utils.git_available?` checks whether git is installed.
* `Utils.ensure_git_installed!` installs git for users who don't install
Xcode or CLT.
|
|
And remove the documented stuff from the `example-formula.rb`.
Closes Homebrew/homebrew#43241.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
HOMEBREW_VERSION doesn't change very often; the repository state is more
interesting.
Closes Homebrew/homebrew#41886.
|
|
|
|
Closes Homebrew/homebrew#42354.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Closes Homebrew/homebrew#42190.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Closes Homebrew/homebrew#41832.
|
|
This stuff seems to be taken better when coming from a script rather
than from a human. Feel free to disagree about the specific numbers
chosen here.
|
|
A simple change that allows for easy copy/pasting. Right now if you were to double click on the text it will also inadvertently copy the trailing period. This change will alleviate the unnecessary gymnastics of not capturing the trailing period.
/most_pedantic_pull_request_ever
Closes Homebrew/homebrew#41257.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Closes Homebrew/homebrew#41003.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
|
|
Closes Homebrew/homebrew#39927.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
|
|
Closes Homebrew/homebrew#39626.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Closes Homebrew/homebrew#39620.
|
|
The link for the page that allows creation of API tokens has changed
from /settings/applications to /settings/tokens. Also the wording
on that page calls them "personal access tokens", so update
Homebrew to be consistent with that.
Closes Homebrew/homebrew#39378.
Signed-off-by: Tim D. Smith <git@tim-smith.us>
|
|
Closes Homebrew/homebrew#39214.
|
|
|
|
Closes Homebrew/homebrew#38017.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
Closes Homebrew/homebrew#34647.
|
|
Check the executable is present to give a better error message if it isn't.
Closes Homebrew/homebrew#35541.
|