| Age | Commit message (Collapse) | Author |
|
Closes Homebrew/homebrew#47714.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Closes Homebrew/homebrew#47665.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
|
|
Tests shouldn't fail in case of an unavailable network or a deliberately
disabled access to the GitHub API.
Closes Homebrew/homebrew#47670.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
This tests all possible combinations of alpha, beta, RC, regular, and
patch versions. Also improves code coverage and partitions the version
comparison tests into more uniform chunks.
Closes Homebrew/homebrew#47669.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
|
|
If the test fails above `formula_file`’s definition this line fails
because `formula_file` is `nil`.
Closes Homebrew/homebrew#47663.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Closes Homebrew/homebrew#47484.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
|
|
Fixes this `brew readall` warning:
test_integration_cmds.rb:116: warning: ambiguous first argument; put parentheses or even spaces
|
|
|
|
* Also with test case.
Closes Homebrew/homebrew#47584.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
|
|
|
|
This test wasn't running by default, so we missed that it wasn't
actually being executed - or that it was failing when running in the
testing environment.
As far as I can tell this is not, and has not, been used either in core
or in any tap, third party or otherwise, so just remove the feature and
its test.
|
|
|
|
|
|
Closes Homebrew/homebrew#47454.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Closes Homebrew/homebrew#47404.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
|
|
Also let `cmd_output` capture `$stderr`
Closes Homebrew/homebrew#47383.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Closes Homebrew/homebrew#47280.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Also reuse this improved implementation in the GitHub rate limit errors.
Closes Homebrew/homebrew#44721.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
If the source contains a broken symlink, `brew bottle` would fail for no
good reason when trying to determine the most recently modified
file. To avoid this, we ignore any files for which stat(2) fails.
Closes Homebrew/homebrew#47111.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Closes Homebrew/homebrew#47185.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Closes Homebrew/homebrew#47182.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Closes Homebrew/homebrew#47177.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
|
|
Let's hide implementation detail on where to find core formulae alias
directory. This will benefit future core code and formulae separation.
|
|
Add them for `install`, `bottle`, `uninstall`, `cleanup`.
Closes Homebrew/homebrew#47079.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
While it may suffice to merge string and non-reserved tags by forming a
union of all tags of dependencies of the same name, this approach fails
to work for the reserved tags. These are now merged such that the most
restrictive tag (meaning sometimes an empty tag) is preserved.
The previous behavior caused essential dependencies to be omitted and
builds to fail in response. E.g., multiple `:fortran` dependencies with
tags `[]`, `[:recommended]`, and `[:optional]` would have been expanded
and merged to `"gcc"` with tags `[:recommended, :optional]`, causing it
to be no longer seen as a required dependency.
Closes Homebrew/homebrew#47040.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
The general idea is that merging multiple dependencies of the same name
should produce the strictest tag instead of a (meaningless) union of the
reserved tags. For example, if a dependency is both a `:recommended` and
an `:optional` dependency at different points in the dependency tree,
the resulting merged dependency should be tagged as `:recommended`.
Handle all other reserved tags in the same spirit.
|
|
These tests were using too much semi-global state (instance variables)
and relied unnecessarily on the exact number of calls to `optional?` and
`recommended?` in the `Depedable` module.
|
|
This means that dependencies can be merged but still maintain all
their option names.
Closes Homebrew/homebrew#46916.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
This test will obviously fail but it does mark that the option names
are not being merged correctly.
|
|
|
|
Without this the returned string is not as accurate if the method is
called with an int larger than 120.
Closes Homebrew/homebrew#47002.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
|
|
Closes Homebrew/homebrew#46735.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Do a reset to `origin/master` and then stash but don't pop the stash
after running update (unless you were on a branch). This may be mildly
more annoying for Homebrew developers but means it's easier for our
users who don't understand Git (and particularly when they don't
understand that every tap is a separate Git repository).
Closes Homebrew/homebrew#45825.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Closes Homebrew/homebrew#46468.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
Closes Homebrew/homebrew#46400.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
A formula should be built from source by default if the --cc option is
passed to specify a particular compiler.
Added a test to test_formula_installer: test_not_poured_from_bottle_when_compiler_specified
Modified test_formula_installer to assert that the formula was not poured
from a bottle. Similarly modified test_formula_installer_bottle to assert
that the formula *was* installed from a bottle.
Added an install method to the TestballBottle formula (the same as the
Testball formula's install method) so that the TestballBottle formula can
be "built from source".
Fixes Homebrew/homebrew#46046 - Build from source should be the default behavior if --cc
option is passed
Closes Homebrew/homebrew#46162.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Closes Homebrew/homebrew#45849.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Closes Homebrew/homebrew#43935.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Closes Homebrew/homebrew#44544.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Commit a71d4a9b (PR Homebrew/homebrew#44058) brought support for updating repositories
with a default branch different from master. This fixes the tests broken
by that commit.
Closes Homebrew/homebrew#44135.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
|