| Age | Commit message (Collapse) | Author |
|
Closes Homebrew/homebrew#49031.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Also set atime to mtime, which seems to be a more common practice.
Fixes Homebrew/homebrew#49007
Closes Homebrew/homebrew#49027.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
We allow certain special regex characters in formula names, and if
those aren't escaped when interpolating them into a regex, they'll be
interpreted as special regex characters.
This can cause regex compile errors on Ruby 1.8 (for example, with
"libxml++3", which has nested match characters), and more subtle
matching bugs in general.
Refs an issue surfaced in Homebrew/homebrew#48744.
Closes Homebrew/homebrew#49005.
Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
|
|
Closes Homebrew/homebrew#48943.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
|
|
Closes Homebrew/homebrew#48923.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
|
|
Closes Homebrew/homebrew#48904.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Closes Homebrew/homebrew#48250.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
|
|
We must bump coveralls otherwise we get a conflicting dependency: we use
a patched simplecov v0.11.1 but coveralls 0.8.9 needs simplecov 0.10.x.
|
|
|
|
|
|
Currently HOMEBREW_BREW_FILE is a String, while other of HOMEBREW_*
variables are all Pathname. This commit unifies them all as Pathname,
so it will not cause any confusion.
Closes Homebrew/homebrew#48872.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
This fixes a regression introduced by 3f6a355, which caused
HOMEBREW_BREW_FILE to be unset while running the tests.
Patch provided by Xu Cheng.
|
|
Closes Homebrew/homebrew#48781.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Closes Homebrew/homebrew#48772.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
It makes Travis checks fail on the master.
|
|
Closes Homebrew/homebrew#48785.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
|
|
Closes Homebrew/homebrew#48748.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
The "apply" DSL method can be called from patch-do blocks to specify
the paths within an archive of the desired patch files, which will be
applied in the order in which they were supplied to the "apply" calls.
If "apply" isn't used, raise an error whenever the extracted directory
doesn't contain exactly one file.
The "apply" method can be called zero or more times within a patch-do
block with the following syntaxes supported:
apply "single_apply"
apply "multiple_apply_1", "multiple_apply_2"
apply [array_of_apply]
If apply must be used, a single call using the second syntax above is
usually best practice. Each apply leaf should be the relative path to a
specific patch file in the extracted directory.
For example, if extracting this-v123-patches.tar.gz gives you
this-123
this-123/.DS_Store
this-123/LICENSE.txt
this-123/patches
this-123/patches/A.diff
this-123/patches/B.diff
this-123/patches/C.diff
this-123/README.txt
and you want to apply only B.diff and C.diff, then you need to use
"patches/B.diff" and "patches/C.diff" for the lowest-level apply leaves.
The code was provided by Xu Cheng. Any mistakes are mine.
|
|
Closes Homebrew/homebrew#48674.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
|
|
Closes Homebrew/homebrew#48635.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
This line is necessary if the test fails. If it passes the file won't
exist anymore and shouldn't be removed.
|
|
|
|
Also change the logic a bit to iterate over the individual files per
directory, as having a directory without bash commands will otherwise
pass a literal `*.sh` to `bash -n`, causing it to fail.
Closes Homebrew/homebrew#48323.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
Closes Homebrew/homebrew#48435.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Closes Homebrew/homebrew#48302.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
|
|
While running a command from the integration tests, invoke `.result` to
trigger a save of the result set, but don't call `.format!` to avoid
(re)generating the HTML output with every run. The final output will
still be written once the main unit test run completes.
This significantly speeds up the integration tests, that take about 1/3
less time to complete when not generating the intermediate output.
Closes Homebrew/homebrew#48280.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
Commands executed during integration testing are executed in a separate
process and thus generate a new result set for each command. To avoid
that these results override each other, they need to have a unique
`command_name`. Derive this name from the test class/name and the index
of the command inside that test, resulting in identifiers like
`IntegrationCommandTests#test_prefix.1 brew --prefix`.
Also replaces `TEST_TMPDIR` in the arguments with `"@TMPDIR@"` to get a
cleaner command identifier that is independent of the temporary
directory that changes with every run.
|
|
The filter for `vendor/bundle/` is useless because this directory is
located in `Homebrew/test/` and that one is already filtered. Moreover,
SimpleCov already loads the `bundler_filter` profile (that installs
basically the same filter) in its default configuration.
|
|
Closes Homebrew/homebrew#48192.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
|
|
Closes Homebrew/homebrew#48131.
Signed-off-by: Alex Dunn <dunn.alex@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
Closes Homebrew/homebrew#48268.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Xcode can only provide autotools if it is installed, thus check that
first. Skipping this check will try to compare a `nil` Xcode version to
4.3, the first version of Xcode to not provide autotools.
Fixes Homebrew/homebrew#48208.
Closes Homebrew/homebrew#48278.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
This reverts commit fa43883dd1cd82f234b79c4a322339f03b9c098d.
Closes Homebrew/homebrew#48187.
|
|
|
|
Closes Homebrew/homebrew#47380.
|
|
This will become the default updater at a later point in the future.
|
|
|
|
Closes Homebrew/homebrew#48124.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|