| Age | Commit message (Collapse) | Author |
|---|
|
audit: Port audit_homepage method to rubocop and add tests
|
|
audit: Detect multiline and interpolated strings in formula desc cop
|
|
|
|
More environment filtering tweaks
|
|
|
|
- only document HOMEBREW_* variables in the manpage (although still
read from all the original environment variables).
- resort manpage environment variables in alphabetical order
- check the original path for trailing slashes
|
|
|
|
Added assertion to check `HOMEBREW_LOCK_DIR.stat.mode` changes after `HOMEBREW_LOCK_DIR.chmod 0555`
|
|
Attempt to improve Travis CI. This time without any vendoring gems
nonsense.
|
|
This reverts commit 3e4547f52e7ebec633f8bfefc8a396d944edf908, reversing
changes made to 6edf9382bcc1240ad6f97c8b752cfe56cef9965d.
|
|
This reverts commit 2372872974d1049c2beafe7dedb7f8f882502058, reversing
changes made to 3e4547f52e7ebec633f8bfefc8a396d944edf908.
|
|
If people have `HOMEBREW_RUBY_PATH` set then things explode in a rather
confusing fashion. Instead, run `bundle` for them with the arguments
that they'd want.
Also, move `macho` requires into the module itself; it's a pain having
to do everything for Bundler before requiring `pathname` which is a core
Ruby class.
|
|
Homebrew's actually ended up using a fair few gems. While we want to
avoid Bundler at runtime (and this PR still does that, in fact uses
Bundler even less at runtime than it did before) writing our own version
to use at build-time seems redundant.
|
|
audit: Allow skipping/selective running of cops and cops refactor
|
|
caveats: tweak keg_only style
|
|
|
|
Also, don't delete them after that. This means that `brew postinstall`
becomes a way to easily reinstall configuration files for any formula
without needing any changes to any bottles or requiring a reinstall.
|
|
|
|
Also refactor audit cops into two "departments"
- FormulaAudit
- FormulaAuditStrict
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
If you `brew install` a formula that's already installed you get:
Warning: ripgrep-0.5.1 already installed
If you `brew install` an outdated formula that's installed you get:
Error: ripgrep-0.5.1 already installed. To install this version, first
`brew unlink ripgrep`
Instead, suggest that the user should `brew upgrade` in this case. If
the formula isn't outdated use the previous message.
|
|
|
|
|
|
|
|
Use GitHub's code search API to search using the filename based on the
search query. This means we only need a single HTTP call and no more
multithreading madness. This also means we're able to search everything
in the Homebrew and Caskroom organisation by default without having to
maintain a list of things to search (and not) in here.
|
|
I wasn’t aware this existed when I created puts_hash so: may as well
remove it.
|
|
audit: audit_components method to rubocops and tests
|
|
utils: make which_editor handle editor args.
|
|
add date-based versioning
|
|
Handle cases like e.g. `EDITOR="subl -w"`.
|
|
Another attempt at fixing `brew audit` issues around detecting
`revision` and `version_scheme` changes correctly. First done in #1754
and #2086 (reverted in #2099 and #2100).
To ease future debugging a `ph` helper has been added to print a hash
and a series of RSpec tests to verify that the `revision`,
`version_scheme` and `version` formula version audits behave as
expected.
Fixes #1731.
|
|
Fix those that can be done so without tearing Homebrew to pieces and
remove the comments for those that can never be done.
|
|
Hide sensitive tokens from install/test/post.
|
|
Install uninstall messages
|
|
Refactor cask metadata directory methods.
|
|
More deprecations.
|
|
|
|
travis.yml: cache Bundler output.
|
|
Hide these tokens to avoid malicious subprocesses e.g. sending them
over the network. Also, support using these tokens with environment
filtering and clear `HOMEBREW_PATH` from subprocesses to stop them
sniffing it. Finally, use `HOMEBREW_PATH` to detect Homebrew’s user’s
PATH for e.g. `brew doctor` etc.
|
|
Deprecate more methods. Internal APIs have been verified to be unused
elsewhere and removed. External APIs have had deprecation methods added.
Existing deprecations have been either upgraded to produce warnings or
no longer deprecated and the reasoning documented.
|
|
Travis needs some coaxing to find where we put it. This should improve
build reliability due to network issues.
|
|
- Tweak the way offline skipping happens
- Skip more tests that break when offline
- Hide more stdout output from tests.
|
|
For many people `brew edit` makes use of the `EDITOR` variable to pick a
sensible editor. With environment filtering enabled unless this editor
is found in the default system PATH it'll fall back to e.g. `vim`.
Instead, ensure that we export the original, pre-filtering `PATH` as
`HOMEBREW_PATH` and use that internally to locate the editor. In future
this same approach will likely be used for requirements to be able to
find tools, too, and for other variables which we want to expose to
Homebrew itself but not other build tools.
Note that `HOMEBREW_PATH` is the same as `PATH` when build filtering
hasn't been enabled.
|
|
Partly revert “Fix `uninstall :pkgutil` leaving empty `.app` directories.”.
|
