| Age | Commit message (Collapse) | Author |
|
doctor: Check for branch of core tap (take 2)
|
|
|
|
|
|
|
|
|
|
|
|
Hiding all output makes it look like Homebrew is hanging while the tap
operation (which can take a long time!) is running.
Closes #3053.
|
|
Detect `Tap` in `CaskLoader`.
|
|
|
|
|
|
refactor: DRY up redundant formulations of {#user}/homebrew-{#repo}
|
|
full_name is formed from `{user}/homebrew-{repo}` and is always
lowercase.
|
|
|
|
|
|
On Linux this defaults to Linuxbrew but in some cases (i.e. a Linux
machine performing uploads for Homebrew) we want to allow this to be
overridden back to the defaults.
Relies on a change incoming to `brew test-bot` to set this there.
|
|
They don't contain any formulae so tapping them will add pointless
clutter.
|
|
This makes it easier to turn an arbitrary path into a tap path.
|
|
|
|
|
|
Taps can include completion scripts for external commands under
`completions/bash`, `completions/fish`, or `completions/zsh`. `brew tap`
will automatically install these into the correct directories during
install.
|
|
Check for Ruby files in taps that are outside of the detected `Formula`
directory for a tap but inside one of the other potential directories.
This usually indicates a formula has been added in the wrong directory
in a tap and is used to fail CI in this case.
|
|
|
|
Another look at the current Rubocop rules and how they fit with our
existing and desired future style. Almost all of these changes were
automatic. Split some rules between formulae/brew where brew doesn't
have millions of cases that need fixed.
|
|
|
|
|
|
|
|
But remove some manual `.freeze`s on constants that shouldn't be
constants.
|
|
|
|
|
|
|
|
|
|
|
|
This reverts commit 05daa0574732a7884bd158b2c3e14bd0709367da.
|
|
Closes #562.
|
|
`Tap.fetch` and commands building on top of it accepted tap names like
`homebrew/homebrew/bogus` causing some misbehavior. Ensure neither
`user` nor `repo` include slashes and print a more helpful error message
that additionally includes the problematic tap name.
Closes #585.
Closes #591.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
Or how many taps are private when summarizing all installed taps.
|
|
* readall: move readall logic to new class.
* tap: run readall when tapping.
This will prevent tapping an tap with syntax errors from causing issues
for users.
Fixes #58.
|
|
Closes #464.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
|
|
* without `default_remote`, `CoreTap#install` won't be able to tell
whether user has passed to custom remote to it.
* simplify some part of logics
|
|
* remote check requires `git` installed.
* Do not perform check if user does not passing remote explicitly.
Fixes #108
|
|
* make `read_or_set_private_config` private
* add doc
* add test
|
|
Use both an in-class and a `.git/config` cache for this so we can ensure
that the `Tap#private?` check is fast. Also, make sure this cache value
is set both when initially installing and updating a tap.
Thanks to @xu-cheng for most of the implementation here.
|
|
Makes `tap` re-runnable and unshallows when requested with `--full`.
Tapping with a different URL raises an exception.
The homebrew/core tap cannot be untapped with `untap` so running
`brew tap --full homebrew/core` is now a built-in way to get a full
clone of this tap without resorting to workarounds.
Closes #17.
Signed-off-by: ilovezfs <ilovezfs@icloud.com>
|
|
When invoking `brew tap homebrew/core`, the input options will be like
`{ :clone_target => nil }`. This renders `Hash#merge` a dead operation.
It doesn't impact Homebrew itself, but could cause problem for
downstream projects Linxubrew/Tigerbrew when they adopt core/formula
separation.
|
|
Also make `Homebrew/homebrew` as an alias of this tap to keep
backward compatibility.
|
|
It will be auto installed whenever necessary.
|
|
Ensure we don't munge line endings on checkout regardless with user's
global git config.
Closes Homebrew/homebrew#50514.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
As discovered in Homebrew/homebrew#50256, this becomes a performance bottleneck as we are
repeating construct same Pathname object.
At the same, this commit makes the behaviors between Tap and CoreTap more
consistence.
|
|
Core tap will be separated from core code in the near future.
It makes sense to rename it to CoreTap.
|