aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew/rubocops
AgeCommit message (Collapse)Author
2017-11-03Merge pull request #3395 from GauthamGoli/parameters-audit-regex-fixMike McQuaid
lines_cop: Update regex patterns to prevent false positives
2017-10-29lines_cop: Update regex patterns to prevent false positivesGautham Goli
2017-10-29formula_desc_cop: ensure no full stops at the end of descIsabell Long
- This was a suggestion by Mike McQuaid in my `homebrew-core` audit description PR. Based on ilovezfs's incantation `grep -r -E 'desc ".*\."' *.rb`, some formulae descriptions do end in full stops. (My initial assessment of this failed to account for the fact that descriptions are strings and so end in `"`.) - Add an autocorrect for this cop, too.
2017-10-27lines_cop: add missing e.g. clang++ regex SOL.Mike McQuaid
You need a start of line check in this regex (like was added in the others) to allow things like `#{bin}/clang++`.
2017-10-26lines_cop: Fix detection of negated expressionGautham Goli
2017-10-25Merge pull request #3361 from MikeMcQuaid/lines_cop_clangMike McQuaid
lines_cop: fix clang detection.
2017-10-24Refactor and fix RuboCop specs.Markus Reiter
2017-10-24lines_cop: fix clang detection.Mike McQuaid
We only care about e.g. `gcc`/`llvm-gcc`/`clang` being at the beginning of a `system` call and not anywhere within the string.
2017-10-21Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1Gautham Goli
2017-10-21lines_cop: Refactor to multiple cops and fix style violationsGautham Goli
2017-10-21Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1Gautham Goli
2017-10-18Use “squiggly” heredocs.Markus Reiter
2017-10-18Merge pull request #3291 from JCount/lines-cop-fix-wine-universal-binaryMike McQuaid
lines_cop: add ENV.universal_binary audit exemption for wine
2017-10-15lines_cop: add ENV.universal_binary audit exemption for wineJCount
2017-10-14formula_desc_cop: empty string is not a valid descDominyk Tiller
Just a slightly tweaked version of https://github.com/Homebrew/brew/issues/3286#issuecomment-334983011
2017-10-13Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1Gautham Goli
2017-10-07Fix RuboCop tests.Markus Reiter
2017-09-24Rubocop: manual rule fixes.Mike McQuaid
2017-09-05Merge pull request #3091 from GauthamGoli/audit_line_rubocop_part_3Mike McQuaid
audit: Port line_problems to rubocop and add tests part 3
2017-09-04audit: Port audit_class to rubocop, add tests and autocorrectGautham Goli
2017-09-04audit: Fetch formula name from file path rather than class name in copsGautham Goli
2017-09-04audit: Add tests for rubocop methods in line_cop.rbGautham Goli
2017-09-04audit: Port rules from line_problems to rubocop part 3Gautham Goli
2017-08-26audit: Add previously unported GH patch audit rule in Patches copGautham Goli
2017-08-23Merge pull request #2995 from GauthamGoli/audit_line_rubocop_part_2JCount
audit: Port line_problems to rubocop and add tests part 2
2017-08-17audit: In Cops and their tests convert all multiline strings to heredocsGautham Goli
2017-08-15add tests for condition dependenciesGautham Goli
2017-08-15Add tests for MACOS version consts usageGautham Goli
2017-08-15add test for ARGV.include?Gautham Goli
2017-08-15add test for ENV.fortranGautham Goli
2017-08-15add test for inspecting versionGautham Goli
2017-08-15add tests for dependenciesGautham Goli
2017-08-14add test for env mod through system callGautham Goli
2017-08-14add tests for vendored depsGautham Goli
2017-08-14add tests for formula path shortucut 3Gautham Goli
2017-08-14add tests for formula path string 1Gautham Goli
2017-08-14add tests for hardcoded compilers in ENVGautham Goli
2017-08-14add tests for hard coded compilers in system callsGautham Goli
2017-08-14add tests for man+'man[1-8]'Gautham Goli
2017-08-14add test for using ARGV to check optionsGautham Goli
2017-08-14add test for build.include? having dashed argsGautham Goli
2017-08-14add test for build.include?Gautham Goli
2017-08-14add test for build.with? "--with-foo"Gautham Goli
2017-08-14add test for build.without --without-fooGautham Goli
2017-08-14Add negated? method to formula cop and add tests for negated build.without?Gautham Goli
2017-08-14Add test for negated build.with?Gautham Goli
2017-08-14Add tests for unless build.with?Gautham Goli
2017-08-14Add tests for unless build.without?Gautham Goli
2017-08-14Add test for top level method defGautham Goli
2017-08-14Add tests for fileUtils call in systemGautham Goli