| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
This was missed when I was focused on cleaning up versioned aliases.
Fixes #2992.
|
|
Cleanup old, versioned aliases and tap aliases folders when unlinking
or uninstalling a keg.
|
|
|
|
|
|
|
|
|
|
|
|
These versioned aliases don’t correspond to the correct version if not
Installed from stable.
Fixes #2596.
|
|
Fixes #2427.
|
|
Fixes https://github.com/Homebrew/homebrew-core/issues/10338.
Closes #2287.
Signed-off-by: Alex Dunn <dunn.alex@gmail.com>
|
|
Don't use the basename but instead use the Formulary logic for rack
formula resolution.
Fixes #2288.
|
|
|
|
Exclude executables in #empty_installation? to avoid 'Empty
Installation' error when only executable which name is the
same as one of metafiles is installed.
|
|
Fixes an issue introduced in #1192 where there would be a failure if the
alias link didn't exist on removal (which would be the case for anything
with an alias installed before #1192 was merged).
|
|
|
|
in case people expect to be able to find the prefix by only resolving
the symlink once (e.g., if they're using readlink not realpath)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This seems to be a remnant of Ruby 1.8.
|
|
|
|
This guards against this being a non-symlink in which case it will fail.
|
|
formula: make prefix usually return opt_prefix.
|
|
|
|
|
|
Closes #1525. (See there for a motivation for this change.)
|
|
In #1497 I switched from Keg#to_formula for comparing kegs to formulae
to comparing the name and tap in the keg's tab to the name and tap of
the formula.
However, this fails to match if the name and tap of the formula have
changed since the keg was installed, so it's clearly better to use
Keg#to_formula where possible, and fall back to the information in the
tab when #to_formula can't be used.
|
|
keg: fall back for dependencies of buggy tabs
|
|
keg: don't return nil dependencies
|
|
Return `opt_prefix` if it exists and `prefix` is not called from within
the same formula's `install` or `post_install` methods. Otherwise, fall
back to the existing functionality.
This avoids the need to use `opt_prefix` etc. everywhere and generally
means we don't expose an implementation detail (i.e. the full Cellar
path) to dependents that have a habit of hard-coding it.
|
|
This is a proper fix to the problem addressed by #1510.
The problem arises when f_kegs is nil, which can happen if the name and
tap used to install a keg don't match the name and tap currently
associated with its formula (i.e. if it's been renamed or moved).
|
|
See https://github.com/Homebrew/brew/pull/1752#discussion_r94257147
|
|
See https://github.com/Homebrew/brew/pull/1750#discussion_r94243825 for
discussion.
Removes Tab#reliable_runtime_dependencies? in favour of returning nil
from Tab#runtime_dependencies if the list is unreliable.
Because Homebrew 1.1.6 hasn't been tagged yet, tabs created in tests
aren't created with a homebrew_version that marks the
runtime_dependencies in the Tab as reliable, so there are some tests
that fail. To work around this, I've had to add a line to some tests
that explicitly overrides the homebrew_version in the Tab. This is
really ugly though, so they should be removed as soon as possible after
1.1.6 is released.
|
|
Fixes #1524.
|
|
Fixes #1554.
|
|
Because of an accidental use of `=` instead of `==`, the source formula
check would be skipped when determining if a keg depended on another one
(so only the versions would be compared).
Fixed that comparison, and updated the corresponding test.
Glad I caught that!
|
|
Previously, trying to resolve the dependencies of a keg would raise an
exception if the formulae for any of the dependencies could not be found
(e.g. if it had been moved to another tap).
This commit updates the dependency finding logic to catch these
exceptions, and fall back to comparing names and taps of formulae, which
should give the correct behaviour.
Fixes #1586.
|
|
caveats: Differentiate zsh completion files and function files
|
|
If there's dead symlinks in there they should be removed.
|
|
When installing a file to zsh/site-functions directory, it is assumed this is a zsh completion file,
and the zsh completion caveat is printed after installation.
But not all files in the zsh/site-functions directory are completion files.
Some are files for functions that can be loaded on demand with zsh's autoload command.
- Edit Keg.completion_installed to search specifically for files in the zsh/site-functions
directory starting with an underscore only (By convention, zsh completion files start with an underscore)
- Add Keg.zsh_functions_installed to search for non-completion files in the zsh/site-functions
- Add Caveats.zsh_function_caveats to print a caveat if non-completion files have been installed
to zsh/site-functions
|
|
Fish shell allows third-party software vendors to put their own function files in a directory for their software.
For brew installed Fish shell, this is /usr/local/share/fish/vendor_functions.d
|
|
It doesn't always work.
For example, a keg could have been installed with a formula from a
URL, which Homebrew now does not know how to access.
Fixes #1496.
|
|
|
|
|
