| Age | Commit message (Collapse) | Author |
|---|
|
This is no longer needed as the reason it was added (argument
sanitisation) is now done properly.
Also, remove `skip_deps_check?` in favour of `ignore_deps?` as it too is
no longer needed.
|
|
Fix dependency option handling.
|
|
reinstall/upgrade/install: always output options.
|
|
- formula_installer: only recompute dependencies when necessary i.e.
when a bottle pour fails.
- formula_installer: re-add accidentally remove dependency options
- dependency: missing options are only those that actually exist on a
formula
|
|
This is both easier for debugging and to communicate with users what is
being done.
|
|
When reading a building a formula from a keg (rather than e.g. from
name) then the deprecation options were not remapped correctly as they
are only done in `Tab.for_formula` and not `Tab.for_keg`. Ensure that
after we’ve created the formula that the `used_options` are remapped
correctly.
|
|
|
|
When a formula depends on any requirements, they evaluated at most three times:
before locking, before installing dependent, before building formula.
When a non-fatal requirement is specified and thus evaluated three times,
mostly the same warning message is also emitted three times.
This change restricts printing the warning messages only when a bottle is
successfully installed or before building.
Since this timing is after the final dependency computation for each cases,
the warnings will be most useful to check what is not yet satisfied.
|
|
|
|
Invalid build option warnings - supersedes #1088
|
|
If `--with-foo` is provided to a formula through a tab or through
another formula depending on it and this option does not exist it
should be filtered. If it is not (the prior behaviour) then this can
prevent bottles being used unnecessarily.
Fixes #1399.
|
|
|
|
Apparently `cellar :any_skip_relocation` doesn't actually mean we
can skip relocation, at least for text files.
|
|
Replace relocate_text_files with three methods that clarify intent:
replace_locations_with_placeholders, replace_placeholders_with_locations
and replace_text_in_files, the first two calling the third.
|
|
`brew bottle` replaces instances of the Homebrew prefix, cellar, and
repository with placeholders in all text files. Cache these files in
INSTALL_RECEIPT.json so that we don't have to check every single text
file for placeholders on install.
|
|
This avoids needlessly installing build-time dependencies of dependencies
which are not themselves being built from source.
|
|
ruby-macho now performs all relocations in Homebrew.
Additionally, delete the defunct CctoolsRequirement.
|
|
|
|
|
|
Store the formula used to build the keg in the keg
|
|
|
|
Store the formula used to build the keg inside the keg in a
file named NAME/VERSION/.brew/NAME.rb after removing the
bottle do ... end block.
See https://github.com/Homebrew/brew-evolution/pull/6.
Closes https://github.com/Homebrew/brew/issues/931.
|
|
|
|
|
|
|
|
Now that the default from the installer, our CI and soon all users
is `/usr/local/Homebrew` it's a lot easier to check if there's
references to it (as we cannot look for `/usr/local` as it's a too
commonly hardcoded path).
|
|
|
|
But remove some manual `.freeze`s on constants that shouldn't be
constants.
|
|
formula_installer will use stdenv if scons is anywhere in the formula's
recursive dependency list:
https://github.com/Homebrew/legacy-homebrew/issues/40401#issuecomment-110066355
Having scons as a dependency should only require stdenv if it is an
immediate build dependency, as otherwise scons shouldn't be invoked.
|
|
Save aliases in INSTALL_RECEIPT
|
|
Prompt user to unpin pinned dependencies of the formula
|
|
|
|
|
|
Part of #567
|
|
Dependencies/requirements of a dependency need to be installed/satisfied
before the dependency. The fact that @pour_failed may be false is
irrelevant to that imperative if we weren't pouring to begin with, so
this commit now checks for that case as well.
|
|
|
|
|
|
See Homebrew/legacy-homebrew#48449
|
|
|
|
If a requirement is for a dependent that's already installed and that
dependency is not using a `default_formula` (which would have already
been converted from a `Requirement` to `Dependency` at this stage) then
we want to stop it killing the build.
|
|
Read the discussion in https://github.com/Homebrew/homebrew-core/pull/3703. If you
have a better idea, please file a competing PR. I'm sick to death of discussion.
Closes #662.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Doesn't feel like a good reason to abort installation for users if the
formula author has specified a conflict that doesn't exist. Instead,
behave more like the `TapFormulaUnavailableError` but print a message
telling people to report to the formula authors.
Closes https://github.com/Homebrew/homebrew-versions/issues/1327
|
|
|
|
This fixes a regression caused by 2e961dc9dee63f641f7f162fd7a2845c5fd092fe,
where a misplaced `+` cause the regex only catch one character.
Fixes https://github.com/Homebrew/homebrew-science/issues/3847.
|
|
|
|
|
|
|
|
|
|
|
|
When a given dependency appears multiple times in a formula's dependency
tree, the inherited options for that dependency should accumulate rather
than being overwritten each time that dependency is considered by
expand_dependencies. In particular, this impacts "universal" since the
dependency should be built with universal unless all of its instances in
the dependency tree don't have "universal" as opposed to only if the last
instance considered has "universal."
Closes Homebrew/homebrew-core#1604.
Closes #308.
Signed-off-by: ilovezfs <ilovezfs@icloud.com>
|
