aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew/diagnostic.rb
AgeCommit message (Collapse)Author
2016-11-26diagnostic: silence a Jenkins doctor warning.Mike McQuaid
Allow our Jenkins CI testing for Homebrew/brew to live outside of `/usr/local` without complaint (as it's not using any binary packages anyway).
2016-11-25Revert "Merge pull request #1562 from woodruffw/check-admin-group"Mike McQuaid
This reverts commit 7f13b37b903564e2a64cea982d6b84d1aa6b800b, reversing changes made to 62e0ecdaafbc6779205908c7ab191c884473afd6.
2016-11-25Revert "Merge pull request #1567 from cesarandreu/fix-diagnostic-conditonal"Mike McQuaid
This reverts commit 89c3348923c3450d8d32f1252abd53209b39c288, reversing changes made to 7f13b37b903564e2a64cea982d6b84d1aa6b800b.
2016-11-25Fix early exit condition for check_for_member_of_admin_groupCesar Andreu
2016-11-24diagnostic: check if the user is a member of the admin group.William Woodruff
Non-administrative users are unable to run `brew linkapps` (and possibly other commands) under normal circumstances.
2016-11-13Rename single line block parameters to `acc/elem`.Markus Reiter
2016-11-11Check the lock directory is writable.Mike McQuaid
And, if it isn't, print more helpful debugging messages. Fixes #1456.
2016-11-11Merge pull request #1082 from alyssais/uninstall_dependancy_errorMike McQuaid
uninstall: refuse when dependents still installed
2016-11-06Merge remote-tracking branch 'origin/master' into HEADMike McQuaid
2016-11-05diagnostic: add build error checks.Mike McQuaid
2016-11-05diagnostic: only make minimum Xcode/CLT version checks fatal.Mike McQuaid
Also: freeze the relevant arrays.
2016-11-04diagnostics: whitelist dylib installed by SentinelOneJosh Hagins
2016-11-04Add static libs and dylibs commonly put in /usr/local/lib by Symantec ↵James Young
Endpoint Protection to the brew doctor white lists
2016-10-25missing_deps: extract formula instance methodAlyssa Ross
2016-10-25missing: simplify code a bitAlyssa Ross
2016-10-25missing: allow hiding specified formulaeilovezfs
2016-10-13brew doctor: warn about SSL_CERT_FILE (#1284)Paolo G. Giarrusso
Multiple issues have been filed about this environment variable, hence give a warning. #932 might make this unnecessary when merged, but hopefully this warning can be merged quickly.
2016-10-09diagnostic: handle HOMEBREW_TEMP mktmpdir failure.Mike McQuaid
Fixes #1223.
2016-10-04Refactor Cask’s extensions.Markus Reiter
2016-10-02*/diagnostic: tweak messaging.Mike McQuaid
Update some messaging based on recent user confusion and the `/usr/local/Homebrew` and Ruby 2 migrations.
2016-10-01Use Formatter for all URLs.Markus Reiter
2016-09-26doctor: remove outdated Homebrew check.Mike McQuaid
This is no longer relevant in the bright, new tagged future. Fixes #1151.
2016-09-23Fix Style/RegexpLiteral.Markus Reiter
2016-09-23Fix Style/SingleLineBlockParams.Markus Reiter
2016-09-23Fix Style/MethodName.Markus Reiter
2016-09-23Auto-correct guard clauses.Markus Reiter
2016-09-18Use new "macOS" naming where appropriate.Mike McQuaid
Not quite a mass replacement as I've used OS X and Mac OS X where describing specific older versions and added compatibility methods for things in the DSL.
2016-09-17Improve rescue nesting.Mike McQuaid
2016-09-17rubocop --auto-correct all remaining files.Mike McQuaid
But remove some manual `.freeze`s on constants that shouldn't be constants.
2016-09-15Merge pull request #966 from MikeMcQuaid/keg-lock-constantsMike McQuaid
Use constants for LinkedKegs/PinnedKegs/Locks.
2016-09-15Use constants for LinkedKegs/PinnedKegs/Locks.Mike McQuaid
These definitions are scattered throughout the codebase which makes it hard to refactor them later (my goal is to move them outside of HOMEBREW_LIBRARY). Unify their definitions for clearer code and easier movement later.
2016-09-15keg: add ALL_TOP_LEVEL_DIRECTORIES constant.Mike McQuaid
This is used in diagnostic (and will be used in other places later) rather than hard-coding other directories later.
2016-09-09diagnostic: remove duplicate checks.Mike McQuaid
2016-09-09Don't require/recommend ownership of /usr/local.Mike McQuaid
Apple reset this on every OS X major (and some minor) updates and it always proves a painful and unnecessary step. Instead just check the directories we actually care about are writable. This may mean if these directories do not already exist (although they are now created by the installed) that `brew link` will fail and require manual intervention but this seems to be superior for both new and the majority of existing users.
2016-09-07Merge pull request #833 from DomT4/death_by_xcodeMike McQuaid
xcode: die unless Xcode/CLT up-to-date on prerelease macOS
2016-09-07Refactor MacOS check_development_tools usage.Mike McQuaid
Better use the abstraction layer so e.g. Linux could have similarly fatal checks for these things.
2016-09-04Merge pull request #201 from gregory-nisbet/feature-env-shellsMike McQuaid
--env: support more shells, allow explicit shell selection
2016-08-25diagnostic: tweak /usr/local messaging.Mike McQuaid
Highlight that the main reason for preferring /usr/local is because of bottles. There's been some confusion around this e.g. https://github.com/Homebrew/homebrew-core/issues/3968
2016-08-22Revert "diagnostic: ignore duplicated `brew-cask` commands"Mike McQuaid
2016-08-19diagnostic: ignore duplicated `brew-cask` commandsMike McQuaid
These are intentionally duplicated for now until the Cask migration is complete.
2016-08-16diagnostic: don't barf if HEAD is also a file.Mike McQuaid
Closes #694.
2016-08-10tests for shell-specific diagnostic messageGreg Nisbet
2016-08-10Multi-shell diagnostic checkGreg Nisbet
2016-08-10resolve conflict in diagnostic.rbGreg Nisbet
2016-08-10diagnostic: remove MacGPG2 checkDominyk Tiller
This hasn't been an issue for upstream stable releases for 3 years, since March 2013, and hasn't been an issue for pre-release versions for 4 years. That release, and indeed the latest modern GPGTools releases, support 10.6 and above so there's no reason to suspect people are actually encountering the old versions in the wild with enough regularity to merit this being a permanent part of our codebase any more. In the last two years Homebrew has seen one Issue where MacGPG2 was the problem, and that wasn't reproducible at the time (and still isn't), and the `doctor` check likely wasn't even raised there. There has only been one Issue where the MacGPG2 `doctor` check was raised in that two year period. I think it's fair to treat this as an user configuration outlier now rather than an issue we need to be constantly on guard for. Ref: Homebrew/legacy-homebrew@dfb171b Ref: Homebrew/legacy-homebrew#12238 Ref: Homebrew/legacy-homebrew@046498b
2016-07-29Add missing development_tools requires.Mike McQuaid
2016-07-27diagnostic: port to generic layer.Mike McQuaid
2016-07-16Unify Version.create usageVlad Shablinsky
Substitue each Version.new and HeadVersion.new with Version.create to unify Version and HeadVersion instantiation among core code. Note that this does not relate to Mac::OS::Version class.
2016-07-10diagnostic: adopt more certain toneDominyk Tiller
Closes #481. Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-07-07Use GitRepositoryExtension for HOMEBREW_REPOSITORYMartin Afanasjew