aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew/dev-cmd/audit.rb
AgeCommit message (Collapse)Author
2017-06-10Autocorrect Rubocop Style/PerlBackrefs.Mike McQuaid
2017-06-09Revert "audit: Port audit_checksum method to rubocop and add tests"Mike McQuaid
2017-06-08audit: Port audit_checksum method to rubocop and add testsGautham Goli
2017-06-08audit: ensure curl always has an HTTP url.Mike McQuaid
This makes using `HOMEBREW_CURL` significantly nicer as then the system `curl` (that, on old versions, sucks at SSL) can download a version of `curl` that it can build from source.
2017-06-03audit: fix pypi strict audit capture group.Mike McQuaid
2017-06-03Merge pull request #2726 from MikeMcQuaid/audit-pypi-urlsMike McQuaid
audit: check pypi URLs
2017-06-03Merge pull request #2725 from MikeMcQuaid/audit-formulae-options-fixMike McQuaid
audit: fix false negative for formulae options.
2017-06-02audit: check pypi URLsMike McQuaid
#373 implemented as a strict check (thanks nijikon)
2017-06-02audit: fix false negative for formulae options.Mike McQuaid
Handle the case where an if/unless is detected and then write off this line for option handling.
2017-06-02Re-revert "Fix operator spacing."Markus Reiter
2017-05-31audit: Port audit_caveats method to rubocop and add testsGautham Goli
2017-05-30audit: Port audit_text method to rubocop and add testsGautham Goli
2017-05-29Fixup all RuboCop warnings.Mike McQuaid
2017-05-21Merge pull request #2658 from JCount/audit-fix-versioned-aliases-homebrew-coreJCount
audit: fix versioned alias errors in homebrew/core introduced in a7c6a57
2017-05-22Change error messages.Markus Reiter
2017-05-22Use `FormulaVersions` for checksum check.Markus Reiter
2017-05-22Add the same check for Formulae.Markus Reiter
2017-05-21audit: fix versioned alias errors in homebrew/core introduced in a7c6a57JCount
This fixes #2657 which in turn were caused by an oversight in #2664
2017-05-20Merge pull request #2644 from JCount/audit-fix-tap-versioned-aliasesMike McQuaid
audit: fix full versioned alias name resolution in taps
2017-05-18Merge pull request #2537 from reitermarkus/pathname-to_strMarkus Reiter
Remove `to_s` from some `Pathname`s.
2017-05-17audit: fix full versioned alias name resolution in tapsJCount
This fixes an issue where audit would prompt for the creation of an already existing versioned alias while at the same time declaring the existing alias invalid.
2017-05-15Merge pull request #2631 from GauthamGoli/audit_homepage_rubocop1.2.1Mike McQuaid
audit: Port audit_homepage method to rubocop and add tests
2017-05-14Port audit_homepage method to rubocop and add testsGautham Goli
2017-05-14Merge pull request #2627 from MikeMcQuaid/audit-fix-option-detectionMike McQuaid
audit: fix dependency option detection.
2017-05-13audit: fix dependency option detection.Mike McQuaid
Instead of trying to do this all with a single regex give up and do a two stage process. Eventually I'll end up implementing a full ruby parser here :troll:.
2017-05-09audit: more checks for versioned aliases.Mike McQuaid
Check that a required versioned alias has a valid name (rather than assuming it’s fine based on it’s existence alone) and check for the presence of invalid version aliases. This should handle the case where someone bumps a formula but forgets to rename the alias that’s mentioned in #2596.
2017-05-08Remove `to_s` from some `Pathname`s.Markus Reiter
2017-05-07Revert "Merge pull request #2597 from MikeMcQuaid/vendor-gems"Mike McQuaid
This reverts commit 3e4547f52e7ebec633f8bfefc8a396d944edf908, reversing changes made to 6edf9382bcc1240ad6f97c8b752cfe56cef9965d.
2017-05-07Vendor all Homebrew's gems.Mike McQuaid
Homebrew's actually ended up using a fair few gems. While we want to avoid Bundler at runtime (and this PR still does that, in fact uses Bundler even less at runtime than it did before) writing our own version to use at build-time seems redundant.
2017-05-03Merge pull request #2531 from GauthamGoli/audit_cops_options_refactorMike McQuaid
audit: Allow skipping/selective running of cops and cops refactor
2017-05-03Add `--only-cops`,`--except-cops` options for brew style and simplify cop namesGautham Goli
2017-05-02audit: match start of string, not lineDominyk Tiller
2017-05-02audit: whitelist 'Firefox' in keg_only_styleDominyk Tiller
2017-05-02Add `--only-cops`,`--except-cops` options for brew auditGautham Goli
Also refactor audit cops into two "departments" - FormulaAudit - FormulaAuditStrict
2017-05-02Let cops run without --strict flagGautham Goli
2017-05-01audit: add audit_keg_only_styleDominyk Tiller
2017-04-28audit: formally ban go get usageDominyk Tiller
There's been an informal ban for a while but let's be punchier because this crops up still.
2017-04-27audit: tweak dependency option audit.Mike McQuaid
Make sure that `if build.with?` isn't caught.
2017-04-26audit: fix audit of new formulae.Mike McQuaid
When auditing new formulae without `--new-formula` the `audit_revision_and_version_scheme` method fails ungracefully. Instead, set some better defaults so fewer checks are needed. Fixes #2551.
2017-04-25audit: fix use of search_tap method.Mike McQuaid
This was removed in #2540 but this call site was note updated to use the `search_taps` method instead.
2017-04-24Merge pull request #2465 from GauthamGoli/audit_components_port_rubocopMike McQuaid
audit: audit_components method to rubocops and tests
2017-04-23Fix audit version_scheme and revision checks.Mike McQuaid
Another attempt at fixing `brew audit` issues around detecting `revision` and `version_scheme` changes correctly. First done in #1754 and #2086 (reverted in #2099 and #2100). To ease future debugging a `ph` helper has been added to print a hash and a series of RSpec tests to verify that the `revision`, `version_scheme` and `version` formula version audits behave as expected. Fixes #1731.
2017-04-22Port audit_components method to rubocops and add corresponding testsGautham Goli
2017-04-22Merge pull request #2526 from MikeMcQuaid/audit-gnu-mirror-flipMike McQuaid
audit: flip GNU mirror preference.
2017-04-22audit: flip GNU mirror preference.Mike McQuaid
Now that both the primary and mirror URLs use HTTPS we can flip these around so the primary URL is the primary URL and we don't have problems with waiting for mirror propagation.
2017-04-22audit: lookup unversioned formulae with Formulary.Mike McQuaid
This means that if e.g. the unversioned formulae exists in another tap this audit won't produce a false positive.
2017-04-22Merge pull request #2482 from MikeMcQuaid/audit-dependency-optionsMike McQuaid
audit: ensure default dependencies don't use options.
2017-04-21audit: ensure dependencies don't use options.Mike McQuaid
Option dependencies are nasty as they cause unnecessary builds from source.
2017-04-21audit: new formulae should not require patches.Mike McQuaid
We may under some circumstances accept these anyway but it's better to nudge people into the right behaviours on local `audit`s.
2017-04-19audit: fix swapped audit messagesSteven Peters