aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew/dev-cmd/audit.rb
AgeCommit message (Collapse)Author
2017-01-17audit: only warn on versioned conflicts_with.Mike McQuaid
Rather than all versioned formulae regardless. Oops.
2017-01-17Add `keg_only :versioned_formula`.Mike McQuaid
This is used to indicate a formula is a version of another formula. This will be used to provide a consistent interface for older formulae versions and replaces the use of `conflicts_with`.
2017-01-17Merge pull request #1844 from MikeMcQuaid/audit-universalMike McQuaid
audit: don't allow universal for new formulae.
2017-01-15audit: don't allow universal for new formulae.Mike McQuaid
We're frowning on these now so may as well turn that into code.
2017-01-13audit: whitelist unstable versions already in coreilovezfs
also allow higher stable versions with the same version prefix
2017-01-09audit: check virtualenv and setuptools resource.Mike McQuaid
`virtualenv_install_with_resources` will automatically define and install a `setuptools` resource so this is unnecessary. References https://github.com/Homebrew/homebrew-core/pull/8570
2017-01-07Allow `brew audit` to fake a Safari user-agent.Mike McQuaid
This allows us to detect if homepages such as e.g. `aiccu` which blocks `curl` are up or not.
2017-01-03audit: deprecate env :std/:userpaths for strict.Mike McQuaid
This should apply only for new formulae but we should start gradually phasing it out for older ones too.
2016-12-30audit: use new curl_args form.Mike McQuaid
This will use Curl’s default user agent to reduce homepage errors and provides a function that can be used for other audits to perform similar tests on URLs.
2016-12-29audit: improve reliability of homepage audit.Mike McQuaid
- Don't run on Yosemite where the system Curl is too old for some modern HTTPS homepages - Try up to 3 times in case of transient failures.
2016-12-29audit: don't allow openssl & libressl dependency.Mike McQuaid
Formulae should not depend on both OpenSSL and LibreSSL (even optionally). This is to avoid descending into madness where every formulae that could use LibreSSL has to have option and switching logic. Homebrew has standardised on OpenSSL and will do so everywhere that LibreSSL is not a hard requirement.
2016-12-23Merge pull request #1693 from broder/homepage_checkMike McQuaid
Updated homepage 404 check to use explicit parameters and return the …
2016-12-20audit: fix 32-bit check.Mike McQuaid
2016-12-20Merge pull request #1695 from MikeMcQuaid/audit-revision-map-nilMike McQuaid
audit: handle a nil revision map.
2016-12-20Merge pull request #1698 from MikeMcQuaid/deprecate-32-bitMike McQuaid
Deprecate 32-bit options.
2016-12-20Deprecate 32-bit options.Mike McQuaid
These were formerly supported but as it has been a very long time since 32-bit software was necessary on macOS these have been deprecated with a `brew audit` warning and a future `odeprecated`.
2016-12-19MarkupsDavid Broder-Rodgers
2016-12-18audit: handle a nil revision map.Mike McQuaid
2016-12-18audit: don't allow use of OS.mac?/OS.linux?.Mike McQuaid
Forbid their use in Homebrew/core which only supports macOS. This may be added to more/all official taps in future.
2016-12-18Updated homepage 404 check to use explicit parameters and return the status codeDavid Broder-Rodgers
2016-12-13audit: flag use of "fails_with :llvm".Mike McQuaid
Also, add TODOs for deprecating this properly at a later point.
2016-11-23audit: allow deprecated options on new @ formulae.Mike McQuaid
As these may be migrations from another tap where we want to migrate options across correctly.
2016-11-20audit: check formula name against blacklisted names.William Woodruff
2016-11-18Merge pull request #1528 from MikeMcQuaid/audit-devel-revisionMike McQuaid
audit: don't check devel version_scheme/revision.
2016-11-18audit: check for HOMEBREW_PREFIX test path usage.Mike McQuaid
This is also not allowed. As seen in https://github.com/Homebrew/homebrew-core/pull/6996.
2016-11-17audit: don't check devel version_scheme/revision.Mike McQuaid
These are formulae-wide so doesn't make sense to iterate through these for specs and get weird results. As seem in https://github.com/Homebrew/homebrew-core/pull/6952.
2016-11-16Update `.rubocop_todo.yml`.Markus Reiter
2016-11-16Merge pull request #1522 from MikeMcQuaid/audit-one-previous-commit1.1.1Mike McQuaid
audit: only check previous formula version.
2016-11-16audit: only check previous formula version.Mike McQuaid
For calculating the stable/devel versions this should be sufficient as it's looking at `origin/master` so for a e.g. unmerged pull request this will stop complaining about mistakes outside the pull request itself. This will silence all warnings for historic version mistakes (i.e. before these audit checks were all enabled) which is normally a bad thing but as this case would rely on modifying history to complete is a good one.
2016-11-16audit: check that there are any stable revisions.Mike McQuaid
Fixes the exception if `revision_map[formula.stable.version]` is `nil`.
2016-11-15audit: fix "version should not decrease" (again).Mike McQuaid
- output the max version and current version to make the message more obvious. - Don't compare the development spec version to the formula version and then complain the formula version is lower (it should always be!)
2016-11-13audit: fix "version should not decrease" check.Mike McQuaid
Fix the "version should not decrease" check so it correctly handles `version_scheme`s. Fixes #1489.
2016-11-03audit: Escape interpolated string in regexpBaptiste Fontaine
This avoids issues with names containing special characters like e.g. [ Fixes #1431
2016-11-03Correct a few typosMandar Gokhale
...and update man pages where applicable
2016-11-02Merge pull request #1424 from MikeMcQuaid/audit-more-test-systemMike McQuaid
audit: check more unscoped test calls.
2016-11-02audit: restore check that was lost in #927Steven Peters
This audit check ensures that certain build dependencies are explicitly marked either as `:build` or `:run`. It seems to have been lost in #927. It was also adjusted in #1290.
2016-11-02audit: stricter test system calls check.Mike McQuaid
Ensure that the name is suffixed with whitespace or quotes.
2016-11-02audit: check more unscoped test calls.Mike McQuaid
Also check `def test`, `shell_output`, `pipe_output` and method calls using parentheses.
2016-10-30audit: don't check new formulae revision/versions.Baptiste Fontaine
2016-10-30audit: check the version does not decrease.Mike McQuaid
This will prevent brew upgrade from working correctly.
2016-10-30Merge pull request #1402 from MikeMcQuaid/audit-system-testMike McQuaid
audit: check test system calls are fully scoped.
2016-10-30Merge pull request #1367 from MikeMcQuaid/audit-check-master-branchMike McQuaid
audit: check for master branch tar/zipballs.
2016-10-30Revert "audit: check the version does not decrease."Mike McQuaid
2016-10-29audit: check test system calls are fully scoped.Mike McQuaid
This doesn't matter for everything but it does for the binaries that are installed. Have a limited name/alias check when not installed and a better one that iterates bin/sbin if installed.
2016-10-29audit: check for master branch tar/zipballs.Mike McQuaid
These have unstable checksums and aren't the tagged, stable releases we require.
2016-10-29Merge pull request #1366 from MikeMcQuaid/audit-check-version-decreaseMike McQuaid
audit: check the version does not decrease.
2016-10-25Merge pull request #1365 from MikeMcQuaid/audit-stable-url-betaMike McQuaid
audit: check for alpha/beta/rc usage in URLs.
2016-10-24Don’t use bare percent literals.Markus Reiter
2016-10-24audit: check for alpha/beta/rc usage in URLs.Mike McQuaid
Stable URLs should not use unstable versions.
2016-10-24audit: check the version does not decrease.Mike McQuaid
This will prevent `brew upgrade` from working correctly.